diff mbox

[FFmpeg-devel] avformat/vivo: Don't log null value

Message ID 20181125031843.64054-1-mark.hsj@gmail.com
State Accepted
Commit 01dc152a92d3ea144ac12ef25f41cc8a44f4b4ef
Headers show

Commit Message

Mark Harris Nov. 25, 2018, 3:18 a.m. UTC 
---
 libavformat/vivo.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Paul B Mahol Nov. 25, 2018, 8:52 a.m. UTC | #1 
On 11/25/18, Mark Harris <mark.hsj@gmail.com> wrote:
> ---
>  libavformat/vivo.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavformat/vivo.c b/libavformat/vivo.c
> index c9e9c37f37..9b9189f307 100644
> --- a/libavformat/vivo.c
> +++ b/libavformat/vivo.c
> @@ -166,7 +166,7 @@ static int vivo_read_header(AVFormatContext *s)
>              value = strchr(key, ':');
>              if (!value) {
>                  av_log(s, AV_LOG_WARNING, "missing colon in key:value pair
> '%s'\n",
> -                       value);
> +                       key);
>                  continue;
>              }
>
> --
> 2.19.2
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>

lgtm
Michael Niedermayer Nov. 26, 2018, 10:41 p.m. UTC | #2 
On Sun, Nov 25, 2018 at 09:52:04AM +0100, Paul B Mahol wrote:
> On 11/25/18, Mark Harris <mark.hsj@gmail.com> wrote:
> > ---
> >  libavformat/vivo.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/libavformat/vivo.c b/libavformat/vivo.c
> > index c9e9c37f37..9b9189f307 100644
> > --- a/libavformat/vivo.c
> > +++ b/libavformat/vivo.c
> > @@ -166,7 +166,7 @@ static int vivo_read_header(AVFormatContext *s)
> >              value = strchr(key, ':');
> >              if (!value) {
> >                  av_log(s, AV_LOG_WARNING, "missing colon in key:value pair
> > '%s'\n",
> > -                       value);
> > +                       key);
> >                  continue;
> >              }
> >
> > --
> > 2.19.2
> >
> > _______________________________________________
> > ffmpeg-devel mailing list
> > ffmpeg-devel@ffmpeg.org
> > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> >
> 
> lgtm

will apply

thx

[...]
diff mbox

Patch

diff --git a/libavformat/vivo.c b/libavformat/vivo.c
index c9e9c37f37..9b9189f307 100644
--- a/libavformat/vivo.c
+++ b/libavformat/vivo.c
@@ -166,7 +166,7 @@  static int vivo_read_header(AVFormatContext *s)
             value = strchr(key, ':');
             if (!value) {
                 av_log(s, AV_LOG_WARNING, "missing colon in key:value pair '%s'\n",
-                       value);
+                       key);
                 continue;
             }