From patchwork Wed Nov 28 11:11:23 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrey Semashev X-Patchwork-Id: 11203 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id AF2BA44E0A2 for ; Wed, 28 Nov 2018 13:16:48 +0200 (EET) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4FCF268A60E; Wed, 28 Nov 2018 13:16:49 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-lj1-f195.google.com (mail-lj1-f195.google.com [209.85.208.195]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1DE72689E5C for ; Wed, 28 Nov 2018 13:16:43 +0200 (EET) Received: by mail-lj1-f195.google.com with SMTP id u6-v6so23050710ljd.1 for ; Wed, 28 Nov 2018 03:16:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=o/I78NMgv5euWVpHL1ahlgRMG9OAI/kmGELvuK6ITQs=; b=c149HDSmH4zLWHXQVGZzN1yAqkzYBH8LW098vvMFzE0Qgm6GjGk1WtabU9kz6uaKVu wdCVFgSNJrQ1uX7rQJAiZnRwR6IGPAhlS/xUut8676RBJ4pCOc8NBX7/1+MtzkxlHuwx jMH3BOilFynuyxx0l76x+qIagmfQMC3hl8fUrMHvYKefVK6Q1X4H2MsVavYBVeSjenoM n3JNRt/6LRxqiz1DWE405MLArczbRec4JDyZEXK2NrVIwJaHIVctverLAZeE+odu+nsX JNC0tbXKqCCj1OkPuvX/8e/sYJEjD+0bpHdqQoMGNMKboUDXXOt9nUJ2d2D6LSQH7w/n O+gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=o/I78NMgv5euWVpHL1ahlgRMG9OAI/kmGELvuK6ITQs=; b=KdUhfN/BzOj2YK+blrF3ddTms0yt4NfxmNEP7E96+x5BdFAlvptAylq4BkqOwyVVJC oXO1QT18FPEQPj5v4d6vo7kFI1iDOxaEDV6BolHGdbAigZihTxXYl+shtHq+UXg6jB2m w3UUaiaJToiHPkytQ1pcyBIiIhXlvi/+qYEQLu2eCgpuK7hazE5EHg85L9v0Nvdda3TW opyTuqG+xzuDFa7y1OUeDPoAwoLQDEgik4OfdjPwtt2EGugXr5eiygf5ojznh6NTugSx 5DNa1vdKvz8mp8xktaYpeOQXepqEOLasgRDYMFBURCFsd6lqWY3UwShTTwt2ntagjfW8 p67g== X-Gm-Message-State: AA+aEWYvt6cqXBA8EANlWGOEXKBEDNiEVooA4bGJ6THeDLmeDYY/OxGH /fw9CpCaHlDmirdH52RQF38Jwhey X-Google-Smtp-Source: AFSGD/XB4bxNygMC/VAIZ2zEFV81f5VCc6GW+DMT/eV2LluJeDH8IdYsRdNwYzZBoux38vE+LH9JOA== X-Received: by 2002:a2e:e02:: with SMTP id 2-v6mr19589804ljo.10.1543403489619; Wed, 28 Nov 2018 03:11:29 -0800 (PST) Received: from localhost.localdomain (broadband-37-110-31-10.ip.moscow.rt.ru. [37.110.31.10]) by smtp.gmail.com with ESMTPSA id d82sm1166456lfd.82.2018.11.28.03.11.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 28 Nov 2018 03:11:28 -0800 (PST) From: Andrey Semashev To: ffmpeg-devel@ffmpeg.org Date: Wed, 28 Nov 2018 14:11:23 +0300 Message-Id: <20181128111123.15841-1-andrey.semashev@gmail.com> X-Mailer: git-send-email 2.19.1 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH] lavf/dashenc: Remove global_sidx from movenc params for live streaming. X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andrey Semashev Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" The global_sidx flag causes errors like the following in movenc when media segment removal is enabled via windos_size or remove_at_exit: Non-consecutive fragments, writing incorrect sidx Unable to re-open output file for the second pass (faststart) --- libavformat/dashenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c index 6ce70e0076..cb49641b4e 100644 --- a/libavformat/dashenc.c +++ b/libavformat/dashenc.c @@ -1141,7 +1141,7 @@ static int dash_init(AVFormatContext *s) if (os->segment_type == SEGMENT_TYPE_MP4) { if (c->streaming) - av_dict_set(&opts, "movflags", "frag_every_frame+dash+delay_moov+global_sidx", 0); + av_dict_set(&opts, "movflags", "frag_every_frame+dash+delay_moov", 0); else av_dict_set(&opts, "movflags", "frag_custom+dash+delay_moov", 0); } else {