From patchwork Wed Nov 28 18:14:06 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Niedermayer X-Patchwork-Id: 11212 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id ED66144DD7E for ; Wed, 28 Nov 2018 20:14:08 +0200 (EET) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 90F0068A7E7; Wed, 28 Nov 2018 20:14:09 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1450168A7B3 for ; Wed, 28 Nov 2018 20:14:03 +0200 (EET) X-Originating-IP: 213.47.41.20 Received: from localhost (213-47-41-20.cable.dynamic.surfer.at [213.47.41.20]) (Authenticated sender: michael@niedermayer.cc) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id D740E20004 for ; Wed, 28 Nov 2018 18:14:07 +0000 (UTC) Date: Wed, 28 Nov 2018 19:14:06 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20181128181406.GU3343@michaelspb> References: <20181127121655.1973-1-linjie.fu@intel.com> MIME-Version: 1.0 In-Reply-To: <20181127121655.1973-1-linjie.fu@intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) Subject: Re: [FFmpeg-devel] [PATCH] lavc/hevc_parser: add 4 bytes startcode condition in hevc_find_frame_end X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" On Tue, Nov 27, 2018 at 08:16:55PM +0800, Linjie Fu wrote: > The startcode before VPS,SPS,PPS and the first NALU in an AU is 4 bytes. > Blindly taking the startcode as 3 bytes will leave 0x00 in last packet > and may lead to some warnings in parse_nal_units when s->flags is set to > PARSER_FLAG_COMPLETE_FRAMES. > > Add 4 bytes startcode condition in hevc_find_frame_end. > Modify the code to print the buf_size like in H264 and reduce the duplication. > > Signed-off-by: Linjie Fu > --- > libavcodec/hevc_parser.c | 15 ++++++++++----- > 1 file changed, 10 insertions(+), 5 deletions(-) breaks make fate-hevc-bsf-mp4toannexb TEST hevc-bsf-mp4toannexb Test hevc-bsf-mp4toannexb failed. Look at tests/data/fate/hevc-bsf-mp4toannexb.err for details. make: *** [fate-hevc-bsf-mp4toannexb] Error 1 [...] --- - 2018-11-28 19:12:47.869732022 +0100 +++ tests/data/fate/hevc-bsf-mp4toannexb 2018-11-28 19:12:47.864276885 +0100 @@ -1 +1 @@ -1873662a3af1848c37e4eb25722c8df9 +73019329ed7f81c24f9af67c34c640c0