From patchwork Mon Dec 3 23:34:27 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Carl Eugen Hoyos X-Patchwork-Id: 11267 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id EB1F744DBB4 for ; Tue, 4 Dec 2018 01:34:36 +0200 (EET) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 97D5068A39E; Tue, 4 Dec 2018 01:34:28 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-it1-f170.google.com (mail-it1-f170.google.com [209.85.166.170]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 045DA68A393 for ; Tue, 4 Dec 2018 01:34:22 +0200 (EET) Received: by mail-it1-f170.google.com with SMTP id z7so12338348iti.0 for ; Mon, 03 Dec 2018 15:34:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=M8BYJGdBxw0Rc+C2MrLzIC9MM+vZ7IE+yNVaTbxHggU=; b=Y/Hn3EFssam1luKHzglvGTvPPVjQWkzlvH76iRsYNTwyVbeluNrrx+Vrj2307YJ8QH oN+pYThJ+nKdWrx9emeRRYxC0Qixnt+1FVepqkjFwZKYOeTCFxZ57/ZRzzfAFnRW1Gg9 nadVKC0VG73glVpz70/Ep9IaevFPfnBYkbXBo+3g+A840kxqXsh/n8o/8wow2YSYTTAF Ztyk/AHbvj7LlLhjJ9lkoJRUtk2tYdqFRottEzas5//4zCh1sljpiDIlEzIQfRnbj/+q RY7l7LF2Zc+WzrHO87jTTIc8+YWmJdE+B9OUuu0boOyehkYbIq2eYq+lQq4aj8JRxRhz ssAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=M8BYJGdBxw0Rc+C2MrLzIC9MM+vZ7IE+yNVaTbxHggU=; b=Mx0Wo4N6bKodQKTmkID9Eyd3475uBRsMiD0CCmkF6vHAb1DTcdaMMEXBw02RerktmX HNhVmDkS3cjg6HY9GKw3pZHFkFqpMvzvoZeL4/hjw/D1Cf0qiQ7MyzLpjwZ+GnqyVEKO oAHbH6JqfsfL91k/IMpCz3ig9xluo81ojOGYYHQ2zklME63G5cCTkPnFmX3Q6i9VN+IK C6d0ozP5eCdEkZp39BUJcgjaEXPsCVPGxTgABQOL+zfhuUYHJD6E9XAjn6gRrfDMEoae rhPswsWqK3yvQNmHs6zRI7Jsu/Q/vd66FEhYA6w+ymW1KTKpGNQCd/VtfKYXg9xLml7V HBtQ== X-Gm-Message-State: AA+aEWZDrbnYOVRBvkH/GQuFXO31lX6Zt2PCbc0xl04j4fB03bqg/fsT WwIqCySWvZF4mNUjD09sEhiccYIYzrK+jz0uc2m8aA== X-Google-Smtp-Source: AFSGD/WvdnloQzoOMY4MouON+KZlAm9S0+UQLDbMM/dlWOGfMrNQpYqeWsLAHqEGx162wOAPNoRlJjRDtSPLiBRIm2s= X-Received: by 2002:a02:9c53:: with SMTP id h19mr16905129jal.31.1543880068553; Mon, 03 Dec 2018 15:34:28 -0800 (PST) MIME-Version: 1.0 Received: by 2002:a02:5f11:0:0:0:0:0 with HTTP; Mon, 3 Dec 2018 15:34:27 -0800 (PST) From: Carl Eugen Hoyos Date: Tue, 4 Dec 2018 00:34:27 +0100 Message-ID: To: FFmpeg development discussions and patches Subject: [FFmpeg-devel] [PATCH]lavc/ivi: Fix a Google-reported memleak X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Hi! Attached patch is supposed to fix a memleak from clusterfuzz, untested... Please review, Carl Eugen From f94d6415885293351201e74a3760aae7f206515a Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Tue, 4 Dec 2018 00:32:25 +0100 Subject: [PATCH] lavc/ivi: Free an allocation on error. Fixes a memleak reported as Issue 11696 in oss-fuzz. --- libavcodec/ivi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/ivi.c b/libavcodec/ivi.c index b23d4af..19bb01e 100644 --- a/libavcodec/ivi.c +++ b/libavcodec/ivi.c @@ -406,6 +406,7 @@ static int ivi_init_tiles(IVIBandDesc *band, IVITile *ref_tile, if (p || b) { if (tile->num_MBs != ref_tile->num_MBs) { av_log(NULL, AV_LOG_DEBUG, "ref_tile mismatch\n"); + av_freep(&tile->mbs); return AVERROR_INVALIDDATA; } tile->ref_mbs = ref_tile->mbs; -- 1.7.10.4