diff mbox

[FFmpeg-devel,6/6] avcodec/codec_desc: extend gif description

Message ID 20181212163257.9109-6-onemda@gmail.com
State Accepted
Commit f2664a306fb59961d38eff647317f0e1b5295aaf
Headers show

Commit Message

Paul B Mahol Dec. 12, 2018, 4:32 p.m. UTC 
Signed-off-by: Paul B Mahol <onemda@gmail.com>
---
 libavcodec/codec_desc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Nicolas George Dec. 13, 2018, 9:49 a.m. UTC | #1 
Paul B Mahol (2018-12-12):
> Signed-off-by: Paul B Mahol <onemda@gmail.com>
> ---
>  libavcodec/codec_desc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavcodec/codec_desc.c b/libavcodec/codec_desc.c
> index 4850e4fb43..73f343ce24 100644
> --- a/libavcodec/codec_desc.c
> +++ b/libavcodec/codec_desc.c
> @@ -723,7 +723,7 @@ static const AVCodecDescriptor codec_descriptors[] = {
>          .id        = AV_CODEC_ID_GIF,
>          .type      = AVMEDIA_TYPE_VIDEO,
>          .name      = "gif",
> -        .long_name = NULL_IF_CONFIG_SMALL("GIF (Graphics Interchange Format)"),

> +        .long_name = NULL_IF_CONFIG_SMALL("CompuServe GIF (Graphics Interchange Format)"),

Is is really a good idea? I think nowadays GIF is way more famous than
CompuServe.

>          .props     = AV_CODEC_PROP_LOSSLESS,
>          .mime_types= MT("image/gif"),
>      },

Regards,
Paul B Mahol Dec. 13, 2018, 10:20 a.m. UTC | #2 
On 12/13/18, Nicolas George <george@nsup.org> wrote:
> Paul B Mahol (2018-12-12):
>> Signed-off-by: Paul B Mahol <onemda@gmail.com>
>> ---
>>  libavcodec/codec_desc.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/libavcodec/codec_desc.c b/libavcodec/codec_desc.c
>> index 4850e4fb43..73f343ce24 100644
>> --- a/libavcodec/codec_desc.c
>> +++ b/libavcodec/codec_desc.c
>> @@ -723,7 +723,7 @@ static const AVCodecDescriptor codec_descriptors[] =
>> {
>>          .id        = AV_CODEC_ID_GIF,
>>          .type      = AVMEDIA_TYPE_VIDEO,
>>          .name      = "gif",
>> -        .long_name = NULL_IF_CONFIG_SMALL("GIF (Graphics Interchange
>> Format)"),
>
>> +        .long_name = NULL_IF_CONFIG_SMALL("CompuServe GIF (Graphics
>> Interchange Format)"),
>
> Is is really a good idea? I think nowadays GIF is way more famous than
> CompuServe.

I want to make it similar with demuxer. No need to bikesheed this one.
Paul B Mahol Dec. 13, 2018, 1:52 p.m. UTC | #3 
On 12/12/18, Paul B Mahol <onemda@gmail.com> wrote:
> Signed-off-by: Paul B Mahol <onemda@gmail.com>
> ---
>  libavcodec/codec_desc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>

Will apply set ASAP.
diff mbox

Patch

diff --git a/libavcodec/codec_desc.c b/libavcodec/codec_desc.c
index 4850e4fb43..73f343ce24 100644
--- a/libavcodec/codec_desc.c
+++ b/libavcodec/codec_desc.c
@@ -723,7 +723,7 @@  static const AVCodecDescriptor codec_descriptors[] = {
         .id        = AV_CODEC_ID_GIF,
         .type      = AVMEDIA_TYPE_VIDEO,
         .name      = "gif",
-        .long_name = NULL_IF_CONFIG_SMALL("GIF (Graphics Interchange Format)"),
+        .long_name = NULL_IF_CONFIG_SMALL("CompuServe GIF (Graphics Interchange Format)"),
         .props     = AV_CODEC_PROP_LOSSLESS,
         .mime_types= MT("image/gif"),
     },