[FFmpeg-devel] avcodec/raw: add tags for P016

Submitted by Paul B Mahol on Dec. 14, 2018, 12:18 p.m.

Details

Message ID 20181214121807.26758-1-onemda@gmail.com
State New
Headers show

Commit Message

Paul B Mahol Dec. 14, 2018, 12:18 p.m.
Signed-off-by: Paul B Mahol <onemda@gmail.com>
---
 libavcodec/raw.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Michael Niedermayer Dec. 14, 2018, 8:36 p.m.
On Fri, Dec 14, 2018 at 01:18:07PM +0100, Paul B Mahol wrote:
> Signed-off-by: Paul B Mahol <onemda@gmail.com>
> ---
>  libavcodec/raw.c | 2 ++
>  1 file changed, 2 insertions(+)

this seems to break fate

make: *** [fate-filter-pixdesc-p016le] Error 1
make: *** [fate-filter-pixdesc-p016be] Error 1
make: *** [fate-filter-pixfmts-crop] Error 1
make: *** [fate-filter-pixfmts-hflip] Error 1
make: *** [fate-filter-pixfmts-field] Error 1
make: *** [fate-filter-pixfmts-il] Error 1
make: *** [fate-filter-pixfmts-null] Error 1
make: *** [fate-filter-pixfmts-copy] Error 1
make: *** [fate-filter-pixfmts-scale] Error 1
make: *** [fate-filter-pixfmts-transpose] Error 1
make: *** [fate-filter-pixfmts-vflip] Error 1


[...]
Paul B Mahol Dec. 14, 2018, 8:50 p.m.
On 12/14/18, Michael Niedermayer <michael@niedermayer.cc> wrote:
> On Fri, Dec 14, 2018 at 01:18:07PM +0100, Paul B Mahol wrote:
>> Signed-off-by: Paul B Mahol <onemda@gmail.com>
>> ---
>>  libavcodec/raw.c | 2 ++
>>  1 file changed, 2 insertions(+)
>
> this seems to break fate
>

Yes, I know. Is change OK as is?
The P016 coverage is invalid in those tests.

> make: *** [fate-filter-pixdesc-p016le] Error 1
> make: *** [fate-filter-pixdesc-p016be] Error 1
> make: *** [fate-filter-pixfmts-crop] Error 1
> make: *** [fate-filter-pixfmts-hflip] Error 1
> make: *** [fate-filter-pixfmts-field] Error 1
> make: *** [fate-filter-pixfmts-il] Error 1
> make: *** [fate-filter-pixfmts-null] Error 1
> make: *** [fate-filter-pixfmts-copy] Error 1
> make: *** [fate-filter-pixfmts-scale] Error 1
> make: *** [fate-filter-pixfmts-transpose] Error 1
> make: *** [fate-filter-pixfmts-vflip] Error 1
>
>
> [...]
>
> --
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> Those who are best at talking, realize last or never when they are wrong.
>

Patch hide | download patch | download mbox

diff --git a/libavcodec/raw.c b/libavcodec/raw.c
index b6fb91c1c6..bfb9e8083b 100644
--- a/libavcodec/raw.c
+++ b/libavcodec/raw.c
@@ -72,6 +72,8 @@  const PixelFormatTag ff_raw_pix_fmt_tags[] = {
     { AV_PIX_FMT_GRAY8,   MKTAG('G', 'R', 'E', 'Y') },
     { AV_PIX_FMT_NV12,    MKTAG('N', 'V', '1', '2') },
     { AV_PIX_FMT_NV21,    MKTAG('N', 'V', '2', '1') },
+    { AV_PIX_FMT_P016LE,  MKTAG('P', '0', '1', '6') },
+    { AV_PIX_FMT_P016BE,  MKTAG('6', '1', '0', 'P') },
 
     /* nut */
     { AV_PIX_FMT_RGB555LE, MKTAG('R', 'G', 'B', 15) },