[FFmpeg-devel] avcodec/mips: [loongson] fix failed case: hevc-conformance-AMP_A_Samsung_* in loongson2k

Submitted by gxw on Dec. 18, 2018, 1:15 a.m.

Details

Message ID 1545095710-9697-1-git-send-email-guxiwei-hf@loongson.cn
State New
Headers show

Commit Message

gxw Dec. 18, 2018, 1:15 a.m.
The AV_INPUT_BUFFER_PADDING_SIZE has been increased to 64, but the value is still 32
in function ff_hevc_sao_edge_filter_8_msa. So, Modify the corresponding value to 64.
Fate tests passed.
---
 libavcodec/mips/hevc_lpf_sao_msa.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Shiyou Yin Dec. 18, 2018, 7:31 a.m.
>-----Original Message-----
>From: ffmpeg-devel-bounces@ffmpeg.org [mailto:ffmpeg-devel-bounces@ffmpeg.org] On Behalf Of gxw
>Sent: Tuesday, December 18, 2018 9:15 AM
>To: ffmpeg-devel@ffmpeg.org
>Cc: gxw
>Subject: [FFmpeg-devel] [PATCH] avcodec/mips: [loongson] fix failed case:
>hevc-conformance-AMP_A_Samsung_* in loongson2k
>
>The AV_INPUT_BUFFER_PADDING_SIZE has been increased to 64, but the value is still 32
>in function ff_hevc_sao_edge_filter_8_msa. So, Modify the corresponding value to 64.
>Fate tests passed.
>---
> libavcodec/mips/hevc_lpf_sao_msa.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/libavcodec/mips/hevc_lpf_sao_msa.c b/libavcodec/mips/hevc_lpf_sao_msa.c
>index 5b5537a..bb883d0 100644
>--- a/libavcodec/mips/hevc_lpf_sao_msa.c
>+++ b/libavcodec/mips/hevc_lpf_sao_msa.c
>@@ -2630,7 +2630,7 @@ void ff_hevc_sao_edge_filter_8_msa(uint8_t *dst, uint8_t *src,
>                                    int16_t *sao_offset_val,
>                                    int eo, int width, int height)
> {
>-    ptrdiff_t stride_src = (2 * 64 + 32) / sizeof(uint8_t);
>+    ptrdiff_t stride_src = (2 * 64 + 64) / sizeof(uint8_t);
>
>     switch (eo) {
>     case 0:
>--
>2.1.0
>
You can use AV_INPUT_BUFFER_PADDING_SIZE like ff_hevc_sao_edge_filter_neon_8_wrapper did or directly include avcode.h in hevc_lpf_sao_msa.c.
Shiyou Yin Dec. 18, 2018, 11:07 a.m.
>-----Original Message-----
>From: ffmpeg-devel-bounces@ffmpeg.org [mailto:ffmpeg-devel-bounces@ffmpeg.org] On Behalf Of gxw
>Sent: Tuesday, December 18, 2018 9:15 AM
>To: ffmpeg-devel@ffmpeg.org
>Cc: gxw
>Subject: [FFmpeg-devel] [PATCH] avcodec/mips: [loongson] fix failed case:
>hevc-conformance-AMP_A_Samsung_* in loongson2k
>
>The AV_INPUT_BUFFER_PADDING_SIZE has been increased to 64, but the value is still 32
>in function ff_hevc_sao_edge_filter_8_msa. So, Modify the corresponding value to 64.
>Fate tests passed.
>---
> libavcodec/mips/hevc_lpf_sao_msa.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/libavcodec/mips/hevc_lpf_sao_msa.c b/libavcodec/mips/hevc_lpf_sao_msa.c
>index 5b5537a..bb883d0 100644
>--- a/libavcodec/mips/hevc_lpf_sao_msa.c
>+++ b/libavcodec/mips/hevc_lpf_sao_msa.c
>@@ -2630,7 +2630,7 @@ void ff_hevc_sao_edge_filter_8_msa(uint8_t *dst, uint8_t *src,
>                                    int16_t *sao_offset_val,
>                                    int eo, int width, int height)
> {
>-    ptrdiff_t stride_src = (2 * 64 + 32) / sizeof(uint8_t);
>+    ptrdiff_t stride_src = (2 * 64 + 64) / sizeof(uint8_t);
>
>     switch (eo) {
>     case 0:
>--
>2.1.0

For this bug is a mips general bug, It's better to remove the key word loongson in the patch name.
gxw Dec. 18, 2018, 11:22 a.m.
>>Subject: [FFmpeg-devel] [PATCH] avcodec/mips: [loongson] fix failed case:
>>hevc-conformance-AMP_A_Samsung_* in loongson2k
>>
>>The AV_INPUT_BUFFER_PADDING_SIZE has been increased to 64, but the value is still 32
>>in function ff_hevc_sao_edge_filter_8_msa. So, Modify the corresponding value to 64.
>>Fate tests passed.
>>---
>> libavcodec/mips/hevc_lpf_sao_msa.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>>diff --git a/libavcodec/mips/hevc_lpf_sao_msa.c b/libavcodec/mips/hevc_lpf_sao_msa.c
>>index 5b5537a..bb883d0 100644
>>--- a/libavcodec/mips/hevc_lpf_sao_msa.c
>>+++ b/libavcodec/mips/hevc_lpf_sao_msa.c
>>@@ -2630,7 +2630,7 @@ void ff_hevc_sao_edge_filter_8_msa(uint8_t *dst, uint8_t *src,
>> int16_t *sao_offset_val,
>> int eo, int width, int height)
>> {
>>- ptrdiff_t stride_src = (2 * 64 + 32) / sizeof(uint8_t);
>>+ ptrdiff_t stride_src = (2 * 64 + 64) / sizeof(uint8_t);
>>
>> switch (eo) {
>> case 0:
>>--
>>2.1.0
>
>For this bug is a mips general bug, It's better to remove the key word loongson in the patch name. 

thanks, will update.
Carl Eugen Hoyos Dec. 18, 2018, 6:30 p.m.
2018-12-18 2:15 GMT+01:00, gxw <guxiwei-hf@loongson.cn>:
> The AV_INPUT_BUFFER_PADDING_SIZE has been increased to 64, but the value is
> still 32
> in function ff_hevc_sao_edge_filter_8_msa. So, Modify the corresponding
> value to 64.
> Fate tests passed.
> ---
>  libavcodec/mips/hevc_lpf_sao_msa.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavcodec/mips/hevc_lpf_sao_msa.c
> b/libavcodec/mips/hevc_lpf_sao_msa.c
> index 5b5537a..bb883d0 100644
> --- a/libavcodec/mips/hevc_lpf_sao_msa.c
> +++ b/libavcodec/mips/hevc_lpf_sao_msa.c
> @@ -2630,7 +2630,7 @@ void ff_hevc_sao_edge_filter_8_msa(uint8_t *dst,
> uint8_t *src,
>                                     int16_t *sao_offset_val,
>                                     int eo, int width, int height)
>  {
> -    ptrdiff_t stride_src = (2 * 64 + 32) / sizeof(uint8_t);

> +    ptrdiff_t stride_src = (2 * 64 + 64) / sizeof(uint8_t);

You could also drop the sizeof as FFmpeg requires it to be 1.

Carl Eugen
gxw Dec. 20, 2018, 1:33 a.m.
> 2018-12-18 2:15 GMT+01:00, gxw <guxiwei-hf@loongson.cn>:

> > The AV_INPUT_BUFFER_PADDING_SIZE has been increased to 64, but the value is

> > still 32

> > in function ff_hevc_sao_edge_filter_8_msa. So, Modify the corresponding

> > value to 64.

> > Fate tests passed.

> > ---

> >  libavcodec/mips/hevc_lpf_sao_msa.c | 2 +-

> >  1 file changed, 1 insertion(+), 1 deletion(-)

> >

> > diff --git a/libavcodec/mips/hevc_lpf_sao_msa.c

> > b/libavcodec/mips/hevc_lpf_sao_msa.c

> > index 5b5537a..bb883d0 100644

> > --- a/libavcodec/mips/hevc_lpf_sao_msa.c

> > +++ b/libavcodec/mips/hevc_lpf_sao_msa.c

> > @@ -2630,7 +2630,7 @@ void ff_hevc_sao_edge_filter_8_msa(uint8_t *dst,

> > uint8_t *src,

> >                                     int16_t *sao_offset_val,

> >                                     int eo, int width, int height)

> >  {

> > -    ptrdiff_t stride_src = (2 * 64 + 32) / sizeof(uint8_t);

> 

> > +    ptrdiff_t stride_src = (2 * 64 + 64) / sizeof(uint8_t);

> 

> You could also drop the sizeof as FFmpeg requires it to be 1.

> 

> Carl Eugen

> _______________________________________________

> ffmpeg-devel mailing list

> ffmpeg-devel@ffmpeg.org

> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel


This is not a bug, maybe I don't need to drop it in this patch.

北京市海淀区中关村环保科技示范园龙芯产业园2号楼 100095电话: +86 (10) 62546668传真: +86 (10) 62600826www.loongson.cn本邮件及其附件含有龙芯中科技术有限公司的商业秘密信息,仅限于发送给上面地址中列出的个人或群组。禁止任何其他人以任何形式使用(包括但不限于全部或部 分地泄露、复制或散发)本邮件及其附件中的信息。如果您错收本邮件,请您立即电话或邮件通知发件人并删除本邮件。 

This email and its attachments contain confidential information from Loongson
Technology Corporation Limited, which is intended only for the person or entity
whose address is listed above. Any use of the information contained herein in
any way (including, but not limited to, total or partial disclosure,
reproduction or dissemination) by persons other than the intended recipient(s)
is prohibited. If you receive this email in error, please notify the sender by
phone or email immediately and delete it.

Patch hide | download patch | download mbox

diff --git a/libavcodec/mips/hevc_lpf_sao_msa.c b/libavcodec/mips/hevc_lpf_sao_msa.c
index 5b5537a..bb883d0 100644
--- a/libavcodec/mips/hevc_lpf_sao_msa.c
+++ b/libavcodec/mips/hevc_lpf_sao_msa.c
@@ -2630,7 +2630,7 @@  void ff_hevc_sao_edge_filter_8_msa(uint8_t *dst, uint8_t *src,
                                    int16_t *sao_offset_val,
                                    int eo, int width, int height)
 {
-    ptrdiff_t stride_src = (2 * 64 + 32) / sizeof(uint8_t);
+    ptrdiff_t stride_src = (2 * 64 + 64) / sizeof(uint8_t);
 
     switch (eo) {
     case 0: