diff mbox

[FFmpeg-devel,PATCHv2] fate: add dst decoder test

Message ID 5c53edd785acc22a6c3ae95694aecf4a7e42edfc.1545518275.git.pross@xvid.org
State Accepted
Headers show

Commit Message

Peter Ross Dec. 22, 2018, 10:41 p.m. UTC
the dst->dsd decoder is bit-exact, but uses ff_dsd2pcm_translate to
output pcm.
---
thanks for spotting this michael. totally forgotten about the embedded
pcm converter.

 tests/fate/audio.mak   |  5 +++++
 tests/ref/fate/dsf-dst | 16 ++++++++++++++++
 2 files changed, 21 insertions(+)
 create mode 100644 tests/ref/fate/dsf-dst

Comments

Michael Niedermayer Dec. 23, 2018, 12:20 p.m. UTC | #1
On Sun, Dec 23, 2018 at 09:41:48AM +1100, Peter Ross wrote:
> the dst->dsd decoder is bit-exact, but uses ff_dsd2pcm_translate to
> output pcm.
> ---
> thanks for spotting this michael. totally forgotten about the embedded
> pcm converter.
> 
>  tests/fate/audio.mak   |  5 +++++
>  tests/ref/fate/dsf-dst | 16 ++++++++++++++++
>  2 files changed, 21 insertions(+)
>  create mode 100644 tests/ref/fate/dsf-dst

fails on mips
TEST    dsf-dst
stddev:32212.26 PSNR:  6.17 MAXDIFF:44369 bytes:   188160/   188160
MAXDIFF: |44369 - 0| >= 1
Test dsf-dst failed. Look at tests/data/fate/dsf-dst.err for details.
make: *** [fate-dsf-dst] Error 1

[dst @ 0x1f9a350] Warning: not compiled with thread support, using thread emulation
Input #0, iff, from 'fate-suite//dst/dst-64fs44-2ch.dff':
  Duration: 00:00:00.13, bitrate: 2853 kb/s
    Stream #0:0: Audio: dst (DST  / 0x20545344), 352800 Hz, stereo, flt
[dst @ 0x1fa17b0] Warning: not compiled with thread support, using thread emulation
Stream mapping:
  Stream #0:0 -> #0:0 (dst (native) -> pcm_s16le (native))
[pcm_s16le @ 0x1fcbaf0] Warning: not compiled with thread support, using thread emulation
Output #0, s16le, to 'pipe:':
  Metadata:
    encoder         : Lavf58.25.100
    Stream #0:0: Audio: pcm_s16le, 352800 Hz, stereo, s16, 11289 kb/s
    Metadata:
      encoder         : Lavc58.42.104 pcm_s16le
size=     184kB time=00:00:00.13 bitrate=11289.6kbits/s speed= 1.2x    
video:0kB audio:184kB subtitle:0kB other streams:0kB global headers:0kB muxing overhead: 0.000000%
make: *** [fate-dsf-dst] Error 1

[...]
Michael Niedermayer Jan. 14, 2019, 12:15 a.m. UTC | #2
On Sun, Dec 23, 2018 at 01:20:51PM +0100, Michael Niedermayer wrote:
> On Sun, Dec 23, 2018 at 09:41:48AM +1100, Peter Ross wrote:
> > the dst->dsd decoder is bit-exact, but uses ff_dsd2pcm_translate to
> > output pcm.
> > ---
> > thanks for spotting this michael. totally forgotten about the embedded
> > pcm converter.
> > 
> >  tests/fate/audio.mak   |  5 +++++
> >  tests/ref/fate/dsf-dst | 16 ++++++++++++++++
> >  2 files changed, 21 insertions(+)
> >  create mode 100644 tests/ref/fate/dsf-dst
> 
> fails on mips
> TEST    dsf-dst

this passes now with master

thx
[...]
diff mbox

Patch

diff --git a/tests/fate/audio.mak b/tests/fate/audio.mak
index 4fab472f90..c41958ea2d 100644
--- a/tests/fate/audio.mak
+++ b/tests/fate/audio.mak
@@ -28,6 +28,11 @@  FATE_SAMPLES_AUDIO-$(call DEMDEC, DSS, DSS_SP) += fate-dss-lp fate-dss-sp
 fate-dss-lp: CMD = framecrc -i $(TARGET_SAMPLES)/dss/lp.dss -frames 30
 fate-dss-sp: CMD = framecrc -i $(TARGET_SAMPLES)/dss/sp.dss -frames 30
 
+FATE_SAMPLES_AUDIO-$(call DEMDEC, DSF, DST) += fate-dsf-dst
+fate-dsf-dst: CMD = pcm -i $(TARGET_SAMPLES)/dst/dst-64fs44-2ch.dff
+fate-dsf-dst: CMP = oneoff
+fate-dsf-dst: REF = $(SAMPLES)/dst/dst-64fs44-2ch.pcm
+
 FATE_SAMPLES_AUDIO-$(call DEMDEC, AVI, IMC) += fate-imc
 fate-imc: CMD = pcm -i $(TARGET_SAMPLES)/imc/imc.avi
 fate-imc: CMP = oneoff
diff --git a/tests/ref/fate/dsf-dst b/tests/ref/fate/dsf-dst
new file mode 100644
index 0000000000..a2f2921637
--- /dev/null
+++ b/tests/ref/fate/dsf-dst
@@ -0,0 +1,16 @@ 
+#tb 0: 1/352800
+#media_type 0: audio
+#codec_id 0: pcm_s16le
+#sample_rate 0: 352800
+#channel_layout 0: 3
+#channel_layout_name 0: stereo
+0,          0,          0,     4704,    18816, 0x16bbebad
+0,       4704,       4704,     4704,    18816, 0x025d9312
+0,       9408,       9408,     4704,    18816, 0xa8a84a1d
+0,      14112,      14112,     4704,    18816, 0x44a24932
+0,      18816,      18816,     4704,    18816, 0xb60580ae
+0,      23520,      23520,     4704,    18816, 0xa23751ff
+0,      28224,      28224,     4704,    18816, 0xcaee4a16
+0,      32928,      32928,     4704,    18816, 0xc19adb0e
+0,      37632,      37632,     4704,    18816, 0xb7adec72
+0,      42336,      42336,     4704,    18816, 0x6a7f3268