From patchwork Mon Dec 31 02:46:57 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Niedermayer X-Patchwork-Id: 11596 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id 2193444CB06 for ; Mon, 31 Dec 2018 04:47:01 +0200 (EET) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id CA4E968A6E2; Mon, 31 Dec 2018 04:46:57 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net [217.70.183.198]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id D5D5B68A552 for ; Mon, 31 Dec 2018 04:46:51 +0200 (EET) X-Originating-IP: 213.47.41.20 Received: from localhost (213-47-41-20.cable.dynamic.surfer.at [213.47.41.20]) (Authenticated sender: michael@niedermayer.cc) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 8A216C0004 for ; Mon, 31 Dec 2018 02:46:58 +0000 (UTC) Date: Mon, 31 Dec 2018 03:46:57 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20181231024657.GP3501@michaelspb> References: <20181230205723.2596-1-alex@mogurenko.com> MIME-Version: 1.0 In-Reply-To: <20181230205723.2596-1-alex@mogurenko.com> User-Agent: Mutt/1.5.24 (2015-08-30) Subject: Re: [FFmpeg-devel] [PATCH] avcodec/prores_ks reduce twice fdct calls X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" On Sun, Dec 30, 2018 at 10:57:23PM +0200, Alex Mogurenko wrote: > fdct done twice for each block. first time during quant calculation, second during slice encoding. so if we pre-save dct coefficients no need to do fdct second time. > disadvantages: requires more memory > advantages: improves performance ~4-5% > --- > libavcodec/proresenc_kostya.c | 74 ++++++++++++++++++++++++----------- > 1 file changed, 52 insertions(+), 22 deletions(-) breaks fate TEST vsynth1-prores_ks Test vsynth1-prores_ks failed. Look at tests/data/fate/vsynth1-prores_ks.err for details. make: *** [fate-vsynth1-prores_ks] Error 1 [...] --- ./tests/ref/vsynth/vsynth1-prores_ks 2018-12-28 17:54:41.361383177 +0100 +++ tests/data/fate/vsynth1-prores_ks 2018-12-31 03:45:17.207673799 +0100 @@ -1,4 +1,4 @@ -fe41a284da97ea5ec8866ca9a55b84da *tests/data/fate/vsynth1-prores_ks.mov -3858911 tests/data/fate/vsynth1-prores_ks.mov -100eb002413fe7a632d440dfbdf7e3ff *tests/data/fate/vsynth1-prores_ks.out.rawvideo -stddev: 3.17 PSNR: 38.09 MAXDIFF: 39 bytes: 7603200/ 7603200 +ba6294d95b96f032b90f804f112ab98a *tests/data/fate/vsynth1-prores_ks.mov +3867422 tests/data/fate/vsynth1-prores_ks.mov +e85510eadb1ff115e85c480d8e1011a4 *tests/data/fate/vsynth1-prores_ks.out.rawvideo +stddev: 19.38 PSNR: 22.38 MAXDIFF: 210 bytes: 7603200/ 7603200