[FFmpeg-devel,1/4] vp3: ref_frame/ref_frames are only required when HAVE_THREADS=1

Submitted by Peter Ross on Jan. 6, 2019, 7:42 a.m.

Details

Message ID 6ffa03404c7f1b8dff17645f9345c9c959cf017e.1546760371.git.pross@xvid.org
State Accepted
Commit d52a1be4e339f977485941ebf3bd26da2a40f72f
Headers show

Commit Message

Peter Ross Jan. 6, 2019, 7:42 a.m.
squelch another warning
---
 libavcodec/vp3.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Peter Ross Jan. 13, 2019, 7:45 p.m.
On Sun, Jan 06, 2019 at 06:42:50PM +1100, Peter Ross wrote:
> squelch another warning
> ---
>  libavcodec/vp3.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

If no one objects, I will apply this warnings-fix patch in a day or so.

-- Peter
(A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B)
Carl Eugen Hoyos Jan. 13, 2019, 7:51 p.m.
2019-01-06 8:42 GMT+01:00, Peter Ross <pross@xvid.org>:
> squelch another warning
> ---
>  libavcodec/vp3.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavcodec/vp3.c b/libavcodec/vp3.c
> index 9df2fda49d..a5d8c2ed0b 100644
> --- a/libavcodec/vp3.c
> +++ b/libavcodec/vp3.c
> @@ -1961,6 +1961,7 @@ fail:
>      return ret;
>  }
>
> +#if HAVE_THREADS
>  static int ref_frame(Vp3DecodeContext *s, ThreadFrame *dst, ThreadFrame
> *src)
>  {
>      ff_thread_release_buffer(s->avctx, dst);
> @@ -1979,7 +1980,6 @@ static int ref_frames(Vp3DecodeContext *dst,
> Vp3DecodeContext *src)
>      return 0;
>  }
>
> -#if HAVE_THREADS
>  static int vp3_update_thread_context(AVCodecContext *dst, const
> AVCodecContext *src)
>  {
>      Vp3DecodeContext *s = dst->priv_data, *s1 = src->priv_data;

No review necessary if tested.

Carl Eugen

Patch hide | download patch | download mbox

diff --git a/libavcodec/vp3.c b/libavcodec/vp3.c
index 9df2fda49d..a5d8c2ed0b 100644
--- a/libavcodec/vp3.c
+++ b/libavcodec/vp3.c
@@ -1961,6 +1961,7 @@  fail:
     return ret;
 }
 
+#if HAVE_THREADS
 static int ref_frame(Vp3DecodeContext *s, ThreadFrame *dst, ThreadFrame *src)
 {
     ff_thread_release_buffer(s->avctx, dst);
@@ -1979,7 +1980,6 @@  static int ref_frames(Vp3DecodeContext *dst, Vp3DecodeContext *src)
     return 0;
 }
 
-#if HAVE_THREADS
 static int vp3_update_thread_context(AVCodecContext *dst, const AVCodecContext *src)
 {
     Vp3DecodeContext *s = dst->priv_data, *s1 = src->priv_data;