[FFmpeg-devel] api-h264-slice-test: fix arguments and help

Submitted by Rafaël Carré on Jan. 10, 2019, 11:12 a.m.

Details

Message ID 6cb2d748-a7d0-aee9-5ba3-44756c6802a7@videolan.org
State Accepted
Headers show

Commit Message

Rafaël Carré Jan. 10, 2019, 11:12 a.m.
This program only takes 2 arguments
Remove comment that was never right
---
 tests/api/api-h264-slice-test.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

Comments

Rafaël Carré Jan. 10, 2019, 11:14 a.m.
On 1/10/19 12:12 PM, Rafaël Carré wrote:

> -        fprintf(stderr, "Usage: %s <threads> <input file> <output
> file>\n", argv[0]);

I can't use git send-email with google so I had to copy paste the patch
into thunderbird.

The 2 lines above probably needs concatenating to apply the patch

> +    if (argc < 3) {
> +        fprintf(stderr, "Usage: %s <threads> <input file>\n", argv[0]);
>          return -1;
>      }
>
Moritz Barsnick Jan. 10, 2019, 4:19 p.m.
Rafaël Carré wrote:

> I can't use git send-email with google so I had to copy paste the patch
> into thunderbird.

You can use "git format-patch" and attach the created patch file in Thunderbird.

$ git format-patch HEAD^
or
$ git format-patch 556d7d9e3b09157555310466a47e25a9ebfd8f4e^..556d7d9e3b09157555310466a47e25a9ebfd8f4e

https://www.ffmpeg.org/developer.html#toc-Submitting-patches-1

Moritz

Patch hide | download patch | download mbox

diff --git a/tests/api/api-h264-slice-test.c
b/tests/api/api-h264-slice-test.c
index b893737bca..dee93b8349 100644
--- a/tests/api/api-h264-slice-test.c
+++ b/tests/api/api-h264-slice-test.c
@@ -22,8 +22,6 @@ 

 #define MAX_SLICES 8

-// ./fate 2 ./crew_cif out.y4m
-
 #include "config.h"

 #include <stdbool.h>
@@ -121,8 +119,8 @@  int main(int argc, char **argv)
     int nals = 0, ret = 0;
     char *p;

-    if (argc < 4) {
-        fprintf(stderr, "Usage: %s <threads> <input file> <output
file>\n", argv[0]);
+    if (argc < 3) {
+        fprintf(stderr, "Usage: %s <threads> <input file>\n", argv[0]);
         return -1;
     }