From patchwork Thu Jan 10 20:14:24 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tan X-Patchwork-Id: 11694 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id 5DB5644CC2F for ; Thu, 10 Jan 2019 22:14:34 +0200 (EET) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7A51C68A630; Thu, 10 Jan 2019 22:14:22 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from NAM01-BN3-obe.outbound.protection.outlook.com (mail-eopbgr740107.outbound.protection.outlook.com [40.107.74.107]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 415F1689741 for ; Thu, 10 Jan 2019 22:14:15 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HSkz8ebyIH0RwUZ/A/VIV3sKgt4mROF9OXtUENkuCVk=; b=XhkU5kJgdqsDw3En/BS9PjaiGxXOz15uQfj3Z4vn8M1HyhDVd3gncFlb9thjqPse/QXU6ZssCZFUGCXcV3o/qXrofFIr6nqDd0D/yVHGDoOG0cgay1CIfTwRa2TrHc+yPWgOENwOOd2pFTMpUpsQE5o3jCAuptmErAfzm9n/VJE= Received: from MWHPR21MB0750.namprd21.prod.outlook.com (10.173.51.12) by MWHPR21MB0703.namprd21.prod.outlook.com (10.175.142.13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1537.5; Thu, 10 Jan 2019 20:14:24 +0000 Received: from MWHPR21MB0750.namprd21.prod.outlook.com ([fe80::30fc:8231:c40a:13b4]) by MWHPR21MB0750.namprd21.prod.outlook.com ([fe80::30fc:8231:c40a:13b4%6]) with mapi id 15.20.1537.013; Thu, 10 Jan 2019 20:14:24 +0000 From: Tom Tan To: "ffmpeg-devel@ffmpeg.org" Thread-Topic: [PATCH] Mark .rodata section as read only in COFF object file Thread-Index: AdSpIN2WMVnOomCgQrOkMV5HHi9Q4A== Date: Thu, 10 Jan 2019 20:14:24 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: yes X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=True; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Owner=totan@microsoft.com; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2019-01-10T20:14:22.7710456Z; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=General; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Application=Microsoft Azure Information Protection; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Extended_MSFT_Method=Automatic; Sensitivity=General x-originating-ip: [2001:4898:80e8:9:aa06:7065:d736:7f6] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; MWHPR21MB0703; 6:dWKxJHRoBLoZqHVrwGm+VnjGgqKKKSEu310e3YkQScg+DG9GdTQ793TTsacH/E4UVwWl0zPBvxn5g9Pvm/IpfPMmTdOPdcw7QvLOcVoyXvBWzruRuemq8MDCAUyO2llF369v6B7Yrvhyhtf3wFtmaRLeZJGBkbgc6wpaMpO7Kk1x2CZmPRymk2S7VkehjgRHR1b/tAt4Fz9aQRQS8Phi6NZdNsp6VSyumSsc1z75U4hz4LgTgZGItU1kLv7E2aDtpNDTMFYlf3d3QRKK64G7kPX3kUhIMeQBqvR/4a7RdA5oRPqe6amySySo+PD9fTp8xMgYpyCp2kdjETgn41qzjvVP3Hs4+wwkeuHVqqaaDHHX8BOxsZBWlzGIXeZHht+U+DGqarAbGZMB6AvIrZ1AcVdzEpkCGqJPzKwPjLKGi1QQvAisOa9zlG2IDAOn2/Rq33lqKBTRLzrw1Y/tH76sgg==; 5:jEo0ZqBVIg/S+oBvYV1XydM4PcLN+aMZSFpIEVCJpU92lG+4nmjI9K/Q77+ucidoMMxppTRwpebZh9BoUaKBqIw7xz8vbS1Y9uin1nxbKDvj0HbmhjdRCs09KEACb8FHtaQhp/anr/3F3B6oWyIRGTuvO0l3/y1hZJAE8uHLXJthSGyPR7ro8FOVbkD+9+ZUZfe7wve5dNiTmYoRJ+RU4Q==; 7:sF5UQZ6OcPsq/UGjo48Cw3zx+c+6hBxkyOS0NWWkQ8FtltZA9XqlecAKKNJBiBZjN7Tx0HwZQQ/nd7vb9+yIHQg7O27J6tfmefD7zJX6GhTdZPT/AfeGSgTlqeiJpwC8WP5udT+0ijLpa8/wokKwbw== x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: 34e1db32-9ac4-4be9-9359-08d67738370a x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600109)(711020)(4618075)(2017052603328)(49563074)(7193020); SRVR:MWHPR21MB0703; x-ms-traffictypediagnostic: MWHPR21MB0703: x-ms-exchange-purlcount: -3 x-microsoft-antispam-prvs: x-forefront-prvs: 0913EA1D60 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(376002)(136003)(346002)(366004)(396003)(39860400002)(199004)(189003)(53936002)(99286004)(72206003)(46003)(6346003)(14454004)(6916009)(74316002)(71190400001)(71200400001)(9686003)(86612001)(33656002)(5660300001)(478600001)(2906002)(476003)(25786009)(2501003)(99936001)(186003)(86362001)(10290500003)(22452003)(316002)(8990500004)(8936002)(2351001)(97736004)(10090500001)(6116002)(102836004)(68736007)(256004)(105586002)(7696005)(6506007)(305945005)(106356001)(486006)(7736002)(6436002)(8676002)(55016002)(81166006)(5640700003)(81156014)(142923001); DIR:OUT; SFP:1102; SCL:1; SRVR:MWHPR21MB0703; H:MWHPR21MB0750.namprd21.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: microsoft.com does not designate permitted sender hosts) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Tom.Tan@microsoft.com; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: FYMT/UbQn5YfJIvyNB6+QykIWIrlYbrt/vCNrDb7ty5/so05MKl9XGw/g5QEJLPTPFeypiJr50ysLY2SPA7ruUmsPLDPH1prQ3vKJk1hdaIwKBN8PQPZh0Rqcy5opHXbLUv3+znL/E+N60yRvCQTlOqWKsRysbq6ABLEOLxQmC+C0qMG1DxxvEha2AYHj0wHo29qnyLMw9ji2jhlg9wEu1YrR6AqTeaHowE07PY+wzc4HnED0YcDCP4YxVdKbdIp7NcLuU92WB1HCZjF2D4SV6bPVe/rLu4oRI5ziOfiKm1OJ4Ctq62FF8qe4sGt9bae spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: 34e1db32-9ac4-4be9-9359-08d67738370a X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Jan 2019 20:14:24.2856 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR21MB0703 Subject: [FFmpeg-devel] [PATCH] Mark .rodata section as read only in COFF object file X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" .rodata directive from GAS assembly produces .rodata as read/write for COFF object file by default (object file format for Windows), but read only for ELF. This change marks it as read only explicitly for COFF. The issue happens when building Chromium for Windows ARM64, with FFmpeg. --- libavutil/aarch64/asm.S | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavutil/aarch64/asm.S b/libavutil/aarch64/asm.S index fd32bf784e..abc2f69f43 100644 --- a/libavutil/aarch64/asm.S +++ b/libavutil/aarch64/asm.S @@ -63,6 +63,8 @@ ELF .size \name, . - \name .else .section .rodata .endif +#elif defined(_WIN32) + .section .rodata, "r" #elif !defined(__MACH__) .section .rodata #else