[FFmpeg-devel] fix sidx size being doubled in offset. fixes an issue where if the video size was very specific, ffmpeg would hang from not filling the sidx_pts for all streams, due to not reading the last sidx lump. for #7572

Submitted by no pls on Jan. 27, 2019, 3:51 p.m.

Details

Message ID 20190127155112.20529-1-agrecascino123@gmail.com
State New
Headers show

Commit Message

no pls Jan. 27, 2019, 3:51 p.m.
From: mptcultist <agrecascino123@gmail.com>

---
 libavformat/mov.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Moritz Barsnick Jan. 31, 2019, 9:16 a.m.
On Sun, Jan 27, 2019 at 10:51:12 -0500, agrecascino123@gmail.com wrote:

> Subject: [FFmpeg-devel] [PATCH] fix sidx size being doubled in offset. fixes an issue where if the video size was very specific, ffmpeg would hang from not filling the
>         sidx_pts for all streams, due to not reading the last sidx lump. for #7572

Please split your commit message into a leading line, an empty line,
and then the explanatory text.

And the leading line should be something like (note the prefix):
> avformat/mov: fix sidx size being doubled in offset

I'm not sure your commit message is easy to be understand, but I'll let
others worry about that.

Thanks,
Moritz
Moritz Barsnick Jan. 31, 2019, 9:16 a.m.
On Thu, Jan 31, 2019 at 10:16:00 +0100, Moritz Barsnick wrote:
> Please split your commit message into a leading line, an empty line,
> and then the explanatory text.

Forget this, I didn't see V3 of your patch.

D'uh,
Moritz
no pls Jan. 31, 2019, 1:45 p.m.
sorry i sent my first two emails about 4 days ago and after waiting a few days i just decided to subscribe and resubmit my patches.
i think they just got through now.

Sent from my iPhone

> On Jan 31, 2019, at 4:16 AM, Moritz Barsnick <barsnick@gmx.net> wrote:
> 
>> On Thu, Jan 31, 2019 at 10:16:00 +0100, Moritz Barsnick wrote:
>> Please split your commit message into a leading line, an empty line,
>> and then the explanatory text.
> 
> Forget this, I didn't see V3 of your patch.
> 
> D'uh,
> Moritz
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Patch hide | download patch | download mbox

diff --git a/libavformat/mov.c b/libavformat/mov.c
index 9b9739f788..c222582886 100644
--- a/libavformat/mov.c
+++ b/libavformat/mov.c
@@ -4933,7 +4933,7 @@  static int mov_read_trun(MOVContext *c, AVIOContext *pb, MOVAtom atom)
 
 static int mov_read_sidx(MOVContext *c, AVIOContext *pb, MOVAtom atom)
 {
-    int64_t offset = avio_tell(pb) + atom.size, pts, timestamp;
+    int64_t offset = avio_tell(pb), pts, timestamp;
     uint8_t version;
     unsigned i, j, track_id, item_count;
     AVStream *st = NULL;