From patchwork Sun Feb 10 00:01:42 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Carl Eugen Hoyos X-Patchwork-Id: 12015 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id 46685446F8C for ; Sun, 10 Feb 2019 02:01:51 +0200 (EET) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 21C0A68A9DF; Sun, 10 Feb 2019 02:01:51 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-it1-f179.google.com (mail-it1-f179.google.com [209.85.166.179]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 30D2068A9B3 for ; Sun, 10 Feb 2019 02:01:44 +0200 (EET) Received: by mail-it1-f179.google.com with SMTP id i145so17972535ita.4 for ; Sat, 09 Feb 2019 16:01:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=TtdIdMc69o6L3QpmazjaE3oHPkavtfYLDQmKo5MUQUc=; b=FSeM8UHmJYrVr0sXIYp0VM1kphPzqD89+d1bwjS++1Z3vhk+OUoHbAqCQ5on3R7icG qPfLwk18kwSAj8Lm94FrcftijdRUY4fWjGNqKhGL50H92ss9BkF1dZq65WWFZrQeOR+m P39nJMOpdayQiU6dANfEvkLx+kGnpcqQWbVhgtT/8qj/JvNH0ZxRn/9D9qkJy/g0iq0Z uH9IearyzNrewrYj0q0FxQ57oP9lIyu0KUo6vQxiwjCKMhjfucSvqy9Tqn4gJCpw5yaR 2Re7IRm0DkrBmmuohS7hTJ6nEMM3SORC3yRNR43QonukKQlUKaaG1Wx/i447zPnTTaUA 4G9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=TtdIdMc69o6L3QpmazjaE3oHPkavtfYLDQmKo5MUQUc=; b=pC2LsvGDE+JOpVdvwwEXWXGMZVuyR1kPS3pivkbpxvGewvkGC1loH160PRtN4b48F/ ysqJHHmk5Bo8g9Cca93fwZ8k03CXaSvY9oR+5xv44NWbk+Ri4U19yk0twDMlbYDXegCG tGS/F0z8RhtpSyXQbSMoLcYHk0pelnSDWMYae8EK+7mnaJVpxUnHh1mYfxCm0MyZI9KC Idv/iEE8nzGiWiiuO2L/Aos1YWhvs+XAsQOfSN8DO0mkXMK2DJYDon/NHY5s9s59iOQt 5A+weWugP254IBLsuMwai9/1zcj4jYoDDdJ1RqB7zxCh1ybWJVZh2ZIv2wQ/7k2nvJcQ n39A== X-Gm-Message-State: AHQUAub/FgCO5/v1UTUAWPZOpH3umvOetwU6/pYKzfFyD3PW31+xWn/C 5nBzcf8xuidNt0MXgBDTZk8nlu0IOt1xVnwF8Jyv1w== X-Google-Smtp-Source: AHgI3IZPeUNoKNlzoTfCxrurLvYc7cvMiNc2zwgjt7URY4L/6pq59eGiDqdXlCGipYhmuNxVsc7mK3JL6SmbYqm4B5s= X-Received: by 2002:a24:6f51:: with SMTP id x78mr2280572itb.121.1549756902606; Sat, 09 Feb 2019 16:01:42 -0800 (PST) MIME-Version: 1.0 Received: by 2002:a02:c890:0:0:0:0:0 with HTTP; Sat, 9 Feb 2019 16:01:42 -0800 (PST) From: Carl Eugen Hoyos Date: Sun, 10 Feb 2019 01:01:42 +0100 Message-ID: To: FFmpeg development discussions and patches Subject: [FFmpeg-devel] [PATCH]lavf/http: Print metadata updates with loglevel verbose X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Hi! Attached patch simplifies the debugging of icy metadata, required to answer the tickets of one regular reporter. Please comment, Carl Eugen From 170f6bcf79b4486adf1121f7e5f01b6617fd1e79 Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Sun, 10 Feb 2019 00:59:30 +0100 Subject: [PATCH] lavf/http: Print metadata updates with -loglevel verbose. Simplifies metadata debugging. --- libavformat/http.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/libavformat/http.c b/libavformat/http.c index a0a0636..ee3ac23 100644 --- a/libavformat/http.c +++ b/libavformat/http.c @@ -1504,12 +1504,13 @@ static int http_read_stream_all(URLContext *h, uint8_t *buf, int size) return pos; } -static void update_metadata(HTTPContext *s, char *data) +static void update_metadata(URLContext *h, char *data) { char *key; char *val; char *end; char *next = data; + HTTPContext *s = h->priv_data; while (*next) { key = next; @@ -1525,6 +1526,7 @@ static void update_metadata(HTTPContext *s, char *data) val += 2; av_dict_set(&s->metadata, key, val, 0); + av_log(h, AV_LOG_VERBOSE, "Metadata update for %s: %s\n", key, val); next = end + 2; } @@ -1559,7 +1561,7 @@ static int store_icy(URLContext *h, int size) data[len + 1] = 0; if ((ret = av_opt_set(s, "icy_metadata_packet", data, 0)) < 0) return ret; - update_metadata(s, data); + update_metadata(h, data); } s->icy_data_read = 0; remaining = s->icy_metaint; -- 1.7.10.4