[FFmpeg-devel,4/4] lavc/libaribb24: use integer math to calculate font scaling

Submitted by Jan Ekström on Feb. 11, 2019, 1:06 a.m.

Details

Message ID 20190211010654.24762-4-jeebjp@gmail.com
State Accepted
Commit 466cb4ed56a12d0081ed7005a8e8663d1b8806ca
Headers show

Commit Message

Jan Ekström Feb. 11, 2019, 1:06 a.m.
---
 libavcodec/libaribb24.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

Comments

Michael Niedermayer Feb. 12, 2019, 12:13 a.m.
On Mon, Feb 11, 2019 at 03:06:54AM +0200, Jan Ekström wrote:
> ---
>  libavcodec/libaribb24.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)

LGTM

thx

[...]

Patch hide | download patch | download mbox

diff --git a/libavcodec/libaribb24.c b/libavcodec/libaribb24.c
index 28f20ca767..3a59938451 100644
--- a/libavcodec/libaribb24.c
+++ b/libavcodec/libaribb24.c
@@ -249,11 +249,11 @@  static int libaribb24_handle_regions(AVCodecContext *avctx, AVSubtitle *sub)
         // font size
         if (region->i_fontwidth  != profile_font_size ||
             region->i_fontheight != profile_font_size) {
-            av_bprintf(&buf, "{\\fscx%d\\fscy%d}",
-                       (int)round(((double)region->i_fontwidth /
-                                   (double)profile_font_size) * 100),
-                       (int)round(((double)region->i_fontheight /
-                                   (double)profile_font_size) * 100));
+            av_bprintf(&buf, "{\\fscx%"PRId64"\\fscy%"PRId64"}",
+                       av_rescale(region->i_fontwidth, 100,
+                                  profile_font_size),
+                       av_rescale(region->i_fontheight, 100,
+                                  profile_font_size));
         }
 
         // TODO: positioning