From patchwork Sat Feb 16 19:31:13 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Carl Eugen Hoyos X-Patchwork-Id: 12085 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id 33B24449709 for ; Sat, 16 Feb 2019 21:31:23 +0200 (EET) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1192968A773; Sat, 16 Feb 2019 21:31:23 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-it1-f182.google.com (mail-it1-f182.google.com [209.85.166.182]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id B5BD768A755 for ; Sat, 16 Feb 2019 21:31:15 +0200 (EET) Received: by mail-it1-f182.google.com with SMTP id l15so18995635iti.4 for ; Sat, 16 Feb 2019 11:31:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=4316RsyOrGc/ps+qM4cKXJF0Zq4W2QxYjI2pYRAUwK8=; b=K3uAYBqg+MZbymfrvJ7t6bWuLaWSO4GdNjQIWAsbvBxyxRnf74mfE3TWAouKRLwYQt FoJKzO050eZN8VzHbgCUzjb72pQmFVIuHVbOFEOYTDp+Shkq/lxRpz6cg/iWLoBFKUSI K3s6dRy1J+hR43oBEtooyGs1+xd34TxG8sIErpxh7vWbe17Kyl0RU10kwpcy6/2ZPcgm +lwIafE187VTl1MmLyzQ0Qjufdb8h4AuCtMUpenfO0Mt87xPCYBy2mdex9pi/CJqFbj/ 2i5gNJkpSPSvLuGHejemODCP2Vix2rpK7mXx67G8yChFAOG5M22AbKPh8I7BoFLC7rwy gK+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=4316RsyOrGc/ps+qM4cKXJF0Zq4W2QxYjI2pYRAUwK8=; b=uWR0dUeIf+RpcIN0JrpUqqyZIKpO6DHJRU8jmPZXmlB3Pklpc1iTsQBHhQKi34dBcM SFb+r5JHeOq/mV11py9tZPXIOoQzVhWZI1vJMKUiHwugQ8Bc/flUtS00X6kESQsb3efW kwLNgfbCkh/rlT62eAAxiCMl2FgcwKcp2Nhrh6qNJB94dmcJSMAJuEA+0I9NTlqVvfm4 NIuQVpgJuEeqRg1uAMdPZxFy4z+FrqP9DjjQc2jik/5v+UJNdj3uBaT6hfyuvMk9cpet eJTnWmQvDVjr6MEn50hfbEHkntWoN4eTT3as9Jei7t25Mr32dRW1niKq474mVSmUII/L 2b7w== X-Gm-Message-State: AHQUAuY2V1r3xSC+Hp0ACEaOgN+jYrhgzmo6YzU7aE2Bh7U60r06mQvK CsFK1/tzgvoAN3jzRjv3ucQcQKGi4iqP0muwUzBedA== X-Google-Smtp-Source: AHgI3IakQDpxAmG2/VAOH0HtA1p8lRjML0fPKT3URLTVdgfSKndOCWP41gVuELF7BcUpnqg8LF8VbCHKTqfLkePkQLQ= X-Received: by 2002:a02:ac81:: with SMTP id x1mr8934599jan.31.1550345473981; Sat, 16 Feb 2019 11:31:13 -0800 (PST) MIME-Version: 1.0 Received: by 2002:a02:940e:0:0:0:0:0 with HTTP; Sat, 16 Feb 2019 11:31:13 -0800 (PST) From: Carl Eugen Hoyos Date: Sat, 16 Feb 2019 20:31:13 +0100 Message-ID: To: FFmpeg development discussions and patches Subject: [FFmpeg-devel] [PATCH]lavf/mxfdec: Export EIA608 Closed Captions by default X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Hi! I am not sure why there is an option to disable Closed Captions export, but disabling the export by default seems like a bad idea to me. Please comment, Carl Eugen From 9ee6b52c22ae516f9f10116381123595ea51bb0a Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Sat, 16 Feb 2019 20:24:03 +0100 Subject: [PATCH] lavf/mxfdec: Extract EIA608 Closed Captions by default. Related to ticket #5362. --- libavformat/mxfdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index 0553adc..b6c9e60 100644 --- a/libavformat/mxfdec.c +++ b/libavformat/mxfdec.c @@ -3712,7 +3712,7 @@ static int mxf_read_seek(AVFormatContext *s, int stream_index, int64_t sample_ti static const AVOption options[] = { { "eia608_extract", "extract eia 608 captions from s436m track", - offsetof(MXFContext, eia608_extract), AV_OPT_TYPE_BOOL, {.i64 = 0}, 0, 1, + offsetof(MXFContext, eia608_extract), AV_OPT_TYPE_BOOL, {.i64 = 1}, 0, 1, AV_OPT_FLAG_DECODING_PARAM }, { NULL }, }; -- 1.7.10.4