[FFmpeg-devel,1/2] configure: enable libvpx-vp9 encoder and decoder

Submitted by Guo, Yejun on March 4, 2019, 9:21 p.m.

Details

Message ID 1551734508-4646-1-git-send-email-yejun.guo@intel.com
State New
Headers show

Commit Message

Guo, Yejun March 4, 2019, 9:21 p.m.
currently run confingure and there is no "libvpx_vp9" for encoder and
decoder in the output string, while "libvpx_vp8" is there.

Signed-off-by: Guo, Yejun <yejun.guo@intel.com>
---
 configure | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

James Almer March 4, 2019, 1:50 p.m.
On 3/4/2019 6:21 PM, Guo, Yejun wrote:
> currently run confingure and there is no "libvpx_vp9" for encoder and
> decoder in the output string, while "libvpx_vp8" is there.

The check is working fine as is on systems without pthreads, so the
commit message is wrong. It should say something like adding missing
pthreads extralibs dependency to it.

> 
> Signed-off-by: Guo, Yejun <yejun.guo@intel.com>
> ---
>  configure | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/configure b/configure
> index 3042ab9..1c0ba78 100755
> --- a/configure
> +++ b/configure
> @@ -6236,11 +6236,11 @@ enabled libvpx            && {
>      }
>      enabled libvpx_vp9_decoder && {
>          check_pkg_config libvpx_vp9_decoder "vpx >= 1.4.0" "vpx/vpx_decoder.h vpx/vp8dx.h" vpx_codec_vp9_dx ||
> -            check_lib libvpx_vp9_decoder "vpx/vpx_decoder.h vpx/vp8dx.h" "vpx_codec_vp9_dx VPX_IMG_FMT_HIGHBITDEPTH" "-lvpx $libm_extralibs"
> +            check_lib libvpx_vp9_decoder "vpx/vpx_decoder.h vpx/vp8dx.h" "vpx_codec_vp9_dx VPX_IMG_FMT_HIGHBITDEPTH" "-lvpx $libm_extralibs -lpthread"

$pthreads_extralibs, not -lpthread. the former will be set to the
correct ldflag depending on the host system.

>      }
>      enabled libvpx_vp9_encoder && {
>          check_pkg_config libvpx_vp9_encoder "vpx >= 1.4.0" "vpx/vpx_encoder.h vpx/vp8cx.h" vpx_codec_vp9_cx ||
> -            check_lib libvpx_vp9_encoder "vpx/vpx_encoder.h vpx/vp8cx.h" "vpx_codec_vp9_cx VPX_IMG_FMT_HIGHBITDEPTH" "-lvpx $libm_extralibs"
> +            check_lib libvpx_vp9_encoder "vpx/vpx_encoder.h vpx/vp8cx.h" "vpx_codec_vp9_cx VPX_IMG_FMT_HIGHBITDEPTH" "-lvpx $libm_extralibs -lpthread"
>      }
>      if disabled_all libvpx_vp8_decoder libvpx_vp9_decoder libvpx_vp8_encoder libvpx_vp9_encoder; then
>          die "libvpx enabled but no supported decoders found"
> 

LGTM otherwise.
Guo, Yejun March 4, 2019, 2:05 p.m.
> -----Original Message-----

> From: ffmpeg-devel [mailto:ffmpeg-devel-bounces@ffmpeg.org] On Behalf

> Of James Almer

> Sent: Monday, March 04, 2019 9:51 PM

> To: ffmpeg-devel@ffmpeg.org

> Subject: Re: [FFmpeg-devel] [PATCH 1/2] configure: enable libvpx-vp9

> encoder and decoder

> 

> On 3/4/2019 6:21 PM, Guo, Yejun wrote:

> > currently run confingure and there is no "libvpx_vp9" for encoder and

> > decoder in the output string, while "libvpx_vp8" is there.

> 

> The check is working fine as is on systems without pthreads, so the

> commit message is wrong. It should say something like adding missing

> pthreads extralibs dependency to it.


yes, you are right, will fix.

> 

> >

> > Signed-off-by: Guo, Yejun <yejun.guo@intel.com>

> > ---

> >  configure | 4 ++--

> >  1 file changed, 2 insertions(+), 2 deletions(-)

> >

> > diff --git a/configure b/configure

> > index 3042ab9..1c0ba78 100755

> > --- a/configure

> > +++ b/configure

> > @@ -6236,11 +6236,11 @@ enabled libvpx            && {

> >      }

> >      enabled libvpx_vp9_decoder && {

> >          check_pkg_config libvpx_vp9_decoder "vpx >= 1.4.0"

> "vpx/vpx_decoder.h vpx/vp8dx.h" vpx_codec_vp9_dx ||

> > -            check_lib libvpx_vp9_decoder "vpx/vpx_decoder.h vpx/vp8dx.h"

> "vpx_codec_vp9_dx VPX_IMG_FMT_HIGHBITDEPTH" "-lvpx $libm_extralibs"

> > +            check_lib libvpx_vp9_decoder "vpx/vpx_decoder.h vpx/vp8dx.h"

> "vpx_codec_vp9_dx VPX_IMG_FMT_HIGHBITDEPTH" "-lvpx $libm_extralibs

> -lpthread"

> 

> $pthreads_extralibs, not -lpthread. the former will be set to the

> correct ldflag depending on the host system.

> 

> >      }

> >      enabled libvpx_vp9_encoder && {

> >          check_pkg_config libvpx_vp9_encoder "vpx >= 1.4.0"

> "vpx/vpx_encoder.h vpx/vp8cx.h" vpx_codec_vp9_cx ||

> > -            check_lib libvpx_vp9_encoder "vpx/vpx_encoder.h vpx/vp8cx.h"

> "vpx_codec_vp9_cx VPX_IMG_FMT_HIGHBITDEPTH" "-lvpx $libm_extralibs"

> > +            check_lib libvpx_vp9_encoder "vpx/vpx_encoder.h vpx/vp8cx.h"

> "vpx_codec_vp9_cx VPX_IMG_FMT_HIGHBITDEPTH" "-lvpx $libm_extralibs -

> lpthread"

> >      }

> >      if disabled_all libvpx_vp8_decoder libvpx_vp9_decoder

> libvpx_vp8_encoder libvpx_vp9_encoder; then

> >          die "libvpx enabled but no supported decoders found"

> >

> 

> LGTM otherwise.

> _______________________________________________

> ffmpeg-devel mailing list

> ffmpeg-devel@ffmpeg.org

> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Patch hide | download patch | download mbox

diff --git a/configure b/configure
index 3042ab9..1c0ba78 100755
--- a/configure
+++ b/configure
@@ -6236,11 +6236,11 @@  enabled libvpx            && {
     }
     enabled libvpx_vp9_decoder && {
         check_pkg_config libvpx_vp9_decoder "vpx >= 1.4.0" "vpx/vpx_decoder.h vpx/vp8dx.h" vpx_codec_vp9_dx ||
-            check_lib libvpx_vp9_decoder "vpx/vpx_decoder.h vpx/vp8dx.h" "vpx_codec_vp9_dx VPX_IMG_FMT_HIGHBITDEPTH" "-lvpx $libm_extralibs"
+            check_lib libvpx_vp9_decoder "vpx/vpx_decoder.h vpx/vp8dx.h" "vpx_codec_vp9_dx VPX_IMG_FMT_HIGHBITDEPTH" "-lvpx $libm_extralibs -lpthread"
     }
     enabled libvpx_vp9_encoder && {
         check_pkg_config libvpx_vp9_encoder "vpx >= 1.4.0" "vpx/vpx_encoder.h vpx/vp8cx.h" vpx_codec_vp9_cx ||
-            check_lib libvpx_vp9_encoder "vpx/vpx_encoder.h vpx/vp8cx.h" "vpx_codec_vp9_cx VPX_IMG_FMT_HIGHBITDEPTH" "-lvpx $libm_extralibs"
+            check_lib libvpx_vp9_encoder "vpx/vpx_encoder.h vpx/vp8cx.h" "vpx_codec_vp9_cx VPX_IMG_FMT_HIGHBITDEPTH" "-lvpx $libm_extralibs -lpthread"
     }
     if disabled_all libvpx_vp8_decoder libvpx_vp9_decoder libvpx_vp8_encoder libvpx_vp9_encoder; then
         die "libvpx enabled but no supported decoders found"