From patchwork Thu Mar 7 01:39:22 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jun Zhao X-Patchwork-Id: 12229 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id 0E399447571 for ; Thu, 7 Mar 2019 03:39:37 +0200 (EET) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E816068A489; Thu, 7 Mar 2019 03:39:36 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-pg1-f172.google.com (mail-pg1-f172.google.com [209.85.215.172]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C22AC689BF0 for ; Thu, 7 Mar 2019 03:39:30 +0200 (EET) Received: by mail-pg1-f172.google.com with SMTP id l11so9895526pgq.10 for ; Wed, 06 Mar 2019 17:39:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=AcK+h5xS9nOhB9Bv6yH4OjZ53dHbMdVADQcdTd4Ra5U=; b=KlUxF5uUTNqVIipzPPtr4yE2utu00fnCG5lvqfAoxv7V7cRj1kQywqkp8PqPDAutap ddkok9IE4oGhHdDXZ3Ca5KSFI6glgcUbUHDjJPfhicgmIqhn9lDtgFYrEVW6HkW0W3qq xM+HfsoS7iV7hif5ltNe6man2lkUvshGlqnIp6hJ9PHReIZFFxWc5w/eugKizvtrtt4s 63JfYOuld9eJs+1i/omvfWYYuQSH1GGHg/USCUCL7BSupgvkAFiDaujbBDOIKzwNNict 6eIj/6R8ODhvZluSnJXQiaHBVBVPBa+tdNuTJiCUHArvN5URV+Dd9yhPeBIaIqKEKwSj bo6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=AcK+h5xS9nOhB9Bv6yH4OjZ53dHbMdVADQcdTd4Ra5U=; b=ogPBGy6MSsjTvQNErahyeHBHhfB3dupJrkoTNYSjo4cMT/XmZuCKrLg6xz0pggnHdQ jS5su+YPZvCSWOjLy9LAqKR+WZzlWnDwMrbRBzZMoel7NMw/kdVoh0cQksgfZiVZQ+PS 41JVTL2TZrBrIyiGjm4s+opFgfqNPNDGcT8aHmfEC9QLXq9k2iVnprtJN33AXzpD86E/ esYrY6l9gbIeUVFaWYGeoyaRa+Y+j/t0PrSICtkiFQ1S0VMCXIz0OGPtj5Yzcw4Y5VTJ kltFpS9FrFha1qxhfR3jdDhF+XMyCCm1UGjBNVX2gR2og4xWzHZdMqiC1lVOYM5fimYw UGBw== X-Gm-Message-State: APjAAAU47xO/4u4IgTrL6OL0N0eMpu4txHJHTB3FsYQRbaTcy8ppg4Y9 DPgwA6WgRJwgoTw+fvds9h71ztHcezg= X-Google-Smtp-Source: APXvYqy1nw2QcetHsmE9CdXAvGWb3TpBuP5jVDgFB0rmY3iWkVRbRysGRIGhRXXQmALFxl71Oxkelg== X-Received: by 2002:a63:d205:: with SMTP id a5mr9144640pgg.142.1551922768601; Wed, 06 Mar 2019 17:39:28 -0800 (PST) Received: from localhost.localdomain ([47.90.47.25]) by smtp.gmail.com with ESMTPSA id g80sm6583169pfd.72.2019.03.06.17.39.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 06 Mar 2019 17:39:27 -0800 (PST) From: Jun Zhao To: ffmpeg-devel@ffmpeg.org Date: Thu, 7 Mar 2019 09:39:22 +0800 Message-Id: <1551922762-22342-1-git-send-email-mypopydev@gmail.com> X-Mailer: git-send-email 1.7.1 In-Reply-To: References: Subject: [FFmpeg-devel] [PATCH V2] lavfi/nlmeans: Checking number precision when computing integral images X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Jun Zhao MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" From: Jun Zhao accumulation of 8-bits uint_8 (uint8_t *src) into 32-bits (uint32_t *ii) data type, it will have a risk of an integral value becoming larger than the 32-bits integer capacity and resulting in an integer overflow. For this risk, add a checking with warning message. Signed-off-by: Jun Zhao --- libavfilter/vf_nlmeans.c | 7 +++++++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/libavfilter/vf_nlmeans.c b/libavfilter/vf_nlmeans.c index dcb5a03..e7015cd 100644 --- a/libavfilter/vf_nlmeans.c +++ b/libavfilter/vf_nlmeans.c @@ -236,6 +236,13 @@ static void compute_ssd_integral_image(const NLMeansDSPContext *dsp, // adjusted end x position of the safe area after width of the safe area gets aligned const int endx_safe = startx_safe + safe_pw; + // accumulation of 8-bits uint_8 (uint8_t *src) into 32-bits (uint32_t *ii) + // data type, it will have a risk of an integral value becoming larger than + // the 32-bits integer capacity and resulting in an integer overflow. + if ((UINT32_MAX / (uint64_t)w) < (UINT8_MAX * (uint64_t)h)) + av_log(NULL, AV_LOG_WARNING, + "image (%d x %d) integral value maybe overflow.\n", w ,h); + // top part where only one of s1 and s2 is still readable, or none at all compute_unsafe_ssd_integral_image(ii, ii_linesize_32, 0, 0,