[FFmpeg-devel] tests/fate/ffmpeg: Check apng codec for fate-copy-apng

Submitted by Carl Eugen Hoyos on March 14, 2019, 11:29 p.m.

Details

Message ID CAB0OVGo-yD=01Yr4pnp9dg4g5xfFbbjgiLvWm2O7L-Ngn9K7Kg@mail.gmail.com
State Accepted
Headers show

Commit Message

Carl Eugen Hoyos March 14, 2019, 11:29 p.m.
Hi!

Attached patch fixes fate here without zlib.

Please comment, Carl Eugen

Comments

James Almer March 14, 2019, 11:38 p.m.
On 3/14/2019 8:29 PM, Carl Eugen Hoyos wrote:
> Hi!
> 
> Attached patch fixes fate here without zlib.
> 
> Please comment, Carl Eugen
> 
> 
> 0001-tests-fate-ffmpeg-Check-for-apng-codec-for-fate-copy.patch
> 
> From 209fff61a2a680a5adf5df82774f7dd48fc4701c Mon Sep 17 00:00:00 2001
> From: Carl Eugen Hoyos <ceffmpeg@gmail.com>
> Date: Fri, 15 Mar 2019 00:27:33 +0100
> Subject: [PATCH] tests/fate/ffmpeg: Check for apng codec for fate-copy-apng.
> 
> The file has to be created first, fixes fate without zlib.
> ---
>  tests/fate/ffmpeg.mak |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/fate/ffmpeg.mak b/tests/fate/ffmpeg.mak
> index ac68cde..6e9fd28 100644
> --- a/tests/fate/ffmpeg.mak
> +++ b/tests/fate/ffmpeg.mak
> @@ -93,7 +93,7 @@ fate-copy-trac2211-avi: $(TARGET_SAMPLES)/h264/bbc2.sample.h264
>  fate-copy-trac2211-avi: CMD = transcode "h264 -r 14" $(TARGET_SAMPLES)/h264/bbc2.sample.h264\
>                            avi "-c:a copy -c:v copy"
>  
> -FATE_STREAMCOPY-$(call ALLYES, APNG_DEMUXER APNG_MUXER) += fate-copy-apng
> +FATE_STREAMCOPY-$(call ALLYES, APNG_DEMUXER APNG_MUXER APNG_DECODER APNG_ENCODER) += fate-copy-apng
>  fate-copy-apng: fate-lavf-apng
>  fate-copy-apng: CMD = transcode apng "$(TARGET_PATH)/tests/data/lavf/lavf.apng" apng "-c:v copy"

Use $(call ENCDEC, APNG, APNG) instead.

LGTM, thanks.
Carl Eugen Hoyos March 15, 2019, 12:42 a.m.
2019-03-15 0:38 GMT+01:00, James Almer <jamrial@gmail.com>:
> On 3/14/2019 8:29 PM, Carl Eugen Hoyos wrote:
>> Hi!
>>
>> Attached patch fixes fate here without zlib.
>>
>> Please comment, Carl Eugen
>>
>>
>> 0001-tests-fate-ffmpeg-Check-for-apng-codec-for-fate-copy.patch
>>
>> From 209fff61a2a680a5adf5df82774f7dd48fc4701c Mon Sep 17 00:00:00 2001
>> From: Carl Eugen Hoyos <ceffmpeg@gmail.com>
>> Date: Fri, 15 Mar 2019 00:27:33 +0100
>> Subject: [PATCH] tests/fate/ffmpeg: Check for apng codec for
>> fate-copy-apng.
>>
>> The file has to be created first, fixes fate without zlib.
>> ---
>>  tests/fate/ffmpeg.mak |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tests/fate/ffmpeg.mak b/tests/fate/ffmpeg.mak
>> index ac68cde..6e9fd28 100644
>> --- a/tests/fate/ffmpeg.mak
>> +++ b/tests/fate/ffmpeg.mak
>> @@ -93,7 +93,7 @@ fate-copy-trac2211-avi:
>> $(TARGET_SAMPLES)/h264/bbc2.sample.h264
>>  fate-copy-trac2211-avi: CMD = transcode "h264 -r 14"
>> $(TARGET_SAMPLES)/h264/bbc2.sample.h264\
>>                            avi "-c:a copy -c:v copy"
>>
>> -FATE_STREAMCOPY-$(call ALLYES, APNG_DEMUXER APNG_MUXER) += fate-copy-apng
>> +FATE_STREAMCOPY-$(call ALLYES, APNG_DEMUXER APNG_MUXER APNG_DECODER
>> APNG_ENCODER) += fate-copy-apng
>>  fate-copy-apng: fate-lavf-apng
>>  fate-copy-apng: CMD = transcode apng
>> "$(TARGET_PATH)/tests/data/lavf/lavf.apng" apng "-c:v copy"
>
> Use $(call ENCDEC, APNG, APNG) instead.
>
> LGTM, thanks.

Applied with this change.

Thank you, Carl Eugen

Patch hide | download patch | download mbox

From 209fff61a2a680a5adf5df82774f7dd48fc4701c Mon Sep 17 00:00:00 2001
From: Carl Eugen Hoyos <ceffmpeg@gmail.com>
Date: Fri, 15 Mar 2019 00:27:33 +0100
Subject: [PATCH] tests/fate/ffmpeg: Check for apng codec for fate-copy-apng.

The file has to be created first, fixes fate without zlib.
---
 tests/fate/ffmpeg.mak |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/fate/ffmpeg.mak b/tests/fate/ffmpeg.mak
index ac68cde..6e9fd28 100644
--- a/tests/fate/ffmpeg.mak
+++ b/tests/fate/ffmpeg.mak
@@ -93,7 +93,7 @@  fate-copy-trac2211-avi: $(TARGET_SAMPLES)/h264/bbc2.sample.h264
 fate-copy-trac2211-avi: CMD = transcode "h264 -r 14" $(TARGET_SAMPLES)/h264/bbc2.sample.h264\
                           avi "-c:a copy -c:v copy"
 
-FATE_STREAMCOPY-$(call ALLYES, APNG_DEMUXER APNG_MUXER) += fate-copy-apng
+FATE_STREAMCOPY-$(call ALLYES, APNG_DEMUXER APNG_MUXER APNG_DECODER APNG_ENCODER) += fate-copy-apng
 fate-copy-apng: fate-lavf-apng
 fate-copy-apng: CMD = transcode apng "$(TARGET_PATH)/tests/data/lavf/lavf.apng" apng "-c:v copy"
 
-- 
1.7.10.4