From patchwork Tue Apr 9 22:07:27 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Thompson X-Patchwork-Id: 12671 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id 49D51448A83 for ; Wed, 10 Apr 2019 01:07:51 +0300 (EEST) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 370EC68AE05; Wed, 10 Apr 2019 01:07:51 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C8C3568ADEA for ; Wed, 10 Apr 2019 01:07:44 +0300 (EEST) Received: by mail-wm1-f51.google.com with SMTP id 4so384414wmf.1 for ; Tue, 09 Apr 2019 15:07:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jkqxz-net.20150623.gappssmtp.com; s=20150623; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=whMmqbMw5KWhIJRN4GRQ4IBQNb1vBBVhltXJEJd3d0I=; b=1x4YCnLxrdjfQ1+9RtKhAYvycUD+4OP1JYMTRVR/Dj9Scg77QgzuMNsUS6n5+7PZ7N etOLl+n3WwapPrO9WKyHLyt8IDAMhv4ExxlSSfHAxhU7Jit6st8MENoseLg7v3P4f5Uq KC5j94BUXEzxIj3RzmvyAZvfE9Q7NePNPAsF6CuZC2+rWkvF8nC6OaBwtyL/2B1K6Qt0 69Mgk2ZKmORUOkh17NDtuSJp2o2WE35SIWODL90tK7f60oernEe7oZgci8rp3D2mJl3u IuWKMPSKfb+Gz/3BC5h00hFphmPhHo5jET60bYtpTmgxUYWZ3eIXk3DY9TjCxoQfKv4u 47wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=whMmqbMw5KWhIJRN4GRQ4IBQNb1vBBVhltXJEJd3d0I=; b=dQvPFiLechzanP4nsIyBwx1GzX+F6caWq63opTefli2WCzfdAe0OttYH0iL5dSuBAW tDrASgmhFBeGf6jCS+qNW4vLv2oMCOlwY7hSMllmpvtTBmrKSe0zQZdTHKj6cklPk3PN LAwBSYh8cvmbhZlvMcmBAm78UmF8Ax5uZZY6DV9QPIssgO/zkUmbV5uVtBEvK8diYubK Tkl65vzPpX6AoyabmUkBEvD3C+gD6KlJoW1QuEKzq+y+iqzkYWe8M8QXmFE1AYOQb3fs hOgFD8S5CgAnFEihM98FTMzx865lSyrogpPro0bjzi/kPG0EsTK1cxpmvU548tCSTD2Y /DFA== X-Gm-Message-State: APjAAAX1Uf5pa1pEpxzkX0CySkYeJWa6x7xgkBZibyUj4nyFe+MplICm 4qAniNvXnADq3ox3BFa+DT/y8Q1kI3U= X-Google-Smtp-Source: APXvYqxbPr58tabi+nz/adGyu4013bcMnSj/yKfzLMu9bSEZpdXMfO4tDTHr7ug4Dqnn2dNoXe2AvQ== X-Received: by 2002:a1c:3507:: with SMTP id c7mr360829wma.20.1554847663919; Tue, 09 Apr 2019 15:07:43 -0700 (PDT) Received: from rywe.jkqxz.net (cpc91242-cmbg18-2-0-cust650.5-4.cable.virginm.net. [82.8.130.139]) by smtp.gmail.com with ESMTPSA id v6sm41224332wrt.56.2019.04.09.15.07.42 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 09 Apr 2019 15:07:43 -0700 (PDT) From: Mark Thompson To: ffmpeg-devel@ffmpeg.org Date: Tue, 9 Apr 2019 23:07:27 +0100 Message-Id: <20190409220730.29311-4-sw@jkqxz.net> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190409220730.29311-1-sw@jkqxz.net> References: <20190409220730.29311-1-sw@jkqxz.net> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH v4 4/7] vf_misc_vaapi: Add missing return value checks X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Parameter buffer creation can fail. --- libavfilter/vf_misc_vaapi.c | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/libavfilter/vf_misc_vaapi.c b/libavfilter/vf_misc_vaapi.c index 6f31a04293..6fbd453741 100644 --- a/libavfilter/vf_misc_vaapi.c +++ b/libavfilter/vf_misc_vaapi.c @@ -84,10 +84,9 @@ static int denoise_vaapi_build_filter_params(AVFilterContext *avctx) denoise.value = map(ctx->denoise, DENOISE_MIN, DENOISE_MAX, caps.range.min_value, caps.range.max_value); - ff_vaapi_vpp_make_param_buffers(avctx, VAProcFilterParameterBufferType, - &denoise, sizeof(denoise), 1); - - return 0; + return ff_vaapi_vpp_make_param_buffers(avctx, + VAProcFilterParameterBufferType, + &denoise, sizeof(denoise), 1); } static int sharpness_vaapi_build_filter_params(AVFilterContext *avctx) @@ -116,11 +115,9 @@ static int sharpness_vaapi_build_filter_params(AVFilterContext *avctx) SHARPNESS_MIN, SHARPNESS_MAX, caps.range.min_value, caps.range.max_value); - ff_vaapi_vpp_make_param_buffers(avctx, - VAProcFilterParameterBufferType, - &sharpness, sizeof(sharpness), 1); - - return 0; + return ff_vaapi_vpp_make_param_buffers(avctx, + VAProcFilterParameterBufferType, + &sharpness, sizeof(sharpness), 1); } static int misc_vaapi_filter_frame(AVFilterLink *inlink, AVFrame *input_frame)