From patchwork Wed Apr 10 18:30:03 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: James Almer X-Patchwork-Id: 12694 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id 03C9A4485AA for ; Wed, 10 Apr 2019 21:30:58 +0300 (EEST) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D84A468ACFC; Wed, 10 Apr 2019 21:30:57 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-qt1-f196.google.com (mail-qt1-f196.google.com [209.85.160.196]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 351D068ACEF for ; Wed, 10 Apr 2019 21:30:52 +0300 (EEST) Received: by mail-qt1-f196.google.com with SMTP id z16so4090953qtn.4 for ; Wed, 10 Apr 2019 11:30:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=/bST4SP46AR5TjfL/GzJzMEtGSzGIMOnGKTG+mc/ZA4=; b=r9yLXCWRsFB2PNKQigCV5fREYL/kFg/p2I2n0c3Z6IjtLfx4ZBc+iiPRdwqjFx0uVt o6/AUJQV+5/FNj1gcaHAuDk1gzruAp07C7v6/eap1KMTp6/TEI+0O/4awnAz7tYuKSrT UiJmwh4cOO4oATUarIyDa42opR9kT8dDDAuS4EyL9mYHBogcdxCEFYxs7i9w8ARmLvDz 4o7ddMSMKrU1wbpmmdKhkOfYDKd9aCVEb7Srg1J9kzSza3v/ou1Oc6m4/6SvM1VcRs9q EvpeLZ9b5B4woCVyZgtfcbTT6YuYYzVOj/HuOIRsk69mFDqrplg4aFjsGHNyu95gmCl1 7WCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=/bST4SP46AR5TjfL/GzJzMEtGSzGIMOnGKTG+mc/ZA4=; b=S2p+pf0/uXXB54fs4q8kgGhVJX/Dp3czeN2+poB18RKclQNCiqBzt34VbFQupToUZP MKyd9hFU/MISbSUmiwwMHtqUVu57y83w13ooUBcnsKUrw8BhSwe9SKLJp4Ftle910uxS s41RQoLClxfOGFS2ODJF2yojWp8DD1NAm5BNQSNmzeDxl8H7hO+rYVY4PewZmb+2PgRr /dFutgpmvmfmH85DhMGKdd26RHx9idGCUO+B7aHhqbENi9UF56MooEnsIhMr7f7rAEgt D8SL7PGdDTuoGSpFODoxSaYNks9IAb2Z/rMRnMHqYKHpCe+0EZygPb0mX3dgYPYuExUY NhUA== X-Gm-Message-State: APjAAAWHH+/dDVQoHsrUfp4hxrTLcqWD6lQZOKefSKFg1FGqP+QG0AwF +ZoFvWip9h+KdSVuB8MEQYoNp9UD X-Google-Smtp-Source: APXvYqy3njl4WBVk9lHbcpRALBy+wcS70sBJTzzvVep+db0KgUgd5c+oH8fY19WN8FvjkZcxjt0Z3Q== X-Received: by 2002:aed:3fa7:: with SMTP id s36mr38936717qth.124.1554921050795; Wed, 10 Apr 2019 11:30:50 -0700 (PDT) Received: from localhost.localdomain ([181.23.83.131]) by smtp.gmail.com with ESMTPSA id w18sm31860971qta.2.2019.04.10.11.30.49 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 10 Apr 2019 11:30:50 -0700 (PDT) From: James Almer To: ffmpeg-devel@ffmpeg.org Date: Wed, 10 Apr 2019 15:30:03 -0300 Message-Id: <20190410183003.2056-1-jamrial@gmail.com> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH] avcodec/h264_ps: fix storage size for offset_for_ref_frame X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" The spec defines the valid range of values to be INT32_MIN + 1 to INT32_MAX, inclusive. Signed-off-by: James Almer --- A good example of why making offsets and sizes of structs like this tied to the ABI is not a good idea. libavcodec/h264_ps.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/h264_ps.h b/libavcodec/h264_ps.h index e967b9cbcf..9014326dfb 100644 --- a/libavcodec/h264_ps.h +++ b/libavcodec/h264_ps.h @@ -81,7 +81,7 @@ typedef struct SPS { uint32_t num_units_in_tick; uint32_t time_scale; int fixed_frame_rate_flag; - short offset_for_ref_frame[256]; // FIXME dyn aloc? + int32_t offset_for_ref_frame[256]; int bitstream_restriction_flag; int num_reorder_frames; int scaling_matrix_present;