[FFmpeg-devel,V1] avformat/avformat.h: correct the comment for AVInputFormat.extensions

Submitted by Jun Zhao on April 13, 2019, 12:46 a.m.

Details

Message ID 1555116366-7270-1-git-send-email-mypopydev@gmail.com
State New
Headers show

Commit Message

Jun Zhao April 13, 2019, 12:46 a.m.
From: Jun Zhao <barryjzhao@tencent.com>

Now the probe logic is: Only read_probe is NULL and extensions are defined,
then no probe is done. Correct the comment to follow the coding logic.

Signed-off-by: Jun Zhao <barryjzhao@tencent.com>
---
 libavformat/avformat.h |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

Comments

Michael Niedermayer April 13, 2019, 11:06 p.m.
On Sat, Apr 13, 2019 at 08:46:06AM +0800, Jun Zhao wrote:
> From: Jun Zhao <barryjzhao@tencent.com>
> 
> Now the probe logic is: Only read_probe is NULL and extensions are defined,
> then no probe is done. Correct the comment to follow the coding logic.
> 
> Signed-off-by: Jun Zhao <barryjzhao@tencent.com>
> ---
>  libavformat/avformat.h |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/libavformat/avformat.h b/libavformat/avformat.h
> index 734ae54..bbfa61d 100644
> --- a/libavformat/avformat.h
> +++ b/libavformat/avformat.h
> @@ -659,8 +659,8 @@ typedef struct AVInputFormat {
>      int flags;
>  
>      /**
> -     * If extensions are defined, then no probe is done. You should
> -     * usually not use extension format guessing because it is not

> +     * If read_probe is NULL and extensions are defined, then no probe is done.

Why do you refer to extensions here ?
if read_probe is not set (NULL), no probe (based on input content) can be done,
extensions does not change that.

[...]

Patch hide | download patch | download mbox

diff --git a/libavformat/avformat.h b/libavformat/avformat.h
index 734ae54..bbfa61d 100644
--- a/libavformat/avformat.h
+++ b/libavformat/avformat.h
@@ -659,8 +659,8 @@  typedef struct AVInputFormat {
     int flags;
 
     /**
-     * If extensions are defined, then no probe is done. You should
-     * usually not use extension format guessing because it is not
+     * If read_probe is NULL and extensions are defined, then no probe is done.
+     * You should usually not use extension format guessing because it is not
      * reliable enough
      */
     const char *extensions;