[FFmpeg-devel] avutil/colorspace: add macros for RGB->YUV BT.709

Submitted by Gyan on April 13, 2019, 11:53 a.m.

Details

Message ID 707c9500-fd47-ffa2-a17a-bf89887b4385@gyani.pro
State New
Headers show

Commit Message

Gyan April 13, 2019, 11:53 a.m.
Will be helpful for correct result in filters that paint like 
fillborders/drawbox or those using drawutils.

Gyan
From 9c83440a0ac048a1dcb0762b85adbce5a58e0939 Mon Sep 17 00:00:00 2001
From: Gyan Doshi <ffmpeg@gyani.pro>
Date: Sat, 13 Apr 2019 17:01:09 +0530
Subject: [PATCH] avutil/colorspace: add macros for RGB->YUV BT.709

---
 libavutil/colorspace.h | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

Comments

Gyan April 17, 2019, 4:25 a.m.
On 13-04-2019 05:23 PM, Gyan wrote:
> Will be helpful for correct result in filters that paint like 
> fillborders/drawbox or those using drawutils.

Ping.
Vittorio Giovara April 17, 2019, 5:41 p.m.
On Wed, Apr 17, 2019 at 12:26 AM Gyan <ffmpeg@gyani.pro> wrote:

>
>
> On 13-04-2019 05:23 PM, Gyan wrote:
> > Will be helpful for correct result in filters that paint like
> > fillborders/drawbox or those using drawutils.
>
> Ping.
>

these seem to only work for 8 bit content, is that their only intended
usecase?
if so, could there be at least a comment mentioning that please?
Gyan April 17, 2019, 6 p.m.
On 17-04-2019 11:11 PM, Vittorio Giovara wrote:
> On Wed, Apr 17, 2019 at 12:26 AM Gyan <ffmpeg@gyani.pro> wrote:
>
>>
>> On 13-04-2019 05:23 PM, Gyan wrote:
>>> Will be helpful for correct result in filters that paint like
>>> fillborders/drawbox or those using drawutils.
>> Ping.
>>
> these seem to only work for 8 bit content, is that their only intended
> usecase?
> if so, could there be at least a comment mentioning that please?
Yes, the existing macros use Rec.601 co-efficients, but most data is 709 
now.
Will add a note.

Gyan

Patch hide | download patch | download mbox

diff --git a/libavutil/colorspace.h b/libavutil/colorspace.h
index d0be8cb99a..73d51cad47 100644
--- a/libavutil/colorspace.h
+++ b/libavutil/colorspace.h
@@ -119,4 +119,31 @@  static inline int C_JPEG_TO_CCIR(int y) {
 (((FIX(0.50000) * r1 - FIX(0.41869) * g1 - \
    FIX(0.08131) * b1 + (ONE_HALF) - 1) >> (SCALEBITS)) + 128)
 
+// Derived from ITU-R BT.709-6 (06/2015) Item 3.5
+// https://www.itu.int/rec/R-REC-BT.709-6-201506-I/en
+
+#define RGB_TO_Y_BT709(r, g, b) \
+((FIX(0.21260*219.0/255.0) * (r) + FIX(0.71520*219.0/255.0) * (g) + \
+  FIX(0.07220*219.0/255.0) * (b) + (ONE_HALF + (16 << SCALEBITS))) >> SCALEBITS)
+
+#define RGB_TO_U_BT709(r1, g1, b1, shift)\
+(((- FIX(0.11457*224.0/255.0) * r1 - FIX(0.38543*224.0/255.0) * g1 +         \
+     FIX(0.50000*224.0/255.0) * b1 + (ONE_HALF << shift) - 1) >> (SCALEBITS + shift)) + 128)
+
+#define RGB_TO_V_BT709(r1, g1, b1, shift)\
+(((FIX(0.50000*224.0/255.0) * r1 - FIX(0.45415*224.0/255.0) * g1 -           \
+   FIX(0.04585*224.0/255.0) * b1 + (ONE_HALF << shift) - 1) >> (SCALEBITS + shift)) + 128)
+
+#define RGB_TO_Y_BT709_FULL(r, g, b) \
+(FFMIN((FIX(0.21260) * (r) + FIX(0.71520) * (g) + \
+  FIX(0.07220) * (b) + (ONE_HALF)) >> SCALEBITS, 255))
+
+#define RGB_TO_U_BT709_FULL(r1, g1, b1)\
+(((- FIX(0.11457) * r1 - FIX(0.38543) * g1 + \
+     FIX(0.50000) * b1 + (ONE_HALF) - 1) >> (SCALEBITS)) + 128)
+
+#define RGB_TO_V_BT709_FULL(r1, g1, b1)\
+(((FIX(0.50000) * r1 - FIX(0.45415) * g1 - \
+   FIX(0.04585) * b1 + (ONE_HALF) - 1) >> (SCALEBITS)) + 128)
+
 #endif /* AVUTIL_COLORSPACE_H */