From patchwork Sat Apr 13 13:30:50 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thilo Borgmann via ffmpeg-devel X-Patchwork-Id: 12721 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id 8D277448805 for ; Sat, 13 Apr 2019 16:39:58 +0300 (EEST) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 65C5968AAD8; Sat, 13 Apr 2019 16:39:58 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6381C68A925 for ; Sat, 13 Apr 2019 16:39:51 +0300 (EEST) Received: by mail-wr1-f68.google.com with SMTP id w1so15534617wrp.2 for ; Sat, 13 Apr 2019 06:39:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=xWWQYEXwq4qUWlKIdXabjagBWtiGSZaKJ7vReaMgfpI=; b=syma1i3m1b7f2ZYs6ckzva66k7Ku3XgGAWUSkLhDxFqD1hT0CfqFwkRUAi/RYjYfjt +ac2UaMdGnfnA4IMMvpdG/3m9PkA8cmlRoEx0N4+1LTfMz3SoOmbn0tqIjXjD12ep2uG V2kXgcUF3mWydkz8PBen9xu6QtQYeCCOxMSOz9hk9Uxkdq7pvib2Yc+QEh5ttfC5plr3 LEmL6QRxM42Tclh0X5H90rbo2Vn596+UzMOPS8kpGTNvSQmUACo98zlNvp0rtNrbDNKU f5U3q7q0ZreXS777RXHVn9yZsdGAafs50i55MSHz89qjEOIsM57JrqqBLhTOmaGKbejf INow== X-Gm-Message-State: APjAAAU69nIVG7dm/m1zcxveqPQmk+ttX71JnrzO/FoqjRfiA9LYXtw6 gyUakMtWUNs43GaI6C8suKlpRwIH X-Google-Smtp-Source: APXvYqyi1Ya7BPgp3LtE6KvEl16Ie6p+mjwJoasIVXTot7+sGLH9Z8WdGpV843zbVHdSA5WI5w+Dgw== X-Received: by 2002:a5d:6947:: with SMTP id r7mr6174553wrw.167.1555162300063; Sat, 13 Apr 2019 06:31:40 -0700 (PDT) Received: from localhost.localdomain (ipbcc08c44.dynamic.kabel-deutschland.de. [188.192.140.68]) by smtp.googlemail.com with ESMTPSA id t74sm19108603wmt.3.2019.04.13.06.31.39 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 13 Apr 2019 06:31:39 -0700 (PDT) To: ffmpeg-devel@ffmpeg.org Date: Sat, 13 Apr 2019 15:30:50 +0200 Message-Id: <20190413133052.2668-1-andreas.rheinhardt@googlemail.com> X-Mailer: git-send-email 2.19.2 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH 1/3] lavf/webm_chunk: Respect buffer size X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Andreas Rheinhardt via ffmpeg-devel From: Thilo Borgmann via ffmpeg-devel Reply-To: FFmpeg development discussions and patches Cc: Andreas Rheinhardt Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" The last argument of av_strlcpy is supposed to contain the size of the destination buffer, but it was filled with the size of the source string, effectively negating its very purpose. Signed-off-by: Andreas Rheinhardt --- libavformat/webm_chunk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/webm_chunk.c b/libavformat/webm_chunk.c index ec1ec4bf91..2c99753b5b 100644 --- a/libavformat/webm_chunk.c +++ b/libavformat/webm_chunk.c @@ -96,7 +96,7 @@ static int get_chunk_filename(AVFormatContext *s, int is_header, char *filename) av_log(oc, AV_LOG_ERROR, "No header filename provided\n"); return AVERROR(EINVAL); } - av_strlcpy(filename, wc->header_filename, strlen(wc->header_filename) + 1); + av_strlcpy(filename, wc->header_filename, MAX_FILENAME_SIZE); } else { if (av_get_frame_filename(filename, MAX_FILENAME_SIZE, s->url, wc->chunk_index - 1) < 0) {