From patchwork Wed Apr 17 23:23:39 2019
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Michael Niedermayer <michael@niedermayer.cc>
X-Patchwork-Id: 12787
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
X-Original-To: patchwork@ffaux-bg.ffmpeg.org
Delivered-To: patchwork@ffaux-bg.ffmpeg.org
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by ffaux.localdomain (Postfix) with ESMTP id DD4E6448B2E
	for <patchwork@ffaux-bg.ffmpeg.org>;
	Thu, 18 Apr 2019 02:23:47 +0300 (EEST)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B445C68A4D9;
	Thu, 18 Apr 2019 02:23:47 +0300 (EEST)
X-Original-To: ffmpeg-devel@ffmpeg.org
Delivered-To: ffmpeg-devel@ffmpeg.org
Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net
	[217.70.183.201])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6D2DE688254
	for <ffmpeg-devel@ffmpeg.org>; Thu, 18 Apr 2019 02:23:41 +0300 (EEST)
X-Originating-IP: 213.47.41.20
Received: from localhost (213-47-41-20.cable.dynamic.surfer.at
	[213.47.41.20]) (Authenticated sender: michael@niedermayer.cc)
	by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id A9AEB1BF204
	for <ffmpeg-devel@ffmpeg.org>; Wed, 17 Apr 2019 23:23:40 +0000 (UTC)
Date: Thu, 18 Apr 2019 01:23:39 +0200
From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Message-ID: <20190417232339.GT3501@michaelspb>
References: <20190417161639.822-1-onemda@gmail.com>
	<20190417231958.GS3501@michaelspb>
MIME-Version: 1.0
In-Reply-To: <20190417231958.GS3501@michaelspb>
User-Agent: Mutt/1.5.24 (2015-08-30)
Subject: Re: [FFmpeg-devel] [PATCH] avcodec/dvdec: add frame threads
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <http://ffmpeg.org/mailman/options/ffmpeg-devel>,
	<mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <http://ffmpeg.org/pipermail/ffmpeg-devel/>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <http://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
	<mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches
	<ffmpeg-devel@ffmpeg.org>
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>

On Thu, Apr 18, 2019 at 01:19:58AM +0200, Michael Niedermayer wrote:
> On Wed, Apr 17, 2019 at 06:16:39PM +0200, Paul B Mahol wrote:
> > Signed-off-by: Paul B Mahol <onemda@gmail.com>
> > ---
> >  libavcodec/dvdec.c | 19 ++++++++++---------
> >  1 file changed, 10 insertions(+), 9 deletions(-)
> 
> Is this intended to be 100% same output ?
> 
> I have a few cases that produce differences. Dont have a good testcase though
> ./ffmpeg -i ~/tickets/1589/A1590.dv avi-b.avi
> produces different output.
> oddly -f framecrc produces the same output
> not sure this is a problem or not the input file may have issues

heres another testcase:
./ffmpeg -i ~/tickets/2390/dv_cut.dv aviavi2.avi

-rw-r----- 1 michael michael 112414 Apr 18 01:18 aviavi2.avi
-rw-r----- 1 michael michael 112446 Apr 18 01:18 aviavi.avi


[...]

--- strings1	2019-04-18 01:19:42.472574387 +0200
+++ strings2	2019-04-18 01:19:37.764574245 +0200
@@ -1,4 +1,4 @@
-RIFF6
+RIFF
 AVI LIST
 hdrlavih8
 LIST
@@ -8,7 +8,7 @@
 FMP4
 JUNK
 00dc
-vprpd
+vprpD
 LIST
 strlstrh8
 auds