From patchwork Fri Apr 19 00:12:14 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Diego Felix de Souza via ffmpeg-devel X-Patchwork-Id: 12803 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id AF09C448E0B for ; Fri, 19 Apr 2019 03:12:34 +0300 (EEST) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8AC2D680818; Fri, 19 Apr 2019 03:12:34 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-ua1-f66.google.com (mail-ua1-f66.google.com [209.85.222.66]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 35068680806 for ; Fri, 19 Apr 2019 03:12:28 +0300 (EEST) Received: by mail-ua1-f66.google.com with SMTP id n16so1308155uae.10 for ; Thu, 18 Apr 2019 17:12:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=kFxv9H7OIglX+dK+nUCSwXj5dAIgZJoElt98AeUI1RY=; b=aLWqWoDdRfBTP98NI3nHZ4oBMlrucc1YE7NBTwFBD4p70+gzSXdhXhw27p55/PABUe 5jQ/mcSfU0rsj7iCxpzoqfXOX4mLeqWUQsdpkC7cm0xM7y1cgdkviYippgU1djlG57AG aBlKDTw4EpSiBiZDzF84nxoRu5KhY+2Qk4MkCGGgfmQsI0FjxhPeTU24758YejkKzucM i4vJClZG/HN3dNm3GSXduLyS/ObBeKGdb83QgnOz4u34k9E99oSuxHifOYRn2ASrk162 HL2d0rKmkaGACKv3Y+c127tg4BRZxOdyHLCLdgVIOd13Grp59t7YoreizE2O1quHXay/ Qk9Q== X-Gm-Message-State: APjAAAVRXYx42YJtmkjmtBMhwBmiu8ejoLAEr8vLLxrymf9d8LlKSHIm hfCtG7PXFQGBlH9uF5N4NCnv3BM0pnu8/1hoMpZv5RqW0gW+uQ== X-Google-Smtp-Source: APXvYqxi8ney5JiYKihOpOtcQf6pZowC5MZLzaVgaHy6czI83n3mifHIYkwPcAHOOggih68JyAkVcDGnd559/Qmljj8= X-Received: by 2002:ab0:1591:: with SMTP id i17mr536602uae.41.1555632745842; Thu, 18 Apr 2019 17:12:25 -0700 (PDT) MIME-Version: 1.0 Date: Thu, 18 Apr 2019 17:12:14 -0700 Message-ID: To: FFmpeg development discussions and patches Subject: [FFmpeg-devel] [PATCH] avformat/apetag: tag values are unsigned X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Dan Sanders via ffmpeg-devel From: Diego Felix de Souza via ffmpeg-devel Reply-To: FFmpeg development discussions and patches Cc: Dan Sanders Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Fixes: UBSan runtime error Found-by: Clusterfuzz --- libavformat/apetag.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavformat/apetag.c b/libavformat/apetag.c index cdc602e1a9..2991f57d5d 100644 --- a/libavformat/apetag.c +++ b/libavformat/apetag.c @@ -29,10 +29,10 @@ #include "apetag.h" #include "internal.h" -#define APE_TAG_FLAG_CONTAINS_HEADER (1 << 31) -#define APE_TAG_FLAG_LACKS_FOOTER (1 << 30) -#define APE_TAG_FLAG_IS_HEADER (1 << 29) -#define APE_TAG_FLAG_IS_BINARY (1 << 1) +#define APE_TAG_FLAG_CONTAINS_HEADER (1U << 31) +#define APE_TAG_FLAG_LACKS_FOOTER (1U << 30) +#define APE_TAG_FLAG_IS_HEADER (1U << 29) +#define APE_TAG_FLAG_IS_BINARY (1U << 1) static int ape_tag_read_field(AVFormatContext *s) {