diff mbox

[FFmpeg-devel] libavformat/mxfenc: add UID for unconstrained H.264 coded video in baseline profile

Message ID 1470744938-3595-1-git-send-email-atze@fem.tu-ilmenau.de
State Accepted
Commit b83d9077807a5cde4db5f4d726e0a02c787651cb
Headers show

Commit Message

Matthias Hunstock Aug. 9, 2016, 12:15 p.m. UTC
Enable the MXF muxer to mux baseline H.264 video streams.

Signed-off-by: Matthias Hunstock <atze@fem.tu-ilmenau.de>
---
 libavformat/mxfenc.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Michael Niedermayer Aug. 10, 2016, 11:57 p.m. UTC | #1
On Tue, Aug 09, 2016 at 02:15:38PM +0200, Matthias Hunstock wrote:
> Enable the MXF muxer to mux baseline H.264 video streams.
> 
> Signed-off-by: Matthias Hunstock <atze@fem.tu-ilmenau.de>
> ---
>  libavformat/mxfenc.c | 2 ++
>  1 file changed, 2 insertions(+)

thats nice
applied

thanks

[...]
Carl Eugen Hoyos Aug. 12, 2016, 10:36 a.m. UTC | #2
Hi!

2016-08-09 14:15 GMT+02:00 Matthias Hunstock <atze@fem.tu-ilmenau.de>:
> Enable the MXF muxer to mux baseline H.264 video streams.

How can I test this / for which command line does this patch make a difference?

Thank you, Carl Eugen
Matthias Hunstock Aug. 12, 2016, 12:30 p.m. UTC | #3
Am 12.08.2016 um 12:36 schrieb Carl Eugen Hoyos:
> Hi!
> 
> 2016-08-09 14:15 GMT+02:00 Matthias Hunstock <atze@fem.tu-ilmenau.de>:
>> Enable the MXF muxer to mux baseline H.264 video streams.
> 
> How can I test this / for which command line does this patch make a difference?

A POC should be something like:

ffmpeg -filter_complex "testsrc ; anullsrc" \
-pix_fmt yuv420p -c:v libx264 -profile:v baseline \
-c:a pcm_s16le -ar 48k \
-f mxf /dev/null


Matthias
Carl Eugen Hoyos Aug. 12, 2016, 1:30 p.m. UTC | #4
Hi Matthias!

2016-08-12 14:30 GMT+02:00 Matthias Hunstock <atze@fem.tu-ilmenau.de>:
> Am 12.08.2016 um 12:36 schrieb Carl Eugen Hoyos:

>> How can I test this / for which command line does this patch make a difference?
>
> A POC should be something like:
>
> ffmpeg -filter_complex "testsrc ; anullsrc" \

> -pix_fmt yuv420p -c:v libx264 -profile:v baseline \

Thank you!

Relevant ticket closed, Carl Eugen
Matthias Hunstock Aug. 15, 2016, 7:45 p.m. UTC | #5
Am 12.08.2016 um 15:30 schrieb Carl Eugen Hoyos:

>>> How can I test this / for which command line does this patch make a difference?
>>
>> A POC should be something like:
>>
>> ffmpeg -filter_complex "testsrc ; anullsrc" \
> 
>> -pix_fmt yuv420p -c:v libx264 -profile:v baseline \
> 
> Thank you!
> 
> Relevant ticket closed, Carl Eugen

Hi,

how can I access the sample file of https://trac.ffmpeg.org/ticket/5068 ?

I'd like to add 'main' and 'high' as well, but need some sample files to
double-check the identifiers.


Thanks
Matthias
Carl Eugen Hoyos Aug. 17, 2016, 5:09 a.m. UTC | #6
Hi!

2016-08-15 21:45 GMT+02:00 Matthias Hunstock <atze@fem.tu-ilmenau.de>:
> how can I access the sample file of https://trac.ffmpeg.org/ticket/5068 ?

I don't think I have it.

Sorry, Carl Eugen
diff mbox

Patch

diff --git a/libavformat/mxfenc.c b/libavformat/mxfenc.c
index ffd0bf2..7733ef8 100644
--- a/libavformat/mxfenc.c
+++ b/libavformat/mxfenc.c
@@ -352,6 +352,7 @@  static const uint8_t multiple_desc_ul[]     = { 0x06,0x0E,0x2B,0x34,0x04,0x01,0x
 
 /**
  * SMPTE RP210 http://www.smpte-ra.org/mdd/index.html
+ *             https://smpte-ra.org/sites/default/files/Labels.xml
  */
 static const MXFLocalTagPair mxf_local_tag_batch[] = {
     // preface set
@@ -1822,6 +1823,7 @@  static const struct {
     int profile;
     uint8_t interlaced;
 } mxf_h264_codec_uls[] = {
+    {{ 0x06,0x0E,0x2B,0x34,0x04,0x01,0x01,0x0a,0x04,0x01,0x02,0x02,0x01,0x31,0x11,0x01 },      0,  66, 0 }, // AVC Baseline, Unconstrained Coding
     {{ 0x06,0x0E,0x2B,0x34,0x04,0x01,0x01,0x0a,0x04,0x01,0x02,0x02,0x01,0x32,0x20,0x01 },      0, 110, 0 }, // AVC High 10 Intra
     {{ 0x06,0x0E,0x2B,0x34,0x04,0x01,0x01,0x0a,0x04,0x01,0x02,0x02,0x01,0x32,0x21,0x01 }, 232960,   0, 1 }, // AVC Intra 50 1080i60
     {{ 0x06,0x0E,0x2B,0x34,0x04,0x01,0x01,0x0a,0x04,0x01,0x02,0x02,0x01,0x32,0x21,0x02 }, 281088,   0, 1 }, // AVC Intra 50 1080i50