From patchwork Sat Apr 27 12:59:16 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Niedermayer X-Patchwork-Id: 12924 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id 39CF944980B for ; Sat, 27 Apr 2019 15:59:25 +0300 (EEST) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 23F5A68A62D; Sat, 27 Apr 2019 15:59:25 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [217.70.183.201]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C7AD568A407 for ; Sat, 27 Apr 2019 15:59:18 +0300 (EEST) X-Originating-IP: 213.47.41.20 Received: from localhost (213-47-41-20.cable.dynamic.surfer.at [213.47.41.20]) (Authenticated sender: michael@niedermayer.cc) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 008411BF20A for ; Sat, 27 Apr 2019 12:59:17 +0000 (UTC) Date: Sat, 27 Apr 2019 14:59:16 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20190427125916.GR3501@michaelspb> References: <20190426215821.12388-1-onemda@gmail.com> MIME-Version: 1.0 In-Reply-To: <20190426215821.12388-1-onemda@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Subject: Re: [FFmpeg-devel] [PATCH] avformat/oggdec: improve playback of chained opus file X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" On Fri, Apr 26, 2019 at 11:58:21PM +0200, Paul B Mahol wrote: > Improves decoding of: https://jmvalin.ca/misc_stuff/chain_works.opus > > Signed-off-by: Paul B Mahol > --- > libavformat/oggdec.c | 10 +++++++++- > libavformat/oggdec.h | 1 + > libavformat/oggparseopus.c | 1 + > 3 files changed, 11 insertions(+), 1 deletion(-) this changes the checksum for at 1 fate test Test oggopus-demux failed. Look at tests/data/fate/oggopus-demux.err for details. make: *** [fate-oggopus-demux] Error 1 [...] --- ./tests/ref/fate/oggopus-demux 2019-04-22 01:26:50.179027580 +0200 +++ tests/data/fate/oggopus-demux 2019-04-27 14:15:21.585470907 +0200 @@ -5,7 +5,7 @@ #sample_rate 0: 48000 #channel_layout 0: 3 #channel_layout_name 0: stereo -0, -356, -356, 960, 402, 0x89b1c40f +0, -356, -356, 960, 402, 0x89b1c40f, S=1, 10, 0x03f10065 0, 604, 604, 960, 216, 0x7bf97146 0, 1564, 1564, 960, 215, 0x6cb86d8b 0, 2524, 2524, 960, 218, 0x9cfd691c