diff mbox

[FFmpeg-devel,3/6] lavc/bink: Remove the dead code block

Message ID 1557504354-27086-3-git-send-email-mypopydev@gmail.com
State Accepted
Commit 3af73f2c8588283dfaa41cf4465f8fc40549f233
Headers show

Commit Message

Jun Zhao May 10, 2019, 4:05 p.m. UTC 
From: Jun Zhao <barryjzhao@tencent.com>

Remove the dead code block

Signed-off-by: Jun Zhao <barryjzhao@tencent.com>
---
 libavcodec/bink.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

Comments

Peter Ross May 11, 2019, 3:04 a.m. UTC | #1 
On Sat, May 11, 2019 at 12:05:51AM +0800, Jun Zhao wrote:
> From: Jun Zhao <barryjzhao@tencent.com>
> 
> Remove the dead code block
> 
> Signed-off-by: Jun Zhao <barryjzhao@tencent.com>
> ---
>  libavcodec/bink.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/libavcodec/bink.c b/libavcodec/bink.c
> index 6673afa..d0f1b39 100644
> --- a/libavcodec/bink.c
> +++ b/libavcodec/bink.c
> @@ -1046,8 +1046,6 @@ static int bink_decode_plane(BinkContext *c, AVFrame *frame, GetBitContext *gb,
>          if ((ret = read_runs(c->avctx, gb, &c->bundle[BINK_SRC_RUN])) < 0)
>              return ret;
>  
> -        if (by == bh)
> -            break;
>          dst  = frame->data[plane_idx]  + 8*by*stride;
>          prev = (c->last->data[plane_idx] ? c->last->data[plane_idx]
>                                           : frame->data[plane_idx]) + 8*by*stride;
> -- 
> 1.7.1

looks good. please apply.

-- Peter
(A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B)
mypopy@gmail.com May 13, 2019, 1:34 a.m. UTC | #2 
On Sat, May 11, 2019 at 11:04 AM Peter Ross <pross@xvid.org> wrote:
>
> On Sat, May 11, 2019 at 12:05:51AM +0800, Jun Zhao wrote:
> > From: Jun Zhao <barryjzhao@tencent.com>
> >
> > Remove the dead code block
> >
> > Signed-off-by: Jun Zhao <barryjzhao@tencent.com>
> > ---
> >  libavcodec/bink.c |    2 --
> >  1 files changed, 0 insertions(+), 2 deletions(-)
> >
> > diff --git a/libavcodec/bink.c b/libavcodec/bink.c
> > index 6673afa..d0f1b39 100644
> > --- a/libavcodec/bink.c
> > +++ b/libavcodec/bink.c
> > @@ -1046,8 +1046,6 @@ static int bink_decode_plane(BinkContext *c, AVFrame *frame, GetBitContext *gb,
> >          if ((ret = read_runs(c->avctx, gb, &c->bundle[BINK_SRC_RUN])) < 0)
> >              return ret;
> >
> > -        if (by == bh)
> > -            break;
> >          dst  = frame->data[plane_idx]  + 8*by*stride;
> >          prev = (c->last->data[plane_idx] ? c->last->data[plane_idx]
> >                                           : frame->data[plane_idx]) + 8*by*stride;
> > --
> > 1.7.1
>
> looks good. please apply.
>
> -- Peter
> (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B)
Pushed, Thanks
diff mbox

Patch

diff --git a/libavcodec/bink.c b/libavcodec/bink.c
index 6673afa..d0f1b39 100644
--- a/libavcodec/bink.c
+++ b/libavcodec/bink.c
@@ -1046,8 +1046,6 @@  static int bink_decode_plane(BinkContext *c, AVFrame *frame, GetBitContext *gb,
         if ((ret = read_runs(c->avctx, gb, &c->bundle[BINK_SRC_RUN])) < 0)
             return ret;
 
-        if (by == bh)
-            break;
         dst  = frame->data[plane_idx]  + 8*by*stride;
         prev = (c->last->data[plane_idx] ? c->last->data[plane_idx]
                                          : frame->data[plane_idx]) + 8*by*stride;