diff mbox

[FFmpeg-devel] avutil/tx: should check against (*ctx)

Message ID 20190516044736.25515-1-ruiling.song@intel.com
State Accepted
Commit 65646db8e8d5aa95ef8282823fdf5ec1a5f3df69
Headers show

Commit Message

Ruiling Song May 16, 2019, 4:47 a.m. UTC 
ctx is a pointer to pointer here.

Signed-off-by: Ruiling Song <ruiling.song@intel.com>
---
 libavutil/tx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

James Almer May 16, 2019, 3:57 a.m. UTC | #1 
On 5/16/2019 1:47 AM, Ruiling Song wrote:
> ctx is a pointer to pointer here.
> 
> Signed-off-by: Ruiling Song <ruiling.song@intel.com>
> ---
>  libavutil/tx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavutil/tx.c b/libavutil/tx.c
> index 934ef27c81..2bf4aa1c28 100644
> --- a/libavutil/tx.c
> +++ b/libavutil/tx.c
> @@ -697,7 +697,7 @@ static int gen_mdct_exptab(AVTXContext *s, int len4, double scale)
>  
>  av_cold void av_tx_uninit(AVTXContext **ctx)
>  {
> -    if (!ctx)
> +    if (!(*ctx))

It should actually check for both, ctx and *ctx.

>          return;
>  
>      av_free((*ctx)->pfatab);
>
diff mbox

Patch

diff --git a/libavutil/tx.c b/libavutil/tx.c
index 934ef27c81..2bf4aa1c28 100644
--- a/libavutil/tx.c
+++ b/libavutil/tx.c
@@ -697,7 +697,7 @@  static int gen_mdct_exptab(AVTXContext *s, int len4, double scale)
 
 av_cold void av_tx_uninit(AVTXContext **ctx)
 {
-    if (!ctx)
+    if (!(*ctx))
         return;
 
     av_free((*ctx)->pfatab);