[FFmpeg-devel,v2] doc/filters: add the sr filter model generation scripts new repository link

Submitted by Steven Liu on May 16, 2019, 5:43 a.m.

Details

Message ID 20190516054305.13098-1-lq@chinaffmpeg.org
State New
Headers show

Commit Message

Steven Liu May 16, 2019, 5:43 a.m.
Hold on the old repository link and mention new repository link  development continues

Signed-off-by: Steven Liu <lq@chinaffmpeg.org>
---
 doc/filters.texi | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Gyan May 16, 2019, 6:57 p.m.
On 16-05-2019 11:13 AM, Steven Liu wrote:
> Hold on the old repository link and mention new repository link  development continues
>
> Signed-off-by: Steven Liu <lq@chinaffmpeg.org>
> ---
>   doc/filters.texi | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/doc/filters.texi b/doc/filters.texi
> index 38c70bf674..2e9db150f2 100644
> --- a/doc/filters.texi
> +++ b/doc/filters.texi
> @@ -16538,7 +16538,8 @@ See @url{https://arxiv.org/abs/1609.05158}.
>   @end itemize
>   
>   Training scripts as well as scripts for model generation are provided in
> -the repository at @url{https://github.com/HighVoltageRocknRoll/sr.git}.
> +the repository at @url{https://github.com/HighVoltageRocknRoll/sr.git}(have stop maintaince)
> +or @url{https://github.com/XueweiMeng/sr/tree/sr_dnn_native}(development continues).
>   
>   The filter accepts the following options:
>   
Made some changes and pushed as 6044534964a463663803b590fe66a212af4b3834

Thanks,
Gyan
Steven Liu May 16, 2019, 9:44 p.m.
> 在 2019年5月17日,02:57,Gyan <ffmpeg@gyani.pro> 写道:
> 
> 
> 
> On 16-05-2019 11:13 AM, Steven Liu wrote:
>> Hold on the old repository link and mention new repository link  development continues
>> 
>> Signed-off-by: Steven Liu <lq@chinaffmpeg.org>
>> ---
>>  doc/filters.texi | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>> 
>> diff --git a/doc/filters.texi b/doc/filters.texi
>> index 38c70bf674..2e9db150f2 100644
>> --- a/doc/filters.texi
>> +++ b/doc/filters.texi
>> @@ -16538,7 +16538,8 @@ See @url{https://arxiv.org/abs/1609.05158}.
>>  @end itemize
>>    Training scripts as well as scripts for model generation are provided in
>> -the repository at @url{https://github.com/HighVoltageRocknRoll/sr.git}.
>> +the repository at @url{https://github.com/HighVoltageRocknRoll/sr.git}(have stop maintaince)
>> +or @url{https://github.com/XueweiMeng/sr/tree/sr_dnn_native}(development continues).
>>    The filter accepts the following options:
>>  
> Made some changes and pushed as 6044534964a463663803b590fe66a212af4b3834

I think you can review and comment the patch, then i can modify it.
but i don’t think you just leave a message is good:

“
commit c2771bbf815bd7d0ff273ba590b7db02a303399f
Author: Gyan Doshi <ffmpeg@gyani.pro>
Date:   Fri May 17 00:22:04 2019 +0530

    doc/filters: update URL for sr filter script repository

    Thanks to Steven Liu for the update.

“


> 
> Thanks,
> Gyan
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Thanks
Steven
Gyan May 17, 2019, 4:46 a.m.
On 17-05-2019 03:14 AM, Steven Liu wrote:
>
>> 在 2019年5月17日,02:57,Gyan <ffmpeg@gyani.pro> 写道:
>>
>>
>>
>> On 16-05-2019 11:13 AM, Steven Liu wrote:
>>> Hold on the old repository link and mention new repository link  development continues
>>>
>>> Signed-off-by: Steven Liu <lq@chinaffmpeg.org>
>>> ---
>>>   doc/filters.texi | 3 ++-
>>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/doc/filters.texi b/doc/filters.texi
>>> index 38c70bf674..2e9db150f2 100644
>>> --- a/doc/filters.texi
>>> +++ b/doc/filters.texi
>>> @@ -16538,7 +16538,8 @@ See @url{https://arxiv.org/abs/1609.05158}.
>>>   @end itemize
>>>     Training scripts as well as scripts for model generation are provided in
>>> -the repository at @url{https://github.com/HighVoltageRocknRoll/sr.git}.
>>> +the repository at @url{https://github.com/HighVoltageRocknRoll/sr.git}(have stop maintaince)
>>> +or @url{https://github.com/XueweiMeng/sr/tree/sr_dnn_native}(development continues).
>>>     The filter accepts the following options:
>>>   
>> Made some changes and pushed as 6044534964a463663803b590fe66a212af4b3834
> I think you can review and comment the patch, then i can modify it.
> but i don’t think you just leave a message is good:
>
> “
> commit c2771bbf815bd7d0ff273ba590b7db02a303399f
> Author: Gyan Doshi <ffmpeg@gyani.pro>
> Date:   Fri May 17 00:22:04 2019 +0530
>
>      doc/filters: update URL for sr filter script repository
>
>      Thanks to Steven Liu for the update.
>
> “

It's a simple URL update for which I had to rewrite the prose, so 
maintaining authorship didn't make sense. You should have posted a 
message - not reverted and especially not pushed.

Gyan
Steven Liu May 17, 2019, 5:06 a.m.
> 在 2019年5月17日,下午12:46,Gyan <ffmpeg@gyani.pro> 写道:
> 
> 
> 
> On 17-05-2019 03:14 AM, Steven Liu wrote:
>> 
>>> 在 2019年5月17日,02:57,Gyan <ffmpeg@gyani.pro> 写道:
>>> 
>>> 
>>> 
>>> On 16-05-2019 11:13 AM, Steven Liu wrote:
>>>> Hold on the old repository link and mention new repository link  development continues
>>>> 
>>>> Signed-off-by: Steven Liu <lq@chinaffmpeg.org>
>>>> ---
>>>>  doc/filters.texi | 3 ++-
>>>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>>> 
>>>> diff --git a/doc/filters.texi b/doc/filters.texi
>>>> index 38c70bf674..2e9db150f2 100644
>>>> --- a/doc/filters.texi
>>>> +++ b/doc/filters.texi
>>>> @@ -16538,7 +16538,8 @@ See @url{https://arxiv.org/abs/1609.05158}.
>>>>  @end itemize
>>>>    Training scripts as well as scripts for model generation are provided in
>>>> -the repository at @url{https://github.com/HighVoltageRocknRoll/sr.git}.
>>>> +the repository at @url{https://github.com/HighVoltageRocknRoll/sr.git}(have stop maintaince)
>>>> +or @url{https://github.com/XueweiMeng/sr/tree/sr_dnn_native}(development continues).
>>>>    The filter accepts the following options:
>>>>  
>>> Made some changes and pushed as 6044534964a463663803b590fe66a212af4b3834
>> I think you can review and comment the patch, then i can modify it.
>> but i don’t think you just leave a message is good:
>> 
>> “
>> commit c2771bbf815bd7d0ff273ba590b7db02a303399f
>> Author: Gyan Doshi <ffmpeg@gyani.pro>
>> Date:   Fri May 17 00:22:04 2019 +0530
>> 
>>     doc/filters: update URL for sr filter script repository
>> 
>>     Thanks to Steven Liu for the update.
>> 
>> “
> 
> It's a simple URL update for which I had to rewrite the prose, so maintaining authorship didn't make sense.
No, I’m the patch Author, not simple or complex, you have change the author infomation to you, that is wrong. you can comment or tick me to change it.
And the new URL is Xuewei’s github, I can take responsibility for this change, the change will continue the DNN native, it means the DNN native will supprt not only SR, also support derain.

> You should have posted a message - not reverted and especially not pushed.
I do that same as you, and Simple Change. If you don’t change the Author infomation, i would not revert that.

Even you are the mainatiner of the Documentations, but I don’t think you should change any author info of the patches.

Thanks

Steven
Gyan May 17, 2019, 5:20 a.m.
On 17-05-2019 10:36 AM, Liu Steven wrote:
>
>> 在 2019年5月17日,下午12:46,Gyan <ffmpeg@gyani.pro> 写道:
>>
>>
>>
>> On 17-05-2019 03:14 AM, Steven Liu wrote:
>>>> 在 2019年5月17日,02:57,Gyan <ffmpeg@gyani.pro> 写道:
>>>>
>>>>
>>>>
>>>> On 16-05-2019 11:13 AM, Steven Liu wrote:
>>>>> Hold on the old repository link and mention new repository link  development continues
>>>>>
>>>>> Signed-off-by: Steven Liu <lq@chinaffmpeg.org>
>>>>> ---
>>>>>   doc/filters.texi | 3 ++-
>>>>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>>>>
>>>>> diff --git a/doc/filters.texi b/doc/filters.texi
>>>>> index 38c70bf674..2e9db150f2 100644
>>>>> --- a/doc/filters.texi
>>>>> +++ b/doc/filters.texi
>>>>> @@ -16538,7 +16538,8 @@ See @url{https://arxiv.org/abs/1609.05158}.
>>>>>   @end itemize
>>>>>     Training scripts as well as scripts for model generation are provided in
>>>>> -the repository at @url{https://github.com/HighVoltageRocknRoll/sr.git}.
>>>>> +the repository at @url{https://github.com/HighVoltageRocknRoll/sr.git}(have stop maintaince)
>>>>> +or @url{https://github.com/XueweiMeng/sr/tree/sr_dnn_native}(development continues).
>>>>>     The filter accepts the following options:
>>>>>   
>>>> Made some changes and pushed as 6044534964a463663803b590fe66a212af4b3834
>>> I think you can review and comment the patch, then i can modify it.
>>> but i don’t think you just leave a message is good:
>>>
>>> “
>>> commit c2771bbf815bd7d0ff273ba590b7db02a303399f
>>> Author: Gyan Doshi <ffmpeg@gyani.pro>
>>> Date:   Fri May 17 00:22:04 2019 +0530
>>>
>>>      doc/filters: update URL for sr filter script repository
>>>
>>>      Thanks to Steven Liu for the update.
>>>
>>> “
>> It's a simple URL update for which I had to rewrite the prose, so maintaining authorship didn't make sense.
> No, I’m the patch Author, not simple or complex, you have change the author infomation to you, that is wrong. you can comment or tick me to change it.
> And the new URL is Xuewei’s github, I can take responsibility for this change, the change will continue the DNN native, it means the DNN native will supprt not only SR, also support derain.
>
>> You should have posted a message - not reverted and especially not pushed.
> I do that same as you, and Simple Change. If you don’t change the Author infomation, i would not revert that.
>
> Even you are the mainatiner of the Documentations, but I don’t think you should change any author info of the patches.

Consider your patch NAKed. I created a new patch with new prose. I used 
the URL you provided for which you were credited.

I'm not going to waste any more time on this.

Gyan
Steven Liu May 17, 2019, 5:29 a.m.
> 在 2019年5月17日,下午1:20,Gyan <ffmpeg@gyani.pro> 写道:
> 
> 
> 
> On 17-05-2019 10:36 AM, Liu Steven wrote:
>> 
>>> 在 2019年5月17日,下午12:46,Gyan <ffmpeg@gyani.pro> 写道:
>>> 
>>> 
>>> 
>>> On 17-05-2019 03:14 AM, Steven Liu wrote:
>>>>> 在 2019年5月17日,02:57,Gyan <ffmpeg@gyani.pro> 写道:
>>>>> 
>>>>> 
>>>>> 
>>>>> On 16-05-2019 11:13 AM, Steven Liu wrote:
>>>>>> Hold on the old repository link and mention new repository link  development continues
>>>>>> 
>>>>>> Signed-off-by: Steven Liu <lq@chinaffmpeg.org>
>>>>>> ---
>>>>>>  doc/filters.texi | 3 ++-
>>>>>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>>>>> 
>>>>>> diff --git a/doc/filters.texi b/doc/filters.texi
>>>>>> index 38c70bf674..2e9db150f2 100644
>>>>>> --- a/doc/filters.texi
>>>>>> +++ b/doc/filters.texi
>>>>>> @@ -16538,7 +16538,8 @@ See @url{https://arxiv.org/abs/1609.05158}.
>>>>>>  @end itemize
>>>>>>    Training scripts as well as scripts for model generation are provided in
>>>>>> -the repository at @url{https://github.com/HighVoltageRocknRoll/sr.git}.
>>>>>> +the repository at @url{https://github.com/HighVoltageRocknRoll/sr.git}(have stop maintaince)
>>>>>> +or @url{https://github.com/XueweiMeng/sr/tree/sr_dnn_native}(development continues).
>>>>>>    The filter accepts the following options:
>>>>>>  
>>>>> Made some changes and pushed as 6044534964a463663803b590fe66a212af4b3834
>>>> I think you can review and comment the patch, then i can modify it.
>>>> but i don’t think you just leave a message is good:
>>>> 
>>>> “
>>>> commit c2771bbf815bd7d0ff273ba590b7db02a303399f
>>>> Author: Gyan Doshi <ffmpeg@gyani.pro>
>>>> Date:   Fri May 17 00:22:04 2019 +0530
>>>> 
>>>>     doc/filters: update URL for sr filter script repository
>>>> 
>>>>     Thanks to Steven Liu for the update.
>>>> 
>>>> “
>>> It's a simple URL update for which I had to rewrite the prose, so maintaining authorship didn't make sense.
>> No, I’m the patch Author, not simple or complex, you have change the author infomation to you, that is wrong. you can comment or tick me to change it.
>> And the new URL is Xuewei’s github, I can take responsibility for this change, the change will continue the DNN native, it means the DNN native will supprt not only SR, also support derain.
>> 
>>> You should have posted a message - not reverted and especially not pushed.
>> I do that same as you, and Simple Change. If you don’t change the Author infomation, i would not revert that.
>> 
>> Even you are the mainatiner of the Documentations, but I don’t think you should change any author info of the patches.
> 
> Consider your patch NAKed. I created a new patch with new prose. I used the URL you provided for which you were credited.
I don’t want waste my time on this too. NAK
> 
> I'm not going to waste any more time on this.
> 
> Gyan
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Patch hide | download patch | download mbox

diff --git a/doc/filters.texi b/doc/filters.texi
index 38c70bf674..2e9db150f2 100644
--- a/doc/filters.texi
+++ b/doc/filters.texi
@@ -16538,7 +16538,8 @@  See @url{https://arxiv.org/abs/1609.05158}.
 @end itemize
 
 Training scripts as well as scripts for model generation are provided in
-the repository at @url{https://github.com/HighVoltageRocknRoll/sr.git}.
+the repository at @url{https://github.com/HighVoltageRocknRoll/sr.git}(have stop maintaince)
+or @url{https://github.com/XueweiMeng/sr/tree/sr_dnn_native}(development continues).
 
 The filter accepts the following options: