diff mbox

[FFmpeg-devel,v2,01/11] cbs: Mention all codecs in unit type comment

Message ID 20190520230224.19221-1-sw@jkqxz.net
State Superseded
Headers show

Commit Message

Mark Thompson May 20, 2019, 11:02 p.m. UTC 
---
 libavcodec/cbs.h | 2 ++
 1 file changed, 2 insertions(+)

Comments

Jun Zhao May 21, 2019, 2 a.m. UTC | #1 
On Tue, May 21, 2019 at 7:02 AM Mark Thompson <sw@jkqxz.net> wrote:
>
> ---
>  libavcodec/cbs.h | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/libavcodec/cbs.h b/libavcodec/cbs.h
> index 967dcd1468..e8b2d41ecb 100644
> --- a/libavcodec/cbs.h
> +++ b/libavcodec/cbs.h
> @@ -49,6 +49,8 @@ struct CodedBitstreamType;
>   * H.265 / HEVC: nal_unit_type
>   * MPEG-2: start code value (without prefix)
>   * VP9: unused, set to zero (every unit is a frame)
> + * JPEG: marker value (without 0xff prefix)
> + * AV1: obu_type
>   */
>  typedef uint32_t CodedBitstreamUnitType;
>

LGTM
James Almer May 21, 2019, 3:36 a.m. UTC | #2 
On 5/20/2019 8:02 PM, Mark Thompson wrote:
> ---
>  libavcodec/cbs.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/libavcodec/cbs.h b/libavcodec/cbs.h
> index 967dcd1468..e8b2d41ecb 100644
> --- a/libavcodec/cbs.h
> +++ b/libavcodec/cbs.h
> @@ -49,6 +49,8 @@ struct CodedBitstreamType;
>   * H.265 / HEVC: nal_unit_type
>   * MPEG-2: start code value (without prefix)
>   * VP9: unused, set to zero (every unit is a frame)
> + * JPEG: marker value (without 0xff prefix)
> + * AV1: obu_type

Nit: Before this patch the list was in alphabetical order.

LGTM with or without addressing that.

>   */
>  typedef uint32_t CodedBitstreamUnitType;
>  
>
diff mbox

Patch

diff --git a/libavcodec/cbs.h b/libavcodec/cbs.h
index 967dcd1468..e8b2d41ecb 100644
--- a/libavcodec/cbs.h
+++ b/libavcodec/cbs.h
@@ -49,6 +49,8 @@  struct CodedBitstreamType;
  * H.265 / HEVC: nal_unit_type
  * MPEG-2: start code value (without prefix)
  * VP9: unused, set to zero (every unit is a frame)
+ * JPEG: marker value (without 0xff prefix)
+ * AV1: obu_type
  */
 typedef uint32_t CodedBitstreamUnitType;