[FFmpeg-devel,2/2] avcodec/scpr3: fix checking ret value of decode_run_i

Submitted by Marton Balint on May 23, 2019, 8:01 p.m.

Details

Message ID 20190523200101.15587-2-cus@passwd.hu
State Accepted
Commit f811ac52284a01e32143d9ff4eec044254725a09
Headers show

Commit Message

Marton Balint May 23, 2019, 8:01 p.m.
Fixes Coverity CID 1441461.

Signed-off-by: Marton Balint <cus@passwd.hu>
---
 libavcodec/scpr3.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Paul B Mahol May 23, 2019, 8:17 p.m.
On 5/23/19, Marton Balint <cus@passwd.hu> wrote:
> Fixes Coverity CID 1441461.
>
> Signed-off-by: Marton Balint <cus@passwd.hu>
> ---
>  libavcodec/scpr3.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavcodec/scpr3.c b/libavcodec/scpr3.c
> index 5cfad9f4d2..b4d2e21a17 100644
> --- a/libavcodec/scpr3.c
> +++ b/libavcodec/scpr3.c
> @@ -1007,7 +1007,7 @@ static int decompress_i3(AVCodecContext *avctx,
> uint32_t *dst, int linesize)
>          ret = decode_run_i(avctx, ptype, run, &x, &y, clr,
>                             dst, linesize, &lx, &ly,
>                             backstep, off, &cx, &cx1);
> -        if (run < 0)
> +        if (ret < 0)
>              return ret;
>      }
>

OK

> --
> 2.16.4
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Patch hide | download patch | download mbox

diff --git a/libavcodec/scpr3.c b/libavcodec/scpr3.c
index 5cfad9f4d2..b4d2e21a17 100644
--- a/libavcodec/scpr3.c
+++ b/libavcodec/scpr3.c
@@ -1007,7 +1007,7 @@  static int decompress_i3(AVCodecContext *avctx, uint32_t *dst, int linesize)
         ret = decode_run_i(avctx, ptype, run, &x, &y, clr,
                            dst, linesize, &lx, &ly,
                            backstep, off, &cx, &cx1);
-        if (run < 0)
+        if (ret < 0)
             return ret;
     }