From patchwork Wed May 29 04:59:40 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jun Li X-Patchwork-Id: 13319 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id AD76F448E91 for ; Wed, 29 May 2019 07:59:57 +0300 (EEST) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 89B1D689BE0; Wed, 29 May 2019 07:59:57 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A4A856802BD for ; Wed, 29 May 2019 07:59:50 +0300 (EEST) Received: by mail-pf1-f177.google.com with SMTP id g9so777374pfo.11 for ; Tue, 28 May 2019 21:59:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:in-reply-to:references; bh=xgpnUcBuzALxHRjbV5NgQ/KQTGe7WjJF12wUQjtup6c=; b=MUImfkZnw5AEGaQJ9hzPBR1SuMe/jQlzVqJpFCCijOPQd+j2P5LcXTXQZ3pJ0wSjUC L9mRAu8lgjQwUn3j2NeZys7dgUSvNkYcHUrTFW8rzaxbPga+KFVFdKFW3LgU/2U4BAlo kUTPgHGxuIgfErOwZaQ1fGcipXi0zariOns+htuXSDz11sM5uo1XVLzfprr0tWOlIqWp NrX3wIQFfI79AjmU/3RXfvwDTuCvMo32uaVwSQoSKebEDFXnEdcGfHV6NjbrqZhXk+M1 O8OXgzY8+vRoxqdKo8fQIu/H4q2v6Cn6YyWW4PRmHBuhqch9D1krGcXXlfeZ9gJAYzIY Rkwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=xgpnUcBuzALxHRjbV5NgQ/KQTGe7WjJF12wUQjtup6c=; b=rjaAl6xxmg9njKCtmm8OkO7Bs8m0RuAv67RnWnTfO5PaJ8JG2qrysWTVOP6hp8zck0 OFYebYxvkufMUzl+P0fN1V0/c9yKhDF+KONgCiVDnQrcSkDaFeJ7hIZWNgjo7bW1NfuN BMQdQH3xpZjhJ0Li9D1AVu7qKUNBBOz0N3EfplKgHKA65Tdxw87Oua+UqTtF4eq0J3I0 /FChxUVPM+ZlYiPf/wRQ8idUKfglekYB5xGRHYFquHidkWgRqFbuZ/OsU3Sqx5P6jf5f ajokNht4A05kzSHN+Jev4zfcUJWnb3DJXDn3/mVkbTLE23e7gA/KGDgd3HMGyqQ4j8KI E8ww== X-Gm-Message-State: APjAAAXau7JWbaWdO99DwWfx6SwXUDdrv9TsriQH4VFLCncjcikkQR8e d9r9Fzo11djHP0vZMRYJkzxrMAHA X-Google-Smtp-Source: APXvYqyiygbxyOANBx098gyr5FS+0qbvhNEaacpBOMXOUUpoD/7xOLpT4e8OyZffwmAmuXreHsFs+w== X-Received: by 2002:a17:90a:2946:: with SMTP id x6mr9812752pjf.133.1559105988318; Tue, 28 May 2019 21:59:48 -0700 (PDT) Received: from jun-ubuntu.corp.microsoft.com ([2001:4898:80e8:7:f7ca:c45e:a7ce:5d49]) by smtp.googlemail.com with ESMTPSA id i9sm4645468pjd.29.2019.05.28.21.59.47 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 28 May 2019 21:59:47 -0700 (PDT) From: Jun Li To: ffmpeg-devel@ffmpeg.org Date: Tue, 28 May 2019 21:59:40 -0700 Message-Id: <20190529045940.10198-2-junli1026@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190529045940.10198-1-junli1026@gmail.com> References: <20190529045940.10198-1-junli1026@gmail.com> Subject: [FFmpeg-devel] [PATCH v4 2/2] fftools/ffmpeg: add exif orientation support per frame's metadata X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Fix #6945 Rotate or/and flip frame according to frame's metadata orientation --- fftools/ffmpeg.c | 16 +++++++++++++++- fftools/ffmpeg.h | 3 ++- fftools/ffmpeg_filter.c | 28 +++++++++++++++++++++++----- 3 files changed, 40 insertions(+), 7 deletions(-) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index 01f04103cf..2f4229a9d0 100644 --- a/fftools/ffmpeg.c +++ b/fftools/ffmpeg.c @@ -2126,6 +2126,19 @@ static int ifilter_has_all_input_formats(FilterGraph *fg) return 1; } +static int orientation_need_update(InputFilter *ifilter, AVFrame *frame) +{ + int orientaion = get_frame_orientation(frame); + int filterst = ifilter->orientation <= 1 ? 0 : // not set + ifilter->orientation <= 4 ? 1 : // auto flip + 2; // auto transpose + int framest = orientaion <= 1 ? 0 : // not set + orientaion <= 4 ? 1 : // auto flip + 2; // auto transpose + + return filterst != framest; +} + static int ifilter_send_frame(InputFilter *ifilter, AVFrame *frame) { FilterGraph *fg = ifilter->graph; @@ -2142,7 +2155,8 @@ static int ifilter_send_frame(InputFilter *ifilter, AVFrame *frame) break; case AVMEDIA_TYPE_VIDEO: need_reinit |= ifilter->width != frame->width || - ifilter->height != frame->height; + ifilter->height != frame->height || + orientation_need_update(ifilter, frame); break; } diff --git a/fftools/ffmpeg.h b/fftools/ffmpeg.h index eb1eaf6363..54532ef0eb 100644 --- a/fftools/ffmpeg.h +++ b/fftools/ffmpeg.h @@ -244,7 +244,7 @@ typedef struct InputFilter { // parameters configured for this input int format; - int width, height; + int width, height, orientation; AVRational sample_aspect_ratio; int sample_rate; @@ -649,6 +649,7 @@ int init_complex_filtergraph(FilterGraph *fg); void sub2video_update(InputStream *ist, AVSubtitle *sub); int ifilter_parameters_from_frame(InputFilter *ifilter, const AVFrame *frame); +int get_frame_orientation(const AVFrame* frame); int ffmpeg_parse_options(int argc, char **argv); diff --git a/fftools/ffmpeg_filter.c b/fftools/ffmpeg_filter.c index 72838de1e2..1fcadb1871 100644 --- a/fftools/ffmpeg_filter.c +++ b/fftools/ffmpeg_filter.c @@ -743,6 +743,18 @@ static int sub2video_prepare(InputStream *ist, InputFilter *ifilter) return 0; } +int get_frame_orientation(const AVFrame *frame) +{ + AVDictionaryEntry *entry = NULL; + int orientation = 0; + + // read exif orientation data + entry = av_dict_get(frame->metadata, "Orientation", NULL, 0); + if (entry && entry->value) + orientation = atoi(entry->value); + return orientation; +} + static int configure_input_video_filter(FilterGraph *fg, InputFilter *ifilter, AVFilterInOut *in) { @@ -809,13 +821,18 @@ static int configure_input_video_filter(FilterGraph *fg, InputFilter *ifilter, if (ist->autorotate) { double theta = get_rotation(ist->st); - if (fabs(theta - 90) < 1.0) { + if (fabs(theta) < 1.0) { // no rotation info in stream meta + if (ifilter->orientation < 0 || ifilter->orientation > 8) { + av_log(NULL, AV_LOG_ERROR, "Invalid frame orientation: %i\n", ifilter->orientation); + } else if (ifilter->orientation > 1 && ifilter->orientation <= 4) { // skip 0 (not set) and 1 (orientaion 'Normal') + ret = insert_filter(&last_filter, &pad_idx, "transpose", "orientation=auto_flip"); + } else if (ifilter->orientation > 4) { + ret = insert_filter(&last_filter, &pad_idx, "transpose", "orientation=auto_transpose"); + } + } else if (fabs(theta - 90) < 1.0) { ret = insert_filter(&last_filter, &pad_idx, "transpose", "clock"); } else if (fabs(theta - 180) < 1.0) { - ret = insert_filter(&last_filter, &pad_idx, "hflip", NULL); - if (ret < 0) - return ret; - ret = insert_filter(&last_filter, &pad_idx, "vflip", NULL); + ret = insert_filter(&last_filter, &pad_idx, "transpose", "orientation=rotate180"); } else if (fabs(theta - 270) < 1.0) { ret = insert_filter(&last_filter, &pad_idx, "transpose", "cclock"); } else if (fabs(theta) > 1.0) { @@ -1191,6 +1208,7 @@ int ifilter_parameters_from_frame(InputFilter *ifilter, const AVFrame *frame) ifilter->width = frame->width; ifilter->height = frame->height; ifilter->sample_aspect_ratio = frame->sample_aspect_ratio; + ifilter->orientation = get_frame_orientation(frame); ifilter->sample_rate = frame->sample_rate; ifilter->channels = frame->channels;