[FFmpeg-devel] avformat/id3v2enc: write CTOC too

Submitted by Michael Niedermayer on June 6, 2019, 10:24 a.m.

Details

Message ID 20190606102413.GJ3118@michaelspb
State New
Headers show

Commit Message

Michael Niedermayer June 6, 2019, 10:24 a.m.
On Thu, Jun 06, 2019 at 09:08:48AM +0200, Paul B Mahol wrote:
> On 6/5/19, Michael Niedermayer <michael@niedermayer.cc> wrote:
> > On Tue, Jun 04, 2019 at 04:45:38PM +0200, Paul B Mahol wrote:
> >> Signed-off-by: Paul B Mahol <onemda@gmail.com>
> >> ---
> >>  libavformat/id3v2enc.c | 36 ++++++++++++++++++++++++++++++++++++
> >>  1 file changed, 36 insertions(+)
> >
> > if this is written in a fate test then it will need an update
> > (this patch as it is ATM does write it in fate-lavf-fate-mp3)
> >
> 
> What are you talking about? No tests need update for fate.

Test lavf-fate-mp3 failed. Look at tests/data/fate/lavf-fate-mp3.err for details.
make: *** [fate-lavf-fate-mp3] Error 1
make: *** Waiting for unfinished jobs....


[...]

Comments

Paul B Mahol June 6, 2019, 10:28 a.m.
On 6/6/19, Michael Niedermayer <michael@niedermayer.cc> wrote:
> On Thu, Jun 06, 2019 at 09:08:48AM +0200, Paul B Mahol wrote:
>> On 6/5/19, Michael Niedermayer <michael@niedermayer.cc> wrote:
>> > On Tue, Jun 04, 2019 at 04:45:38PM +0200, Paul B Mahol wrote:
>> >> Signed-off-by: Paul B Mahol <onemda@gmail.com>
>> >> ---
>> >>  libavformat/id3v2enc.c | 36 ++++++++++++++++++++++++++++++++++++
>> >>  1 file changed, 36 insertions(+)
>> >
>> > if this is written in a fate test then it will need an update
>> > (this patch as it is ATM does write it in fate-lavf-fate-mp3)
>> >
>>
>> What are you talking about? No tests need update for fate.
>
> --- ./tests/ref/lavf-fate/mp3	2019-06-04 00:17:28.266942595 +0200
> +++ tests/data/fate/lavf-fate-mp3	2019-06-06 11:01:19.501329747 +0200
> @@ -1,3 +1,3 @@
> -f231c5316357fd747573cbcb02f889c5 *tests/data/lavf-fate/lavf.mp3
> -96016 tests/data/lavf-fate/lavf.mp3
> +4c47e0589cc3a0c415d1def532c7f34d *tests/data/lavf-fate/lavf.mp3
> +96033 tests/data/lavf-fate/lavf.mp3
>  tests/data/lavf-fate/lavf.mp3 CRC=0x6c9850fe
> Test lavf-fate-mp3 failed. Look at tests/data/fate/lavf-fate-mp3.err for
> details.
> make: *** [fate-lavf-fate-mp3] Error 1
> make: *** Waiting for unfinished jobs....
>
>

Thats with this old patch, where ctoc is written even when not needed.

> [...]
>
> --
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> "I am not trying to be anyone's saviour, I'm trying to think about the
>  future and not be sad" - Elon Musk
>
>

Patch hide | download patch | download mbox

--- ./tests/ref/lavf-fate/mp3	2019-06-04 00:17:28.266942595 +0200
+++ tests/data/fate/lavf-fate-mp3	2019-06-06 11:01:19.501329747 +0200
@@ -1,3 +1,3 @@ 
-f231c5316357fd747573cbcb02f889c5 *tests/data/lavf-fate/lavf.mp3
-96016 tests/data/lavf-fate/lavf.mp3
+4c47e0589cc3a0c415d1def532c7f34d *tests/data/lavf-fate/lavf.mp3
+96033 tests/data/lavf-fate/lavf.mp3
 tests/data/lavf-fate/lavf.mp3 CRC=0x6c9850fe