From patchwork Thu Jun 6 10:24:13 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Niedermayer X-Patchwork-Id: 13436 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id E89B7449A78 for ; Thu, 6 Jun 2019 13:24:26 +0300 (EEST) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id CFF6E68A723; Thu, 6 Jun 2019 13:24:26 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net [217.70.183.198]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id EA8336899F2 for ; Thu, 6 Jun 2019 13:24:20 +0300 (EEST) X-Originating-IP: 213.47.41.20 Received: from localhost (213-47-41-20.cable.dynamic.surfer.at [213.47.41.20]) (Authenticated sender: michael@niedermayer.cc) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 4C646C000D for ; Thu, 6 Jun 2019 10:24:15 +0000 (UTC) Date: Thu, 6 Jun 2019 12:24:13 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20190606102413.GJ3118@michaelspb> References: <20190604144538.18166-1-onemda@gmail.com> <20190605213027.GI3118@michaelspb> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Subject: Re: [FFmpeg-devel] [PATCH] avformat/id3v2enc: write CTOC too X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" On Thu, Jun 06, 2019 at 09:08:48AM +0200, Paul B Mahol wrote: > On 6/5/19, Michael Niedermayer wrote: > > On Tue, Jun 04, 2019 at 04:45:38PM +0200, Paul B Mahol wrote: > >> Signed-off-by: Paul B Mahol > >> --- > >> libavformat/id3v2enc.c | 36 ++++++++++++++++++++++++++++++++++++ > >> 1 file changed, 36 insertions(+) > > > > if this is written in a fate test then it will need an update > > (this patch as it is ATM does write it in fate-lavf-fate-mp3) > > > > What are you talking about? No tests need update for fate. Test lavf-fate-mp3 failed. Look at tests/data/fate/lavf-fate-mp3.err for details. make: *** [fate-lavf-fate-mp3] Error 1 make: *** Waiting for unfinished jobs.... [...] --- ./tests/ref/lavf-fate/mp3 2019-06-04 00:17:28.266942595 +0200 +++ tests/data/fate/lavf-fate-mp3 2019-06-06 11:01:19.501329747 +0200 @@ -1,3 +1,3 @@ -f231c5316357fd747573cbcb02f889c5 *tests/data/lavf-fate/lavf.mp3 -96016 tests/data/lavf-fate/lavf.mp3 +4c47e0589cc3a0c415d1def532c7f34d *tests/data/lavf-fate/lavf.mp3 +96033 tests/data/lavf-fate/lavf.mp3 tests/data/lavf-fate/lavf.mp3 CRC=0x6c9850fe