[FFmpeg-devel,1/4] avcodec/mediacodec_wrapper: add missing <libavcodec/avcodec.h> include

Submitted by Matthieu Bouron on July 4, 2019, 1:43 p.m.

Details

Message ID 20190704134348.6071-1-matthieu.bouron@gmail.com
State New
Headers show

Commit Message

Matthieu Bouron July 4, 2019, 1:43 p.m.
---
 libavcodec/mediacodec_wrapper.h | 2 ++
 1 file changed, 2 insertions(+)

Comments

James Almer July 4, 2019, 2 p.m.
On 7/4/2019 10:43 AM, Matthieu Bouron wrote:
> ---
>  libavcodec/mediacodec_wrapper.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/libavcodec/mediacodec_wrapper.h b/libavcodec/mediacodec_wrapper.h
> index f0de16d669..58e5dc7d39 100644
> --- a/libavcodec/mediacodec_wrapper.h
> +++ b/libavcodec/mediacodec_wrapper.h
> @@ -26,6 +26,8 @@
>  #include <stdint.h>
>  #include <sys/types.h>
>  
> +#include <libavcodec/avcodec.h>

"avcodec.h" is enough. This is an internal header.

> +
>  /**
>   * The following API around MediaCodec and MediaFormat is based on the
>   * NDK one provided by Google since Android 5.0.
>
Nicolas George July 4, 2019, 2:03 p.m.
Matthieu Bouron (12019-07-04):
> ---
>  libavcodec/mediacodec_wrapper.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/libavcodec/mediacodec_wrapper.h b/libavcodec/mediacodec_wrapper.h
> index f0de16d669..58e5dc7d39 100644
> --- a/libavcodec/mediacodec_wrapper.h
> +++ b/libavcodec/mediacodec_wrapper.h
> @@ -26,6 +26,8 @@
>  #include <stdint.h>
>  #include <sys/types.h>
>  

> +#include <libavcodec/avcodec.h>

AFAIK, this is not the correct way of including one of our own headers,
especially from the same sub-library. Just "avcodec.h".

> +
>  /**
>   * The following API around MediaCodec and MediaFormat is based on the
>   * NDK one provided by Google since Android 5.0.

Regards,

Patch hide | download patch | download mbox

diff --git a/libavcodec/mediacodec_wrapper.h b/libavcodec/mediacodec_wrapper.h
index f0de16d669..58e5dc7d39 100644
--- a/libavcodec/mediacodec_wrapper.h
+++ b/libavcodec/mediacodec_wrapper.h
@@ -26,6 +26,8 @@ 
 #include <stdint.h>
 #include <sys/types.h>
 
+#include <libavcodec/avcodec.h>
+
 /**
  * The following API around MediaCodec and MediaFormat is based on the
  * NDK one provided by Google since Android 5.0.