From patchwork Thu Jul 4 14:11:38 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matthieu Bouron X-Patchwork-Id: 13818 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id CF3D344889E for ; Thu, 4 Jul 2019 17:11:55 +0300 (EEST) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B091268ABFA; Thu, 4 Jul 2019 17:11:55 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7F6A868ABF8 for ; Thu, 4 Jul 2019 17:11:49 +0300 (EEST) Received: by mail-wr1-f67.google.com with SMTP id x4so6785412wrt.6 for ; Thu, 04 Jul 2019 07:11:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=1HPtdCQZoMQwOaYeoroAyDfImjWyuwp5CWn0Z2F5p/g=; b=Q5kx62sd15Qsyxagd5lY+9IRrZiMY0Zs06N+eqBghcWfSJGGKVCcmo9kfZVt/VWwNx X4FnAfun/ZElODn/UwdoNEiLWtHb+5ltoiSU9PUzxuFIq98J+P2nwgV4oFZkGnbGudf0 SdFSHm1ROYahNEd9cxl+wWMNbwagkXmD+n6+G1bKl+xjx8asqa1DVWqPXmWGy+DwWiGU 21HvF9URRpWqwmfWOPoLXw07b0PuIdxlGCiwwPXRIjGN6IlRMzVJvlbsOmcF/IJmJHCl oyNsHLpqE6e9fNEKQVD7wuEgKRnyb/BOPm6n4lF381qUkshc80N22lZ9n4lTvDo6OB+0 9JMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=1HPtdCQZoMQwOaYeoroAyDfImjWyuwp5CWn0Z2F5p/g=; b=gvEyIrm+eQC3c4bCr4Di2gjr71DKufUDLOebMLHJ4Q26vU8doxb9kaZK1cyI3NqeS9 Z/UW+CET2+yjnekQaOrtkw5gDccgjz/awPybnjjMIQHjG23Lj7FwDNkNqCg9xSp79Btq EQ7iHg7PE15ErTeFwRHVrlinTWXbGLH5ZO1TbQSBo1A/fJhym4thOzIH8PihpK7fTvAl gTVK49wg06YMmmq65t0qnjpe/ccgVmS7pcvqMJCHjZyUNiTvAU9+icg0jreThGbcf4FN oPwrVu1UvnQGaKiIbEkwhR2BaJtF50RFhzlPIEEiIzOKRHMQO5ijmt7m26vbZdbC/G7t tb9g== X-Gm-Message-State: APjAAAXJ8P+FLbsxyS/+uWBUAnoBucOmDOHNllzp6Fu5GpjhjM2I/Le0 K6tYO4W9EIX2hsuYCmDFhDFzevc+ X-Google-Smtp-Source: APXvYqwJQ10zbDPsiPbSSI76cJvvGMWcFeP/BbEUr8ZG0LjM+zS94TZCaNyO0LIsGXd36FGsNZhE6Q== X-Received: by 2002:adf:e941:: with SMTP id m1mr1625433wrn.279.1562249508870; Thu, 04 Jul 2019 07:11:48 -0700 (PDT) Received: from tsuri (lfbn-1-4282-17.w92-169.abo.wanadoo.fr. [92.169.35.17]) by smtp.gmail.com with ESMTPSA id q16sm236191wra.36.2019.07.04.07.11.47 for (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Thu, 04 Jul 2019 07:11:48 -0700 (PDT) Date: Thu, 4 Jul 2019 16:11:38 +0200 From: Matthieu Bouron To: FFmpeg development discussions and patches Message-ID: <20190704141138.GA3628@tsuri> References: <20190704134348.6071-1-matthieu.bouron@gmail.com> <20190704140342.sw3wjn67i7qhfno4@phare.normalesup.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190704140342.sw3wjn67i7qhfno4@phare.normalesup.org> User-Agent: Mutt/1.12.1 (2019-06-15) Subject: Re: [FFmpeg-devel] [PATCH 1/4] avcodec/mediacodec_wrapper: add missing include X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" On Thu, Jul 04, 2019 at 04:03:42PM +0200, Nicolas George wrote: > Matthieu Bouron (12019-07-04): > > --- > > libavcodec/mediacodec_wrapper.h | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/libavcodec/mediacodec_wrapper.h b/libavcodec/mediacodec_wrapper.h > > index f0de16d669..58e5dc7d39 100644 > > --- a/libavcodec/mediacodec_wrapper.h > > +++ b/libavcodec/mediacodec_wrapper.h > > @@ -26,6 +26,8 @@ > > #include > > #include > > > > > +#include > > AFAIK, this is not the correct way of including one of our own headers, > especially from the same sub-library. Just "avcodec.h". Fixed in attached patch. Thanks. diff --git a/libavcodec/mediacodec_wrapper.h b/libavcodec/mediacodec_wrapper.h index f0de16d669..b106ff315a 100644 --- a/libavcodec/mediacodec_wrapper.h +++ b/libavcodec/mediacodec_wrapper.h @@ -26,6 +26,8 @@ #include #include +#include "avcodec.h" + /** * The following API around MediaCodec and MediaFormat is based on the * NDK one provided by Google since Android 5.0.