[FFmpeg-devel] fate: add a case for ticket #3229

Submitted by Zhong Li on July 14, 2019, 10:16 a.m.

Details

Message ID 1563099379-31272-1-git-send-email-zhong.li@intel.com
State New
Headers show

Commit Message

Zhong Li July 14, 2019, 10:16 a.m.
Signed-off-by: Zhong Li <zhong.li@intel.com>
---
https://patchwork.ffmpeg.org/patch/13725/ introduces a regression but not found by fate, so add it.
Test clip produced by:
ffmpeg -i tickets/3229/bad.avi -vframes 20 -c:v copy /fate-suite/mjpeg/mjpeg_field_order.avi

tests/fate/video.mak            |  3 +++
 tests/ref/fate/mjpeg-ticket3229 | 25 +++++++++++++++++++++++++
 2 files changed, 28 insertions(+)
 create mode 100644 tests/ref/fate/mjpeg-ticket3229

Comments

Michael Niedermayer July 14, 2019, 6:56 p.m.
On Sun, Jul 14, 2019 at 06:16:19PM +0800, Zhong Li wrote:
> Signed-off-by: Zhong Li <zhong.li@intel.com>
> ---
> https://patchwork.ffmpeg.org/patch/13725/ introduces a regression but not found by fate, so add it.
> Test clip produced by:
> ffmpeg -i tickets/3229/bad.avi -vframes 20 -c:v copy /fate-suite/mjpeg/mjpeg_field_order.avi

do we need 20 frames for this ?
the file is over 4mb large, which is why i ask

thx

[...]
Zhong Li July 29, 2019, 10:22 a.m.
> From: ffmpeg-devel [mailto:ffmpeg-devel-bounces@ffmpeg.org] On Behalf
> Of Michael Niedermayer
> Sent: Monday, July 15, 2019 2:56 AM
> To: FFmpeg development discussions and patches
> <ffmpeg-devel@ffmpeg.org>
> Subject: Re: [FFmpeg-devel] [PATCH] fate: add a case for ticket #3229
> 
> On Sun, Jul 14, 2019 at 06:16:19PM +0800, Zhong Li wrote:
> > Signed-off-by: Zhong Li <zhong.li@intel.com>
> > ---
> > https://patchwork.ffmpeg.org/patch/13725/ introduces a regression but
> not found by fate, so add it.
> > Test clip produced by:
> > ffmpeg -i tickets/3229/bad.avi -vframes 20 -c:v copy
> > /fate-suite/mjpeg/mjpeg_field_order.avi
> 
> do we need 20 frames for this ?
> the file is over 4mb large, which is why i ask
> 
> thx

Good point, Michael.
A new version cut to 6 frames has been sent.

Patch hide | download patch | download mbox

diff --git a/tests/fate/video.mak b/tests/fate/video.mak
index be1458c..d2d43e5 100644
--- a/tests/fate/video.mak
+++ b/tests/fate/video.mak
@@ -232,6 +232,9 @@  fate-mimic: CMD = framecrc -idct simple -i $(TARGET_SAMPLES)/mimic/mimic2-womanl
 FATE_VIDEO-$(call DEMDEC, MOV, MJPEGB) += fate-mjpegb
 fate-mjpegb: CMD = framecrc -idct simple -fflags +bitexact -i $(TARGET_SAMPLES)/mjpegb/mjpegb_part.mov -an
 
+FATE_VIDEO-$(call DEMDEC, AVI, MJPEG) += fate-mjpeg-ticket3229
+fate-mjpeg-ticket3229: CMD = framecrc -idct simple -fflags +bitexact -i $(TARGET_SAMPLES)/mjpeg/mjpeg_field_order.avi -an
+
 FATE_VIDEO-$(call DEMDEC, MVI, MOTIONPIXELS) += fate-motionpixels
 fate-motionpixels: CMD = framecrc -i $(TARGET_SAMPLES)/motion-pixels/INTRO-partial.MVI -an -pix_fmt rgb24 -frames:v 111
 
diff --git a/tests/ref/fate/mjpeg-ticket3229 b/tests/ref/fate/mjpeg-ticket3229
new file mode 100644
index 0000000..859e3c5
--- /dev/null
+++ b/tests/ref/fate/mjpeg-ticket3229
@@ -0,0 +1,25 @@ 
+#tb 0: 1/30
+#media_type 0: video
+#codec_id 0: rawvideo
+#dimensions 0: 468x312
+#sar 0: 0/1
+0,          0,          0,        1,   292032, 0x3af3a5f7
+0,          6,          6,        1,   292032, 0xe97fb504
+0,          8,          8,        1,   292032, 0xd448db04
+0,          9,          9,        1,   292032, 0xd448db04
+0,         10,         10,        1,   292032, 0xd448db04
+0,         11,         11,        1,   292032, 0xd448db04
+0,         13,         13,        1,   292032, 0xd448db04
+0,         14,         14,        1,   292032, 0xd448db04
+0,         15,         15,        1,   292032, 0xd448db04
+0,         16,         16,        1,   292032, 0xd448db04
+0,         17,         17,        1,   292032, 0x42e8d61c
+0,         19,         19,        1,   292032, 0x944dc70f
+0,         21,         21,        1,   292032, 0x944dc70f
+0,         22,         22,        1,   292032, 0x944dc70f
+0,         23,         23,        1,   292032, 0xd363db9a
+0,         25,         25,        1,   292032, 0xd363db9a
+0,         26,         26,        1,   292032, 0xd363db9a
+0,         27,         27,        1,   292032, 0xd363db9a
+0,         28,         28,        1,   292032, 0xd363db9a
+0,         29,         29,        1,   292032, 0x81feeaa7