[FFmpeg-devel,2/3] fate: change the scenecut fate threshold for one more scenecut scenes

Submitted by lance.lmwang@gmail.com on July 15, 2019, 10:53 p.m.

Details

Message ID 1563231238-20966-2-git-send-email-lance.lmwang@gmail.com
State Accepted
Commit d75c7dd45edfb78d8d37da8d589ede49f9612c22
Headers show

Commit Message

lance.lmwang@gmail.com July 15, 2019, 10:53 p.m.
From: Limin Wang <lance.lmwang@gmail.com>

Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
---
 tests/fate/filter-video.mak                | 2 +-
 tests/ref/fate/filter-metadata-scenedetect | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

Comments

Michael Niedermayer July 17, 2019, 7:26 p.m.
On Tue, Jul 16, 2019 at 06:53:57AM +0800, lance.lmwang@gmail.com wrote:
> From: Limin Wang <lance.lmwang@gmail.com>
> 
> Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
> ---
>  tests/fate/filter-video.mak                | 2 +-
>  tests/ref/fate/filter-metadata-scenedetect | 1 +
>  2 files changed, 2 insertions(+), 1 deletion(-)

The commit message should also say "why" the change is done

Thanks

[...]
lance.lmwang@gmail.com July 18, 2019, 1:04 a.m.
On Wed, Jul 17, 2019 at 09:26:42PM +0200, Michael Niedermayer wrote:
> On Tue, Jul 16, 2019 at 06:53:57AM +0800, lance.lmwang@gmail.com wrote:
> > From: Limin Wang <lance.lmwang@gmail.com>
> > 
> > Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
> > ---
> >  tests/fate/filter-video.mak                | 2 +-
> >  tests/ref/fate/filter-metadata-scenedetect | 1 +
> >  2 files changed, 2 insertions(+), 1 deletion(-)
> 
> The commit message should also say "why" the change is done

When I'm testing the fate sample, it has one scenecut is missing for the
0.4 threshold, so I change it, why to 0.25, it's for the next patch to
detect the same scene. Now the 10bit format testing isn't expected, I'll
update the comment message if have further updated.


Thanks,

> 
> Thanks
> 
> [...]
> -- 
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
> 
> Never trust a computer, one day, it may think you are the virus. -- Compn



> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Patch hide | download patch | download mbox

diff --git a/tests/fate/filter-video.mak b/tests/fate/filter-video.mak
index 1042e96..60c6be1 100644
--- a/tests/fate/filter-video.mak
+++ b/tests/fate/filter-video.mak
@@ -734,7 +734,7 @@  SCENEDETECT_DEPS = FFPROBE LAVFI_INDEV MOVIE_FILTER SELECT_FILTER SCALE_FILTER \
                    AVCODEC AVDEVICE MOV_DEMUXER SVQ3_DECODER ZLIB
 FATE_METADATA_FILTER-$(call ALLYES, $(SCENEDETECT_DEPS)) += fate-filter-metadata-scenedetect
 fate-filter-metadata-scenedetect: SRC = $(TARGET_SAMPLES)/svq3/Vertical400kbit.sorenson3.mov
-fate-filter-metadata-scenedetect: CMD = run $(FILTER_METADATA_COMMAND) "sws_flags=+accurate_rnd+bitexact;movie='$(SRC)',select=gt(scene\,.4)"
+fate-filter-metadata-scenedetect: CMD = run $(FILTER_METADATA_COMMAND) "sws_flags=+accurate_rnd+bitexact;movie='$(SRC)',select=gt(scene\,.25)"
 
 CROPDETECT_DEPS = FFPROBE LAVFI_INDEV MOVIE_FILTER CROPDETECT_FILTER SCALE_FILTER \
                   AVCODEC AVDEVICE MOV_DEMUXER H264_DECODER
diff --git a/tests/ref/fate/filter-metadata-scenedetect b/tests/ref/fate/filter-metadata-scenedetect
index d04054a..67c23b3 100644
--- a/tests/ref/fate/filter-metadata-scenedetect
+++ b/tests/ref/fate/filter-metadata-scenedetect
@@ -7,4 +7,5 @@  pkt_pts=9760|tag:lavfi.scene_score=1.000000
 pkt_pts=14080|tag:lavfi.scene_score=0.838916
 pkt_pts=15700|tag:lavfi.scene_score=1.000000
 pkt_pts=18500|tag:lavfi.scene_score=0.474948
+pkt_pts=20040|tag:lavfi.scene_score=0.379700
 pkt_pts=21760|tag:lavfi.scene_score=1.000000