From patchwork Thu Jul 25 12:12:52 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: velocityra@gmail.com X-Patchwork-Id: 14068 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id D73C8448934 for ; Thu, 25 Jul 2019 15:18:38 +0300 (EEST) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id BC36168ABCC; Thu, 25 Jul 2019 15:18:38 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1AF7B68ABCA for ; Thu, 25 Jul 2019 15:18:33 +0300 (EEST) Received: by mail-wm1-f67.google.com with SMTP id p74so44762180wme.4 for ; Thu, 25 Jul 2019 05:18:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=GXxW0Ib/LBaVDkZtzaz1GY+cbLK/Ox8i0WS66Cl4z9c=; b=HhX+kbx9CI7MbjL8+o7sgWK68fsuTcJ6EcJUde+xWkZKpIO/lG4xeuovYZbB0a+F+0 fKIqGy+KZyibBRpfS35ZuZUEm3Kev/nlOrqZHX7tUsHDVYhcVlfTKjnHkkQBN+Ze/H5v RlxhUlISrHulCR2i9x6PRlLeh38uFbF7IuJKMlcGCDE+Likh8TSaPAgalmwMEh/IImtB XU+BkFoJTJEElS5XrBL718+hOgAwIU0lPbQPjSPEDWLcgclQn+jhAJ/gqzW/VtxxWLpu WKyGF7qOqz8D7P1ZBI/TQZgbyVx0VHEWLDcVtud1qiN8k9GY41Vie0JHjVFsr1i7QF7S eeoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=GXxW0Ib/LBaVDkZtzaz1GY+cbLK/Ox8i0WS66Cl4z9c=; b=VhlH/7ja9/bBmsC17jvdrRj2YFqPmAqTxrKI6o8BtaxJexmtftDoz3U5NQCqL9QSW5 RCKxzLwyhYMgkvF2tsBnYMGoHlg41+V8kpLCaAhIqm/2IyMRqU/AwN45fHON1uVWTlBH bG1Ww/bps+LNMHqWbr7hhhWx4dwUj5TzlOQosCHwBQCyqwWAaCmba/lNuKkLwKFKoSsW oFUSi7MgloeBlAQatfWiTQ/YjLoV6qN5pmdzUfklZWd3ZirkvAb+XjNCxskjYUrpULMv L3tJH3mHX2gvEiJwaOrMUP+EWt5I9vfXml7I9g49xp1QJl+WCVM/mEN1CFaFVHGctDYg xRXA== X-Gm-Message-State: APjAAAWCQCz9KZ07PterOJTVOjzUxItvgAX5D59ReUKjokUbJoWEccMJ DDhuMC/5RPlA5tQwzfnsMxkhW44y X-Google-Smtp-Source: APXvYqzpTpm6RGGOGK7iPpJboBVvz2yV1Eh5OI51lZ1vmqqsOPawNH4rXeO8uOJRTY0wzfgalA6+9Q== X-Received: by 2002:a1c:b707:: with SMTP id h7mr78335963wmf.45.1564056800230; Thu, 25 Jul 2019 05:13:20 -0700 (PDT) Received: from localhost.localdomain ([2a02:587:2428:db00:d890:dfd2:86e8:60f2]) by smtp.gmail.com with ESMTPSA id y6sm42454037wrp.12.2019.07.25.05.13.18 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 25 Jul 2019 05:13:19 -0700 (PDT) From: velocityra@gmail.com X-Google-Original-From: velocityra@gmail To: ffmpeg-devel@ffmpeg.org Date: Thu, 25 Jul 2019 15:12:52 +0300 Message-Id: <20190725121253.35148-1-velocityra@gmail.com> X-Mailer: git-send-email 2.21.0.windows.1 In-Reply-To: <20190725105803.GC3219@michaelspb> References: <20190725105803.GC3219@michaelspb> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH v6 1/2] lavc/mjpegdec: Decode Huffman-coded lossless JPEGs embedded in DNGs X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Nick Renieris Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" From: Nick Renieris Main image data in DNGs is usually comprised of tiles, each of which is a Huffman-encoded lossless JPEG. Tested for ljpeg regressions with: `ffmpeg -f lavfi -i testsrc=d=1 -vcodec ljpeg test.avi` `ffmpeg test.avi out.avi` The modified code in ljpeg_decode_rgb_scan runs without issues. Signed-off-by: Nick Renieris --- libavcodec/mjpegdec.c | 54 ++++++++++++++++++++++++++++++++++++------- libavcodec/mjpegdec.h | 1 + 2 files changed, 47 insertions(+), 8 deletions(-) diff --git a/libavcodec/mjpegdec.c b/libavcodec/mjpegdec.c index a65bc8df15..d622305298 100644 --- a/libavcodec/mjpegdec.c +++ b/libavcodec/mjpegdec.c @@ -412,6 +412,14 @@ int ff_mjpeg_decode_sof(MJpegDecodeContext *s) return AVERROR_PATCHWELCOME; } + /* Lossless JPEGs encoded in DNGs are commonly bayer-encoded. They contain 2 + interleaved components and the width stored in their SOF3 markers is the + width of each one. We only output a single component, therefore we need + to adjust the output image width. */ + if (s->lossless == 1 && nb_components == 2) { + s->bayer = 1; + width *= 2; + } /* if different size, realloc/alloc picture */ if (width != s->width || height != s->height || bits != s->bits || @@ -488,6 +496,9 @@ int ff_mjpeg_decode_sof(MJpegDecodeContext *s) } switch (pix_fmt_id) { + case 0x11110000: /* for bayer-encoded huffman lossless JPEGs embedded in DNGs */ + s->avctx->pix_fmt = AV_PIX_FMT_GRAY16LE; + break; case 0x11111100: if (s->rgb) s->avctx->pix_fmt = s->bits <= 9 ? AV_PIX_FMT_BGR24 : AV_PIX_FMT_BGR48; @@ -1041,26 +1052,36 @@ static int handle_rstn(MJpegDecodeContext *s, int nb_components) return reset; } +/* Handles 1 to 4 components */ static int ljpeg_decode_rgb_scan(MJpegDecodeContext *s, int nb_components, int predictor, int point_transform) { int i, mb_x, mb_y; + unsigned width; uint16_t (*buffer)[4]; int left[4], top[4], topleft[4]; const int linesize = s->linesize[0]; const int mask = ((1 << s->bits) - 1) << point_transform; int resync_mb_y = 0; int resync_mb_x = 0; + int vpred[6]; - if (s->nb_components != 3 && s->nb_components != 4) + if (s->nb_components <= 0 || s->nb_components > 4) return AVERROR_INVALIDDATA; + if (s->v_max != 1 || s->h_max != 1 || !s->lossless) return AVERROR_INVALIDDATA; - s->restart_count = s->restart_interval; - av_fast_malloc(&s->ljpeg_buffer, &s->ljpeg_buffer_size, - (unsigned)s->mb_width * 4 * sizeof(s->ljpeg_buffer[0][0])); + if (s->restart_interval == 0) + s->restart_interval = INT_MAX; + + if (s->bayer) + width = s->mb_width / nb_components; /* Interleaved, width stored is the total so need to divide */ + else + width = s->mb_width; + + av_fast_malloc(&s->ljpeg_buffer, &s->ljpeg_buffer_size, width * 4 * sizeof(s->ljpeg_buffer[0][0])); if (!s->ljpeg_buffer) return AVERROR(ENOMEM); @@ -1078,7 +1099,12 @@ static int ljpeg_decode_rgb_scan(MJpegDecodeContext *s, int nb_components, int p for (i = 0; i < 4; i++) top[i] = left[i] = topleft[i] = buffer[0][i]; - for (mb_x = 0; mb_x < s->mb_width; mb_x++) { + if (mb_y * s->width % s->restart_interval == 0) { + for (i = 0; i < 6; i++) + vpred[i] = 1 << (s->bits-1); + } + + for (mb_x = 0; mb_x < width; mb_x++) { int modified_predictor = predictor; if (get_bits_left(&s->gb) < 1) { @@ -1102,12 +1128,19 @@ static int ljpeg_decode_rgb_scan(MJpegDecodeContext *s, int nb_components, int p topleft[i] = top[i]; top[i] = buffer[mb_x][i]; - PREDICT(pred, topleft[i], top[i], left[i], modified_predictor); - dc = mjpeg_decode_dc(s, s->dc_index[i]); if(dc == 0xFFFFF) return -1; + if (!s->bayer || mb_x) { + pred = left[i]; + } else { /* This path runs only for the first line in bayer images */ + vpred[i] += dc; + pred = vpred[i] - dc; + } + + PREDICT(pred, topleft[i], top[i], pred, modified_predictor); + left[i] = buffer[mb_x][i] = mask & (pred + (unsigned)(dc * (1 << point_transform))); } @@ -1151,6 +1184,11 @@ static int ljpeg_decode_rgb_scan(MJpegDecodeContext *s, int nb_components, int p ptr[3*mb_x + 0] = buffer[mb_x][1] + ptr[3*mb_x + 1]; ptr[3*mb_x + 2] = buffer[mb_x][2] + ptr[3*mb_x + 1]; } + } else if (s->bayer && nb_components == 2) { + for (mb_x = 0; mb_x < width; mb_x++) { + ((uint16_t*)ptr)[2*mb_x + 0] = buffer[mb_x][0]; + ((uint16_t*)ptr)[2*mb_x + 1] = buffer[mb_x][1]; + } } else { for(i=0; icomp_index[i]; @@ -1695,7 +1733,7 @@ next_field: point_transform, ilv)) < 0) return ret; } else { - if (s->rgb) { + if (s->rgb || s->bayer) { if ((ret = ljpeg_decode_rgb_scan(s, nb_components, predictor, point_transform)) < 0) return ret; } else { diff --git a/libavcodec/mjpegdec.h b/libavcodec/mjpegdec.h index 653fe7cae6..9d1666bebd 100644 --- a/libavcodec/mjpegdec.h +++ b/libavcodec/mjpegdec.h @@ -64,6 +64,7 @@ typedef struct MJpegDecodeContext { int lossless; int ls; int progressive; + int bayer; /* true if it's a bayer-encoded JPEG embedded in a DNG */ int rgb; uint8_t upscale_h[4]; uint8_t upscale_v[4];