From patchwork Wed Aug  7 22:32:43 2019
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Michael Niedermayer <michael@niedermayer.cc>
X-Patchwork-Id: 14309
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
X-Original-To: patchwork@ffaux-bg.ffmpeg.org
Delivered-To: patchwork@ffaux-bg.ffmpeg.org
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by ffaux.localdomain (Postfix) with ESMTP id F18C94470A5
	for <patchwork@ffaux-bg.ffmpeg.org>;
	Thu,  8 Aug 2019 01:32:51 +0300 (EEST)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id CBD9668A4A3;
	Thu,  8 Aug 2019 01:32:51 +0300 (EEST)
X-Original-To: ffmpeg-devel@ffmpeg.org
Delivered-To: ffmpeg-devel@ffmpeg.org
Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net
	[217.70.183.201])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 8F432689B6D
	for <ffmpeg-devel@ffmpeg.org>; Thu,  8 Aug 2019 01:32:45 +0300 (EEST)
X-Originating-IP: 213.47.41.20
Received: from localhost (213-47-41-20.cable.dynamic.surfer.at
	[213.47.41.20]) (Authenticated sender: michael@niedermayer.cc)
	by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id ABA121BF204
	for <ffmpeg-devel@ffmpeg.org>; Wed,  7 Aug 2019 22:32:44 +0000 (UTC)
Date: Thu, 8 Aug 2019 00:32:43 +0200
From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Message-ID: <20190807223243.GJ3219@michaelspb>
References: 
 <CAObpvQkTn+Cpt570HXSFKpQh-8b+v1XPO0TC4_LFyGzjeDh=Kg@mail.gmail.com>
	<20190807152723.18892-1-velocityra@gmail.com>
	<20190807152723.18892-2-velocityra@gmail.com>
MIME-Version: 1.0
In-Reply-To: <20190807152723.18892-2-velocityra@gmail.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Subject: Re: [FFmpeg-devel] [PATCH v10 02/13] lavc/tiff: Decode embedded
	JPEGs in DNG images
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <http://ffmpeg.org/mailman/options/ffmpeg-devel>,
	<mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <http://ffmpeg.org/pipermail/ffmpeg-devel/>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <http://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
	<mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches
	<ffmpeg-devel@ffmpeg.org>
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>

On Wed, Aug 07, 2019 at 06:27:12PM +0300, velocityra@gmail.com wrote:
> From: Nick Renieris <velocityra@gmail.com>
> 
> Used a technique similar to lavc/tdsc.c for invoking the MJPEG decoder.
> 
> This commit adds support for:
> - DNG tiles
> - DNG tile huffman lossless JPEG decoding
> - DNG 8-bpp ("packed" as dcraw calls it) decoding
> - DNG color scaling [1]
>   - LinearizationTable tag
>   - BlackLevel tag
> 
> [1]: As specified in the DNG Specification - Chapter 5
> 
> Signed-off-by: Nick Renieris <velocityra@gmail.com>
> ---
>  configure           |   1 +
>  libavcodec/Makefile |   2 +-
>  libavcodec/tiff.c   | 318 +++++++++++++++++++++++++++++++++++++++++++-
>  libavcodec/tiff.h   |   2 +
>  4 files changed, 315 insertions(+), 8 deletions(-)

breaks 
TEST    tiff-fax-g3s
Test tiff-fax-g3s failed. Look at tests/data/fate/tiff-fax-g3s.err for details.
make: *** [fate-tiff-fax-g3s] Error 1

[...]

--- ./tests/ref/fate/tiff-fax-g3s	2019-08-05 22:38:57.562197572 +0200
+++ tests/data/fate/tiff-fax-g3s	2019-08-08 00:31:26.473428768 +0200
@@ -3,4 +3,4 @@
 #codec_id 0: rawvideo
 #dimensions 0: 2464x3248
 #sar 0: 1/1
-0,          0,          0,        1,  1000384, 0xb758eb8b
+0,          0,          0,        1, 16006144, 0xef95913a