From patchwork Tue Aug 13 01:04:55 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aman Karmani X-Patchwork-Id: 14454 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id 3B13C449B38 for ; Tue, 13 Aug 2019 04:12:05 +0300 (EEST) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 123A668AB83; Tue, 13 Aug 2019 04:12:05 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-pf1-f195.google.com (mail-pf1-f195.google.com [209.85.210.195]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6C7B568A42C for ; Tue, 13 Aug 2019 04:11:58 +0300 (EEST) Received: by mail-pf1-f195.google.com with SMTP id c81so1588631pfc.11 for ; Mon, 12 Aug 2019 18:11:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tmm1-net.20150623.gappssmtp.com; s=20150623; h=sender:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=LC/2u5MGNykFOHTkA8FCmArjoTje8NKGujkLaDX1Osk=; b=ZEFpOc6PmrYlWbwPXHAApRRw+qXBDPSbQuZQ6wvE2u4GN6oNckjAoIoLz0cGFCqTo4 WdGKMlflMXkUa/soGHtHrcP+ooDl6M9MflU8cSLMsmdIg8x1+8QwGS6LcbOR+07s4tgb BDVYF5MyGjQqhgTulThehz3Hb/2jcEOyz7J/sLc+JAF4VYWNyT5p7ItP+LucA26rW1qM GFuodaVYl2+hAlNzPlXdLBViANSGbQ8KRwFBRgwr4DWqezAgQV2WAAyU6IzYk+KccELi phewSCfGP0qZTP9wOs6+fEMGeoUBbIWJJLvXlv2bDDtV4taNaQfRxlsM2LrOO3BzmgO0 r4yQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; bh=LC/2u5MGNykFOHTkA8FCmArjoTje8NKGujkLaDX1Osk=; b=o0pWlV8/Gvq7p3fua7u+00jMbcF0WoURQPQUwVaK/GUnqbNL/5JWonCb9M7T4VF+f/ 0GfvxtInKhB4skB3RNeyICQ/S5gko3+PRQ8JRBS6oTF3fh8pI5oOznqrVpA3LJSbwgeS yEAj8UJd5u3+ceJFWTp8pCacyalhapEf4Vy4m/SXK4KyUz78nKerqH1Gv3xMXoqm8i1Y xRJhzEKm43/bikms3ue2wOkG10tZPtPVyDLNfLsLQrGuZWDM2dK/xxa05UAzEdagS+WB 16AQXhqbbwEtJG053IRzWUGkOg2/wwdTld1sxBwy2z4PrvrWn7veDPfLnloU9Z7tzqMJ 9fSQ== X-Gm-Message-State: APjAAAXfGGcr5kZGMNd1QY8onUZ8EYmu+Apl4DNQdm+tDYEUg7FCRRc+ q7YmrRaUqyGxK8+CMBDyel5qubkDSXA= X-Google-Smtp-Source: APXvYqwyS8hCinXFaQ/ssuDbFZ93G3qJE20HHnAtr1ZOU7H6qvBfk8iBm5YWQLI8JpIp+7woMx0qXg== X-Received: by 2002:aa7:8383:: with SMTP id u3mr38342980pfm.175.1565658306175; Mon, 12 Aug 2019 18:05:06 -0700 (PDT) Received: from localhost.localdomain (ip184-189-221-177.sb.sd.cox.net. [184.189.221.177]) by smtp.gmail.com with ESMTPSA id p7sm123000887pfp.131.2019.08.12.18.05.04 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 12 Aug 2019 18:05:05 -0700 (PDT) From: Aman Gupta To: ffmpeg-devel@ffmpeg.org Date: Mon, 12 Aug 2019 18:04:55 -0700 Message-Id: <20190813010456.91644-1-ffmpeg@tmm1.net> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH v2 1/2] vaapi_encode: ensure correct VBR bitrate is used in h264 SPS X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: sw@jkqxz.net, Aman Gupta , linjie.fu@intel.com Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" From: Aman Gupta This is a regression from 2562dd9e7831743ba6dc5680501fb7d26a2ec62c which surfaces a pathological bug in some Intel hardware encoders, causing very low bitrates to be generated whenever VBR mode is used. /cc intel/intel-vaapi-driver#480 Signed-off-by: Aman Gupta --- libavcodec/vaapi_encode.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavcodec/vaapi_encode.c b/libavcodec/vaapi_encode.c index e69b59fa37..231efba6cc 100644 --- a/libavcodec/vaapi_encode.c +++ b/libavcodec/vaapi_encode.c @@ -1665,6 +1665,9 @@ rc_mode_found: ctx->va_rc_mode = rc_mode->va_mode; ctx->va_bit_rate = rc_bits_per_second; + if (ctx->va_rc_mode == VA_RC_VBR) + ctx->va_bit_rate = rc_bits_per_second * rc_target_percentage / 100; + av_log(avctx, AV_LOG_VERBOSE, "RC mode: %s.\n", rc_mode->name); if (rc_attr.value == VA_ATTRIB_NOT_SUPPORTED) { // This driver does not want the RC mode attribute to be set.