From patchwork Tue Aug 13 02:47:15 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Rheinhardt X-Patchwork-Id: 14459 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id 3A17F447E79 for ; Tue, 13 Aug 2019 05:48:52 +0300 (EEST) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 22E5468AB37; Tue, 13 Aug 2019 05:48:52 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id F387768A42C for ; Tue, 13 Aug 2019 05:48:44 +0300 (EEST) Received: by mail-wm1-f68.google.com with SMTP id p74so61261wme.4 for ; Mon, 12 Aug 2019 19:48:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=eSI5Mi3RD9yy/8pdykzcSAQWQqFCVjqMTmog8I8G+Is=; b=HHRnmUKPyu5Wk4mQeeaRXXoCVfpHffvl8pkwUglvCIC7mwzyRSS4mYzHs/7VtWgY8r o/5PTqTtG5OWRW0EhOBS5DwhaU43zaSje+cCXbKLSJjHDYjX5AUyi9kZFZPmgqWzGAGS IX91yO+tQGrmUPb1rygHtetDH03gkp74BvsX2BOXIwrihbTrdVKSm7r0hUidQ6siG2sL PYP7f4T7qEBz8fjU5j6a+JIMYYXF2ipD/hMcjoYbI9UJ9zXsFHHEAGIfFDV62G2Z3PdW YxQODK4WyBKIForLRrXusAYwEuFzM7dEeRHtjsGS1JOpgCDn+kv0huXQSqoOe2hAepXY 3BKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=eSI5Mi3RD9yy/8pdykzcSAQWQqFCVjqMTmog8I8G+Is=; b=VKuj+hisMAy9p8vENz2rewsO13dNoJvw5wM5AoRWrOAXgt3VSkWCMkwTBbYFZxuN+D yrxWfFissetRyiil0M8QD0wE6piG3n7DLm7XqfFL9Y/M4lgoDMtVlHabhxsfv+k90TPo 2TQFZ/g/JJUTWZywerJ0t/AiUfdpGdqS0YUYAoytbEc1H8C0t1N3XbULBMz8K4xKPI2Y V8IpAVvpwOyphxkCAdpEXwNNLVeZ4LMQoDfvsP/WPeGF4vOgWwPTqA5wesTi285StUSt x1R9j3VvU1xneRzW5aOXWfTS/xL2j/f50wKRyl+SpYXA+IqOZHizBC5G5p3jeQm8OHIZ MauQ== X-Gm-Message-State: APjAAAXeAUi+lQUu1V971phIkGe/fbWTCJqO4L/9RGsw6U4mSxkSnaF8 H/2fRv4G4HiQLKiiVY4Ot+LJFl8N X-Google-Smtp-Source: APXvYqxA7jlUWogc7Habu6xvIFyHNv9ko77sTEhTSUlfunlbjhwJZhlambLImPDYGKWnacZaFNgkDw== X-Received: by 2002:a1c:a7c9:: with SMTP id q192mr156617wme.144.1565664524419; Mon, 12 Aug 2019 19:48:44 -0700 (PDT) Received: from localhost.localdomain (ipbcc06ceb.dynamic.kabel-deutschland.de. [188.192.108.235]) by smtp.gmail.com with ESMTPSA id k13sm25020613wro.97.2019.08.12.19.48.43 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Mon, 12 Aug 2019 19:48:43 -0700 (PDT) From: Andreas Rheinhardt To: ffmpeg-devel@ffmpeg.org Date: Tue, 13 Aug 2019 04:47:15 +0200 Message-Id: <20190813024726.6596-2-andreas.rheinhardt@gmail.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190813024726.6596-1-andreas.rheinhardt@gmail.com> References: <20190813024726.6596-1-andreas.rheinhardt@gmail.com> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH 02/13] avformat/mux: Don't unnecessarily zero-initialize AVPacketList X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andreas Rheinhardt Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" If no error occurs and this AVPacketList is used at all, its packet substructure will be overwritten and its next pointer explicitly set, so every field will still be initialized even when using av_malloc. Signed-off-by: Andreas Rheinhardt --- libavformat/mux.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/mux.c b/libavformat/mux.c index ac370fb24d..870e716950 100644 --- a/libavformat/mux.c +++ b/libavformat/mux.c @@ -924,7 +924,7 @@ int ff_interleave_add_packet(AVFormatContext *s, AVPacket *pkt, AVStream *st = s->streams[pkt->stream_index]; int chunked = s->max_chunk_size || s->max_chunk_duration; - this_pktl = av_mallocz(sizeof(AVPacketList)); + this_pktl = av_malloc(sizeof(AVPacketList)); if (!this_pktl) return AVERROR(ENOMEM); if ((pkt->flags & AV_PKT_FLAG_UNCODED_FRAME)) {