[FFmpeg-devel] lavu/hwcontext_vaapi: provide detailed error msg if directly mapping fails

Submitted by Linjie Fu on Aug. 15, 2019, 4:32 a.m.

Details

Message ID 20190815043242.20478-1-linjie.fu@intel.com
State New
Headers show

Commit Message

Linjie Fu Aug. 15, 2019, 4:32 a.m.
Detailed message could be helpful when using hwmap=mode=direct,format=xxx
for both qsv and vaapi.

Signed-off-by: Linjie Fu <linjie.fu@intel.com>
---
 libavutil/hwcontext_vaapi.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

Patch hide | download patch | download mbox

diff --git a/libavutil/hwcontext_vaapi.c b/libavutil/hwcontext_vaapi.c
index cf117640f2..3fbeb4954e 100644
--- a/libavutil/hwcontext_vaapi.c
+++ b/libavutil/hwcontext_vaapi.c
@@ -747,19 +747,22 @@  static int vaapi_map_frame(AVHWFramesContext *hwfc,
     av_log(hwfc, AV_LOG_DEBUG, "Map surface %#x.\n", surface_id);
 
     if (!ctx->derive_works && (flags & AV_HWFRAME_MAP_DIRECT)) {
-        // Requested direct mapping but it is not possible.
+        av_log(hwfc, AV_LOG_ERROR, "Requested direct mapping but "
+                                            "it is not possible.\n");
         return AVERROR(EINVAL);
     }
     if (dst->format == AV_PIX_FMT_NONE)
         dst->format = hwfc->sw_format;
     if (dst->format != hwfc->sw_format && (flags & AV_HWFRAME_MAP_DIRECT)) {
-        // Requested direct mapping but the formats do not match.
+        av_log(hwfc, AV_LOG_ERROR, "Requested direct mapping but "
+                                        "the formats do not match.\n");
         return AVERROR(EINVAL);
     }
 
     err = vaapi_get_image_format(hwfc->device_ctx, dst->format, &image_format);
     if (err < 0) {
-        // Requested format is not a valid output format.
+        av_log(hwfc, AV_LOG_ERROR, "Requested format is "
+                                        "not a valid output format.\n");
         return AVERROR(EINVAL);
     }