[FFmpeg-devel,v3] avfilter/vf_delogo: support expr in delogo filter

Submitted by Michael Niedermayer on Aug. 28, 2019, 3:01 p.m.

Details

Message ID 20190828150113.GD3219@michaelspb
State New
Headers show

Commit Message

Michael Niedermayer Aug. 28, 2019, 3:01 p.m.
On Wed, Aug 28, 2019 at 05:39:32AM +0800, Steven Liu wrote:
> Signed-off-by: Steven Liu <lq@chinaffmpeg.org>
> ---
>  libavfilter/vf_delogo.c | 83 ++++++++++++++++++++++++++++++++++++++++++++++---
>  1 file changed, 79 insertions(+), 4 deletions(-)

breaks fate

Comments

lance.lmwang@gmail.com Sept. 2, 2019, 1:43 p.m.
On Wed, Aug 28, 2019 at 05:01:13PM +0200, Michael Niedermayer wrote:
> On Wed, Aug 28, 2019 at 05:39:32AM +0800, Steven Liu wrote:
> > Signed-off-by: Steven Liu <lq@chinaffmpeg.org>
> > ---
> >  libavfilter/vf_delogo.c | 83 ++++++++++++++++++++++++++++++++++++++++++++++---
> >  1 file changed, 79 insertions(+), 4 deletions(-)
> 
> breaks fate

ping, the fate is broken for master

> 
> --- ./tests/ref/fate/filter-delogo	2019-08-27 23:33:16.098044653 +0200
> +++ tests/data/fate/filter-delogo	2019-08-28 16:38:23.481781287 +0200
> @@ -11,104 +11,104 @@
>  0,          5,          5,        1,   126720, 0x259af497
>  0,          6,          6,        1,   126720, 0x5e6ff4d7
>  0,          7,          7,        1,   126720, 0xcc10f4b7
> -0,          8,          8,        1,   126720, 0x2811b819
> -0,          9,          9,        1,   126720, 0x9b36b8d9
> -0,         10,         10,        1,   126720, 0x9488b919
> -0,         11,         11,        1,   126720, 0x316cb902
> -0,         12,         12,        1,   126720, 0xfd2ab949
> -0,         13,         13,        1,   126720, 0x7cc9bbb9
> -0,         14,         14,        1,   126720, 0xdb1bbc39
> ...
> 
> [...]
> -- 
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
> 
> Elect your leaders based on what they did after the last election, not
> based on what they say before an election.
> 



> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
Steven Liu Sept. 2, 2019, 9:32 p.m.
> 在 2019年9月2日,21:43,Limin Wang <lance.lmwang@gmail.com> 写道:
> 
> On Wed, Aug 28, 2019 at 05:01:13PM +0200, Michael Niedermayer wrote:
>> On Wed, Aug 28, 2019 at 05:39:32AM +0800, Steven Liu wrote:
>>> Signed-off-by: Steven Liu <lq@chinaffmpeg.org>
>>> ---
>>> libavfilter/vf_delogo.c | 83 ++++++++++++++++++++++++++++++++++++++++++++++---
>>> 1 file changed, 79 insertions(+), 4 deletions(-)
>> 
>> breaks fate
> 
> ping, the fate is broken for master
Ah,

	That is fixed by Paul B Mahol.

	expr for our user at scene:
	a car from one position[x, y] to the other position[x1, y1],
	then our user want blur or delgo it.

> 
>> 
>> --- ./tests/ref/fate/filter-delogo	2019-08-27 23:33:16.098044653 +0200
>> +++ tests/data/fate/filter-delogo	2019-08-28 16:38:23.481781287 +0200
>> @@ -11,104 +11,104 @@
>> 0,          5,          5,        1,   126720, 0x259af497
>> 0,          6,          6,        1,   126720, 0x5e6ff4d7
>> 0,          7,          7,        1,   126720, 0xcc10f4b7
>> -0,          8,          8,        1,   126720, 0x2811b819
>> -0,          9,          9,        1,   126720, 0x9b36b8d9
>> -0,         10,         10,        1,   126720, 0x9488b919
>> -0,         11,         11,        1,   126720, 0x316cb902
>> -0,         12,         12,        1,   126720, 0xfd2ab949
>> -0,         13,         13,        1,   126720, 0x7cc9bbb9
>> -0,         14,         14,        1,   126720, 0xdb1bbc39
>> ...
>> 
>> [...]
>> -- 
>> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>> 
>> Elect your leaders based on what they did after the last election, not
>> based on what they say before an election.
>> 
> 
> 
> 
>> _______________________________________________
>> ffmpeg-devel mailing list
>> ffmpeg-devel@ffmpeg.org
>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>> 
>> To unsubscribe, visit link above, or email
>> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Thanks
Steven

Patch hide | download patch | download mbox

--- ./tests/ref/fate/filter-delogo	2019-08-27 23:33:16.098044653 +0200
+++ tests/data/fate/filter-delogo	2019-08-28 16:38:23.481781287 +0200
@@ -11,104 +11,104 @@ 
 0,          5,          5,        1,   126720, 0x259af497
 0,          6,          6,        1,   126720, 0x5e6ff4d7
 0,          7,          7,        1,   126720, 0xcc10f4b7
-0,          8,          8,        1,   126720, 0x2811b819
-0,          9,          9,        1,   126720, 0x9b36b8d9
-0,         10,         10,        1,   126720, 0x9488b919
-0,         11,         11,        1,   126720, 0x316cb902
-0,         12,         12,        1,   126720, 0xfd2ab949
-0,         13,         13,        1,   126720, 0x7cc9bbb9
-0,         14,         14,        1,   126720, 0xdb1bbc39
...

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Elect your leaders based on what they did after the last election, not
based on what they say before an election.