From patchwork Thu Sep 5 18:27:32 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aman Karmani X-Patchwork-Id: 14930 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id 7C1C244A28D for ; Thu, 5 Sep 2019 21:34:20 +0300 (EEST) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 63EB36804F5; Thu, 5 Sep 2019 21:34:20 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-oi1-f195.google.com (mail-oi1-f195.google.com [209.85.167.195]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id D707568035C for ; Thu, 5 Sep 2019 21:34:13 +0300 (EEST) Received: by mail-oi1-f195.google.com with SMTP id 7so2720298oip.5 for ; Thu, 05 Sep 2019 11:34:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tmm1-net.20150623.gappssmtp.com; s=20150623; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=SAKRTo8wV/hR9CNiGVmRHvN/uWNKaqPYJC0ohCg06ao=; b=NWJt6BAWTPaMX0sSGffE4SIhMAWMsz8CZo4n8kDD2p0FzqHu+rjtx0J39116mL/sDN JSlZywc1vBK43PKelJu1ngwiKf+6iLP9CPjsnuqT8yUCGZR4G2rtD1y8eMjEHZtOWXV3 A9vezk7kr/7FAIl6L4pKYLlngY2HtMR+NxPg9X1cclv421MFOlCoFf+DPjwMCnouK1st VUVkPo0keAje5eEqnhgHN6tSs5uyvsiCgkanvcu1hQJxhSLOLKo+BdBnzFiM/HasekJ7 DDIFDV6xbYIOLoP+4XJgnHGZ0qcc5q/F8afzTmg1RvsdI7efERUv8ZlODoVrlnj08Pt8 rl0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=SAKRTo8wV/hR9CNiGVmRHvN/uWNKaqPYJC0ohCg06ao=; b=gjLKgdS4KA2mrhrdijcwiVG4pBd6w0IIgudOWG2ORzqJadi2ROTBNo5VvjIE8Ad8RC 03d95b8teS/SQe/Bur02lllwHJz0uIJUPM7yTgvB8ghXTgdmZa3sGIMd7dtRpKQ+wwZQ cuxQolGXPZAd+NvvIPfKSX3GkXPfc9UYXER/a3cwyAlvDcwcOrN6W/Tf+G9mGUdDVJyN nL1A9JP1OGRSpDNZffaZjz/eAmo9G0Kh3vdtcerF8uT+/WY5CV63zYD/hqaySsD8OagQ eobl6TCvtM74TahQJt6nq5gdoSnQssG1ZKyHgfUwm9Gqc3CrrfgY5AI1o25eptHglp2X 1aLA== X-Gm-Message-State: APjAAAU+mW8dXnmjlJJCBYzQw+wEMSHFqVbqxWabiPxpyTFAX9m/NsE6 5O0VUaheJChjPdCBhQxwxtQBjymrHEsCRQ== X-Google-Smtp-Source: APXvYqxj5B7zExQuMFQIZSBz0OlANFxeQusQHED31x6dZhdaCdc8XRz2S+n6V9KhyhydXRc33UlHKA== X-Received: by 2002:aca:d4cc:: with SMTP id l195mr3724414oig.171.1567708064479; Thu, 05 Sep 2019 11:27:44 -0700 (PDT) Received: from tmm1-imac.lan (ip184-189-221-177.sb.sd.cox.net. [184.189.221.177]) by smtp.gmail.com with ESMTPSA id z33sm993614otb.75.2019.09.05.11.27.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 05 Sep 2019 11:27:43 -0700 (PDT) From: Aman Gupta To: ffmpeg-devel@ffmpeg.org Date: Thu, 5 Sep 2019 11:27:32 -0700 Message-Id: <20190905182735.65987-3-ffmpeg@tmm1.net> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190905182735.65987-1-ffmpeg@tmm1.net> References: <20190905182735.65987-1-ffmpeg@tmm1.net> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH 3/6] avcodec/mediacodecdec_common: warn when PTS is missing X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: matthieu.bouron@gmail.com, Aman Gupta Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" From: Aman Gupta MediaCodec decoders require PTS for proper operation. Signed-off-by: Aman Gupta --- libavcodec/mediacodecdec_common.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/libavcodec/mediacodecdec_common.c b/libavcodec/mediacodecdec_common.c index 1656cd6664..eae9c28d42 100644 --- a/libavcodec/mediacodecdec_common.c +++ b/libavcodec/mediacodecdec_common.c @@ -612,7 +612,11 @@ int ff_mediacodec_dec_send(AVCodecContext *avctx, MediaCodecDecContext *s, } pts = pkt->pts; - if (pts != AV_NOPTS_VALUE && avctx->pkt_timebase.num && avctx->pkt_timebase.den) { + if (pts == AV_NOPTS_VALUE) { + av_log(avctx, AV_LOG_WARNING, "Packet is missing PTS!\n"); + pts = 0; + } + if (pts && avctx->pkt_timebase.num && avctx->pkt_timebase.den) { pts = av_rescale_q(pts, avctx->pkt_timebase, AV_TIME_BASE_Q); }