From patchwork Sat Sep 14 03:37:30 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lance Wang X-Patchwork-Id: 15068 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id 9168E44A37E for ; Sat, 14 Sep 2019 06:38:31 +0300 (EEST) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 81E9E6883AD; Sat, 14 Sep 2019 06:38:31 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-pg1-f196.google.com (mail-pg1-f196.google.com [209.85.215.196]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A3B7E6883BA for ; Sat, 14 Sep 2019 06:38:24 +0300 (EEST) Received: by mail-pg1-f196.google.com with SMTP id u72so16259209pgb.10 for ; Fri, 13 Sep 2019 20:38:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=zsU55bvteBcjq8zaLob4Y3JivSuERSwEGy1qZObcPiE=; b=RUmlI4IPm4uq0wgC0NeW/69ec59ZCIt1YdiAzN66du+vXIZjdmTiPkGpY/c6fMBxW4 1O+FE9+zMCsmcAKE9v3204LGDaNHeileX4HFoWhBTsZ6HbP3lHgXlqByNqMNVUFiwp6j s7DQSXKnCRNaEKrghfjNsxsTtMr2f0O1mpDSQY589xUT5rzqei6tYvlfAH7P9K3UgX/8 3iAo7r68Hcs74xp7rIFWedwdxLOn/4o+XLMQC7vZ87NYlFfYwVV/ug6noV90GHuNtMpd xUj+ijRP7jk9BFlWo4+34u8yu8VPTS/He0OU/TQgemrGRvqSTYlHioB9oOiVOoHgeYB6 OI1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=zsU55bvteBcjq8zaLob4Y3JivSuERSwEGy1qZObcPiE=; b=fEe5REPzHNyXC5vS6TXlzAeyAzbDHd0H/qzrk0iqvwEn/yiyq8sBw4D4cdEX3TM/TZ rR0P/nFXq2F/dGQvMd0iX4uN/A2jO49eA54QcQRv/IEjVU1Y7T2y+8oTejRPvptqUt+T JXPz0RA6c32kiIk15nPaomvWg2wZ6PxoaOopQv4P4qSpgk3HrigGaowdfBYQGX+6M8sG eSYmdTx93Qp+FsZHx/n1PB8mOkeiKdWRwsNAxIMg4mrGcPPSRw55YsNL7lHp0lQJLC8f 4E+e/mM42EIQi70cwdHq0XMBRhhAqQPzqym8XR18Qsr3luUqHbVE2nkjHbX+bAHB6CWP E08Q== X-Gm-Message-State: APjAAAXNmxSOYhZ1pHiMEOJ+S31TsuD+TbMxkXEIOHA9HNzHaP47iwv8 2K0GM+c5YURlfTKwQoRRAphNo0rB X-Google-Smtp-Source: APXvYqwfoVFQaxl0BpjTIxzUc5r+Jkw2M6pvH9YMiDTmnMpo/SS2yFq3MviYqna+KyTrm4+OVoZOlw== X-Received: by 2002:a17:90a:c687:: with SMTP id n7mr8501313pjt.3.1568432302637; Fri, 13 Sep 2019 20:38:22 -0700 (PDT) Received: from vpn.localdomain ([47.90.99.151]) by smtp.gmail.com with ESMTPSA id u11sm21614392pfm.113.2019.09.13.20.38.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 13 Sep 2019 20:38:22 -0700 (PDT) From: lance.lmwang@gmail.com To: ffmpeg-devel@ffmpeg.org Date: Sat, 14 Sep 2019 11:37:30 +0800 Message-Id: <20190914033731.19613-2-lance.lmwang@gmail.com> X-Mailer: git-send-email 2.9.5 In-Reply-To: <20190914033731.19613-1-lance.lmwang@gmail.com> References: <20190912233301.17664-1-lance.lmwang@gmail.com> <20190914033731.19613-1-lance.lmwang@gmail.com> Subject: [FFmpeg-devel] [PATCH v2 2/3] avfilter/vf_minterpolate: change the default threshold to get better scene change detect result X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Limin Wang MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" From: Limin Wang ./ffmpeg -loglevel debug -i ../fate-suite/svq3/Vertical400kbit.sorenson3.mov -vf minterpolate=fps=60:mi_mode=blend -an -f null - [Parsed_minterpolate_0 @ 0x7fe7f3e193c0] scene changed, input pts 1600 [Parsed_minterpolate_0 @ 0x7fe7f3e193c0] scene changed, input pts 4120 [Parsed_minterpolate_0 @ 0x7fe7f3e193c0] scene changed, input pts 5780 [Parsed_minterpolate_0 @ 0x7fe7f3e193c0] scene changed, input pts 6700 [Parsed_minterpolate_0 @ 0x7fe7f3e193c0] scene changed, input pts 8140 [Parsed_minterpolate_0 @ 0x7fe7f3e193c0] scene changed, input pts 9740 [Parsed_minterpolate_0 @ 0x7fe7f3e193c0] scene changed, input pts 14060 [Parsed_minterpolate_0 @ 0x7fe7f3e193c0] scene changed, input pts 15680 [Parsed_minterpolate_0 @ 0x7fe7f3e193c0] scene changed, input pts 18480 [Parsed_minterpolate_0 @ 0x7fe7f3e193c0] scene changed, input pts 20020 [Parsed_minterpolate_0 @ 0x7fe7f3e193c0] scene changed, input pts 21740 The results are consistent with tests/ref/fate/filter-metadata-scenedetect For the master, it'll detect more than 20 scene change for the same source. Signed-off-by: Limin Wang --- doc/filters.texi | 2 +- libavfilter/vf_minterpolate.c | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/doc/filters.texi b/doc/filters.texi index 9d500e4..a39785d 100644 --- a/doc/filters.texi +++ b/doc/filters.texi @@ -12743,7 +12743,7 @@ Frame difference. Corresponding pixel values are compared and if it satisfies @v Default method is @samp{fdiff}. @item scd_threshold -Scene change detection threshold. Default is @code{5.0}. +Scene change detection threshold. Default is @code{10.}. @end table @section mix diff --git a/libavfilter/vf_minterpolate.c b/libavfilter/vf_minterpolate.c index fc8054b..c9ce804 100644 --- a/libavfilter/vf_minterpolate.c +++ b/libavfilter/vf_minterpolate.c @@ -230,7 +230,7 @@ static const AVOption minterpolate_options[] = { { "scd", "scene change detection method", OFFSET(scd_method), AV_OPT_TYPE_INT, {.i64 = SCD_METHOD_FDIFF}, SCD_METHOD_NONE, SCD_METHOD_FDIFF, FLAGS, "scene" }, CONST("none", "disable detection", SCD_METHOD_NONE, "scene"), CONST("fdiff", "frame difference", SCD_METHOD_FDIFF, "scene"), - { "scd_threshold", "scene change threshold", OFFSET(scd_threshold), AV_OPT_TYPE_DOUBLE, {.dbl = 5.0}, 0, 100.0, FLAGS }, + { "scd_threshold", "scene change threshold", OFFSET(scd_threshold), AV_OPT_TYPE_DOUBLE, {.dbl = 10.}, 0, 100.0, FLAGS }, { NULL } }; @@ -1097,6 +1097,7 @@ static void interpolate(AVFilterLink *inlink, AVFrame *avf_out) } if (mi_ctx->scene_changed) { + av_log(ctx, AV_LOG_DEBUG, "scene changed, input pts %"PRId64"\n", mi_ctx->frames[1].avf->pts); /* duplicate frame */ av_frame_copy(avf_out, alpha > ALPHA_MAX / 2 ? mi_ctx->frames[2].avf : mi_ctx->frames[1].avf); return;