From patchwork Wed Sep 18 21:08:23 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andriy Gelman X-Patchwork-Id: 15146 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id 20C8344A718 for ; Thu, 19 Sep 2019 00:15:09 +0300 (EEST) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 0305E689F4B; Thu, 19 Sep 2019 00:15:09 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-qk1-f194.google.com (mail-qk1-f194.google.com [209.85.222.194]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id EFDF4689946 for ; Thu, 19 Sep 2019 00:15:02 +0300 (EEST) Received: by mail-qk1-f194.google.com with SMTP id z67so974252qkb.12 for ; Wed, 18 Sep 2019 14:15:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=+t++rWPkOFflO5HIqknxF+1YFkpXfnwbtyn9azAKUZk=; b=MW03ZYRPMawgZoTCJpxTyta8E9aPVINg7wfoBpkDbKEGs8gaKGU4JXGYCalX+oN4L3 W8iVrt5zrDZn+k/3jMwHTuKqBUK1DCVse43TlwbGTEsaYSMiHv8Pj2gWPj1DCamnBz+9 Rh1q2i2Kk6H0dJuLvLsn2dE6zPzBnURv9MazGOzUt6fOBkPPjlgWd1+37Rf3MVn8GMYW ZRC627HKGCuhfh0PHxbD4/0LdPj72PMchkVp5Jl3rjwm+RVd9cDDKrwMW64TMKjNNprY gsvpZgg7fJ43YRmxRUpQ8GfzqMnQID2B5Yf6mvXya9U2ZXiUdypHat7ZdhNfuwCO8q5a H+rA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=+t++rWPkOFflO5HIqknxF+1YFkpXfnwbtyn9azAKUZk=; b=Aqhh9UbH4nBwics8eo12LVDd/bgmxOmpTBeGitM6OAr6odAeaCFXnZAyEV+C6VgOiv Xai1LyYx5QzqzwdMXAPJILUQ0WPaP2fc6f50YmYgPu9p3BaAr0+csFE/8wNag5DNwDHP UkqX/EW+A0Aj42o4Hc94Tb6DGQy5UtLIk3EiMx7T5HNVNJadzXptACkdEP4AogbXCa4s PtMD5kzcblAOU4aY3wJM6LQDMLGiEkD2d6be7TKUUjlnPTk6f6kxxhFtJHFXS13f+ZyW 2IVkjV6qCS7lxkyhul+BpC+cL9lvYNrdP/HJha4HW80N1kQfjR2NGZvT6bb01IB+5DkB SVqw== X-Gm-Message-State: APjAAAV4auMae1ls9oPWYnUtdY8Aj540BCcEkrWbyTQrPMWrOVk+O5DS fgHJJZpgQj6ovrCdWaurxtE2/xNV X-Google-Smtp-Source: APXvYqw8l34A4k5c0A9z0+OKlhoK4MflF6VQ0OyH5sdLNenyQU3Q51p1VSCuQI7BV1CN0MWwDm6fVg== X-Received: by 2002:a37:a24f:: with SMTP id l76mr6179790qke.91.1568840898181; Wed, 18 Sep 2019 14:08:18 -0700 (PDT) Received: from manj (ip-173-133-221-252.spfdma.spcsdns.net. [173.133.221.252]) by smtp.gmail.com with ESMTPSA id h29sm4169224qtb.46.2019.09.18.14.08.17 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Sep 2019 14:08:17 -0700 (PDT) Date: Wed, 18 Sep 2019 17:08:23 -0400 From: Andriy Gelman To: FFmpeg development discussions and patches Message-ID: <20190918210823.rfbhc7kfmuoleas7@manj> References: <20190918193144.5179-1-andriy.gelman@gmail.com> <20190918193144.5179-3-andriy.gelman@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716-1344-11488f-dirty Subject: Re: [FFmpeg-devel] [PATCH v4 2/4] fate: Overwrite output file in hevc-bsf-mp4toannexb test X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" On Wed, 18. Sep 22:34, Carl Eugen Hoyos wrote: > Am Mi., 18. Sept. 2019 um 21:38 Uhr schrieb Andriy Gelman > : > > > > From: Andriy Gelman > > > > Overwrite tests/data/fate/hevc-bsf-mp4toannexb.out in case it exists. > > --- > > tests/fate/hevc.mak | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/tests/fate/hevc.mak b/tests/fate/hevc.mak > > index 4f812b0834..b11e209be0 100644 > > --- a/tests/fate/hevc.mak > > +++ b/tests/fate/hevc.mak > > @@ -236,7 +236,7 @@ tests/data/hevc-mp4.mov: ffmpeg$(PROGSSUF)$(EXESUF) | tests/data > > > > FATE_HEVC-$(call ALLYES, HEVC_DEMUXER MOV_DEMUXER HEVC_MP4TOANNEXB_BSF MOV_MUXER HEVC_MUXER) += fate-hevc-bsf-mp4toannexb > > fate-hevc-bsf-mp4toannexb: tests/data/hevc-mp4.mov > > -fate-hevc-bsf-mp4toannexb: CMD = md5 -i $(TARGET_PATH)/tests/data/hevc-mp4.mov -c:v copy -fflags +bitexact -f hevc > > +fate-hevc-bsf-mp4toannexb: CMD = md5 -y -i $(TARGET_PATH)/tests/data/hevc-mp4.mov -c:v copy -fflags +bitexact -f hevc > > What is this supposed to fix / how can I reproduce this issue? If you run fate-hevc-bsf-mp4toannexb and it fails, this leaves an output file that's not cleaned up in tests/data/fate/hevc-bsf-mp4toannexb.out. Any subsequent fate-hevc-bsf-mp4toannexb tests will always fail (even if the underlying issue is solved) because this file cannot be overwritten in the ffmpeg call. Adding -y solves this. To replicate: $ touch tests/data/fate/hevc-bsf-mp4toannexb.out $ make fate-hevc-bsf-mp4toannexb GEN tests/data/hevc-mp4.mov TEST hevc-bsf-mp4toannexb Test hevc-bsf-mp4toannexb failed. Look at tests/data/fate/hevc-bsf-mp4toannexb.err for details. make: *** [tests/Makefile:241: fate-hevc-bsf-mp4toannexb] Error 1 > > Carl Eugen > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --- - 2019-09-18 17:06:23.377605151 -0400 +++ tests/data/fate/hevc-bsf-mp4toannexb 2019-09-18 17:06:23.371120950 -0400 @@ -1 +1 @@ -1873662a3af1848c37e4eb25722c8df9 +d41d8cd98f00b204e9800998ecf8427e