From patchwork Fri Sep 20 03:08:35 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lance Wang X-Patchwork-Id: 15171 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id B4777449CD6 for ; Fri, 20 Sep 2019 06:15:03 +0300 (EEST) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8125068A87F; Fri, 20 Sep 2019 06:15:03 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-pl1-f196.google.com (mail-pl1-f196.google.com [209.85.214.196]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6DF7C68A641 for ; Fri, 20 Sep 2019 06:14:57 +0300 (EEST) Received: by mail-pl1-f196.google.com with SMTP id e5so2521687pls.9 for ; Thu, 19 Sep 2019 20:14:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=EaM9Fr3aSZBpi4SK/DM2ogi64mqJsH0+4lJHxOnhBs4=; b=YGR7Xcs8UpxyU/2ZYJGbjq99+XCvFEuesAoRO/HCFyWwkwIaYA5La1NMdMPBprCNKq yyL00TUAFTNcmVo+3jHonw8O6QITF1YD1nqAIRF1LMyHC6a5F1tAL140oN7QpfMXEuEH qVxx5sCGrKO4d8LwdckYvYXpbvxOW01T8dyuZojJtNp9JHor55TpGR5z0L5wH6p/qHbc xofEzug3Sy+AQ6tUDLiZjdg/xTjQtkBeBRQzMeoN8I7JH8dO5nnOXm6uuzRyg3yhCbMG QmrGDfIa8Sry6X01ety8gCbAyYInQh99haWFVYk32g16aiFzT2jqtlPjhZC1R96dLHH2 p+PA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=EaM9Fr3aSZBpi4SK/DM2ogi64mqJsH0+4lJHxOnhBs4=; b=rK2E2gXHGQz0ysXpX3SqPZLXFBhLoBfXYi0EdWPHyDtkdPq7ccTmcno33MhJcqh120 2XdcFjFyBtZFBvaVCWXvJlPrdYYrkDkysQxtd5YoyWTo4YX+tdvRXBf6CpRsNEbdM46A Afjgwr3t7j3l1gyDVQX2swJ3Dc93tiMY5lj2mAH/an/p9xLmIGCXK9dMJpVHTX6in+1c Cq/uT9O1SjniqrQHuSwvYO6q9rqndW8h4kOz3mMx1Z3Pdr2qiY5OQFAv3pV79dkB84aJ YMi3wS1Osckd+Hyg++/GUeOgbeSYh1C4QgQIum0xwAR2mClIxORPh67thbsx7oIuSNe2 qSPQ== X-Gm-Message-State: APjAAAX6YDeL/bQz3YXmcMy8Ma2sfXOg+kKNTg1Vip746xfCFf+mrGqm B1hNssR1pVrV8tqibqDyj4jA9J77 X-Google-Smtp-Source: APXvYqwyu25/QUZxud6qmm1dq7XJ5nL9pjecMmvfhUJhjHhFCflaKPhdg42jkKJml6Ov5Z3oCHDSqQ== X-Received: by 2002:a17:902:bc41:: with SMTP id t1mr12924505plz.99.1568948931808; Thu, 19 Sep 2019 20:08:51 -0700 (PDT) Received: from vpn.localdomain ([47.90.99.151]) by smtp.gmail.com with ESMTPSA id e9sm289956pgs.86.2019.09.19.20.08.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 19 Sep 2019 20:08:51 -0700 (PDT) From: lance.lmwang@gmail.com To: ffmpeg-devel@ffmpeg.org Date: Fri, 20 Sep 2019 11:08:35 +0800 Message-Id: <20190920030836.4532-2-lance.lmwang@gmail.com> X-Mailer: git-send-email 2.9.5 In-Reply-To: <20190920030836.4532-1-lance.lmwang@gmail.com> References: <20190912233301.17664-1-lance.lmwang@gmail.com> <20190920030836.4532-1-lance.lmwang@gmail.com> Subject: [FFmpeg-devel] [PATCH v3 2/3] avfilter/vf_minterpolate: change the default threshold to get better scene change detect result X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Limin Wang MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" From: Limin Wang ./ffmpeg -loglevel debug -i ../fate-suite/svq3/Vertical400kbit.sorenson3.mov -vf minterpolate=fps=60:mi_mode=blend -an -f null - [Parsed_minterpolate_0 @ 0x7fe7f3e193c0] scene changed, input pts 1600 [Parsed_minterpolate_0 @ 0x7fe7f3e193c0] scene changed, input pts 4120 [Parsed_minterpolate_0 @ 0x7fe7f3e193c0] scene changed, input pts 5780 [Parsed_minterpolate_0 @ 0x7fe7f3e193c0] scene changed, input pts 6700 [Parsed_minterpolate_0 @ 0x7fe7f3e193c0] scene changed, input pts 8140 [Parsed_minterpolate_0 @ 0x7fe7f3e193c0] scene changed, input pts 9740 [Parsed_minterpolate_0 @ 0x7fe7f3e193c0] scene changed, input pts 14060 [Parsed_minterpolate_0 @ 0x7fe7f3e193c0] scene changed, input pts 15680 [Parsed_minterpolate_0 @ 0x7fe7f3e193c0] scene changed, input pts 18480 [Parsed_minterpolate_0 @ 0x7fe7f3e193c0] scene changed, input pts 20020 [Parsed_minterpolate_0 @ 0x7fe7f3e193c0] scene changed, input pts 21740 The results are consistent with tests/ref/fate/filter-metadata-scenedetect For the master, it'll detect more than 20 scene change for the same source. Signed-off-by: Limin Wang --- doc/filters.texi | 2 +- libavfilter/vf_minterpolate.c | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/doc/filters.texi b/doc/filters.texi index 06ce7ec069..fc299f1405 100644 --- a/doc/filters.texi +++ b/doc/filters.texi @@ -12743,7 +12743,7 @@ Frame difference. Corresponding pixel values are compared and if it satisfies @v Default method is @samp{fdiff}. @item scd_threshold -Scene change detection threshold. Default is @code{5.0}. +Scene change detection threshold. Default is @code{10.}. @end table @section mix diff --git a/libavfilter/vf_minterpolate.c b/libavfilter/vf_minterpolate.c index fc8054b710..c9ce80420d 100644 --- a/libavfilter/vf_minterpolate.c +++ b/libavfilter/vf_minterpolate.c @@ -230,7 +230,7 @@ static const AVOption minterpolate_options[] = { { "scd", "scene change detection method", OFFSET(scd_method), AV_OPT_TYPE_INT, {.i64 = SCD_METHOD_FDIFF}, SCD_METHOD_NONE, SCD_METHOD_FDIFF, FLAGS, "scene" }, CONST("none", "disable detection", SCD_METHOD_NONE, "scene"), CONST("fdiff", "frame difference", SCD_METHOD_FDIFF, "scene"), - { "scd_threshold", "scene change threshold", OFFSET(scd_threshold), AV_OPT_TYPE_DOUBLE, {.dbl = 5.0}, 0, 100.0, FLAGS }, + { "scd_threshold", "scene change threshold", OFFSET(scd_threshold), AV_OPT_TYPE_DOUBLE, {.dbl = 10.}, 0, 100.0, FLAGS }, { NULL } }; @@ -1097,6 +1097,7 @@ static void interpolate(AVFilterLink *inlink, AVFrame *avf_out) } if (mi_ctx->scene_changed) { + av_log(ctx, AV_LOG_DEBUG, "scene changed, input pts %"PRId64"\n", mi_ctx->frames[1].avf->pts); /* duplicate frame */ av_frame_copy(avf_out, alpha > ALPHA_MAX / 2 ? mi_ctx->frames[2].avf : mi_ctx->frames[1].avf); return;